diff options
| author | Lukas Reschke <lukas@owncloud.com> | 2015-02-13 12:49:34 +0100 |
|---|---|---|
| committer | Lukas Reschke <lukas@owncloud.com> | 2015-02-13 12:49:34 +0100 |
| commit | 9904b300700d916af5c0aa9c36fed7e5e589d12d (patch) | |
| tree | 2718a6226352cd407dd60e2a566f816cdb819b32 | |
| parent | 51f8d240c1c7a2c5fe4ab89854aeae02a33406b4 (diff) | |
| download | nextcloud-server-9904b300700d916af5c0aa9c36fed7e5e589d12d.tar.gz nextcloud-server-9904b300700d916af5c0aa9c36fed7e5e589d12d.zip | |
Ensure that passed argument is always a string
Some code paths called the `normalizePath` functionality with types other than a string which resulted in unexpected behaviour.
Thus the function is now manually casting the type to a string and I corrected the usage in list.php as well.
| -rw-r--r-- | apps/files/ajax/list.php | 2 | ||||
| -rw-r--r-- | lib/private/files/filesystem.php | 9 |
2 files changed, 10 insertions, 1 deletions
diff --git a/apps/files/ajax/list.php b/apps/files/ajax/list.php index 4aed79d70f7..b590776830a 100644 --- a/apps/files/ajax/list.php +++ b/apps/files/ajax/list.php @@ -5,7 +5,7 @@ OCP\JSON::checkLoggedIn(); $l = \OC::$server->getL10N('files'); // Load the files -$dir = isset($_GET['dir']) ? $_GET['dir'] : ''; +$dir = isset($_GET['dir']) ? (string)$_GET['dir'] : ''; $dir = \OC\Files\Filesystem::normalizePath($dir); try { diff --git a/lib/private/files/filesystem.php b/lib/private/files/filesystem.php index e933782ce2f..04f82d88cd1 100644 --- a/lib/private/files/filesystem.php +++ b/lib/private/files/filesystem.php @@ -723,9 +723,18 @@ class Filesystem { * Fix common problems with a file path * @param string $path * @param bool $stripTrailingSlash + * @param bool $isAbsolutePath * @return string */ public static function normalizePath($path, $stripTrailingSlash = true, $isAbsolutePath = false) { + /** + * FIXME: This is a workaround for existing classes and files which call + * this function with another type than a valid string. This + * conversion should get removed as soon as all existing + * function calls have been fixed. + */ + $path = (string)$path; + $cacheKey = json_encode([$path, $stripTrailingSlash, $isAbsolutePath]); if(isset(self::$normalizedPathCache[$cacheKey])) { |