diff options
| author | Carl Schwan <carl@carlschwan.eu> | 2021-08-06 14:22:09 +0200 |
|---|---|---|
| committer | Carl Schwan <carl@carlschwan.eu> | 2021-08-06 14:22:09 +0200 |
| commit | 07ccccecad473fef8f622689855d6aa0fdbf16ed (patch) | |
| tree | 6ebff35ec562ac0b63e7bfcda9840149f6f97b8b | |
| parent | 30d8704bf3d5d64f173f5671e34933aa22ad1ae4 (diff) | |
| download | nextcloud-server-07ccccecad473fef8f622689855d6aa0fdbf16ed.tar.gz nextcloud-server-07ccccecad473fef8f622689855d6aa0fdbf16ed.zip | |
Only recommand for php-sodium on >= PHP 7.4
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.
So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| -rw-r--r-- | apps/settings/lib/Controller/CheckSetupController.php | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index 21b05d98979..3e239c15c1b 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -627,7 +627,11 @@ Raw output } } - if (!defined('PASSWORD_ARGON2I')) { + if (!defined('PASSWORD_ARGON2I') && PHP_VERSION_ID >= 70400) { + // Installing php-sodium on >=php7.4 will provide PASSWORD_ARGON2I + // on previous version argon2 wasn't part of the "standard" extension + // and RedHat disabled it so even installing php-sodium won't provide argon2i + // support in password_hash/password_verify. $recommendedPHPModules[] = 'sodium'; } |