Merge pull request #31887 from nextcloud/techdebt/noid/log-primary-key-violation

Log missing primary key until we make it a requirement

1 files changed, 4 insertions, 1 deletions

diff --git a/lib/private/DB/MigrationService.php b/lib/private/DB/MigrationService.php
index 92f45dfdbe8..13bbe8dc5d0 100644
--- a/lib/private/DB/MigrationService.php
+++ b/lib/private/DB/MigrationService.php
@@ -652,7 +652,10 @@ class MigrationService {
 				if ($isUsingDefaultName && \strlen($table->getName()) - $prefixLength >= 23) {
 					throw new \InvalidArgumentException('Primary index name on "' . $table->getName() . '" is too long.');
 				}
-				// } elseif (!$primaryKey instanceof Index && !$sourceTable instanceof Table) {
+			} elseif (!$primaryKey instanceof Index && !$sourceTable instanceof Table) {
+				/** @var LoggerInterface $logger */
+				$logger = \OC::$server->get(LoggerInterface::class);
+				$logger->error('Table "' . $table->getName() . '" has no primary key and therefor will not behave sane in clustered setups. This will throw an exception and not be installable in a future version of Nextcloud.');
 				// throw new \InvalidArgumentException('Table "' . $table->getName() . '" has no primary key and therefor will not behave sane in clustered setups.');
 			}
 		}