summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Müller <thomas.mueller@tmit.eu>2013-11-26 14:13:33 +0100
committerThomas Müller <thomas.mueller@tmit.eu>2013-11-26 14:13:33 +0100
commit2a93720f3f967775f7e5279b99348f8e4346e951 (patch)
tree603861b0237df9d2f7ba1bcf72be6c3a01a6ffb0
parentdc67c7efa9ff20f8b4466e5b6490405439d4a90f (diff)
downloadnextcloud-server-2a93720f3f967775f7e5279b99348f8e4346e951.tar.gz
nextcloud-server-2a93720f3f967775f7e5279b99348f8e4346e951.zip
fixes #6050
-rwxr-xr-xlib/private/request.php29
-rw-r--r--tests/lib/request.php11
2 files changed, 29 insertions, 11 deletions
diff --git a/lib/private/request.php b/lib/private/request.php
index 7a75bf25208..bb3a05ba97d 100755
--- a/lib/private/request.php
+++ b/lib/private/request.php
@@ -142,17 +142,30 @@ class OC_Request {
$requestUri = '/' . ltrim($requestUri, '/');
}
+ // Remove the query string from REQUEST_URI
+ if ($pos = strpos($requestUri, '?')) {
+ $requestUri = substr($requestUri, 0, $pos);
+ }
+
$scriptName = $_SERVER['SCRIPT_NAME'];
- // in case uri and script name don't match we better throw an exception
- if (strpos($requestUri, $scriptName) !== 0) {
- throw new Exception("REQUEST_URI($requestUri) does not start with the SCRIPT_NAME($scriptName)");
+ $path_info = $requestUri;
+
+ // strip off the script name's dir and file name
+ list($path, $name) = \Sabre_DAV_URLUtil::splitPath($scriptName);
+ if (!empty($path)) {
+ if( $path === $path_info || strpos($path_info, $path.'/') === 0) {
+ $path_info = substr($path_info, strlen($path));
+ } else {
+ throw new Exception("The requested uri($requestUri) cannot be processed by the script '$scriptName')");
+ }
}
- $path_info = substr($requestUri, strlen($scriptName));
- // Remove the query string from REQUEST_URI
- if ($pos = strpos($path_info, '?')) {
- $path_info = substr($path_info, 0, $pos);
+ if (strpos($path_info, '/'.$name.'/') === 0) {
+ $path_info = substr($path_info, strlen($name) + 1);
}
- return $path_info;
+ if (strpos($path_info, $name) === 0) {
+ $path_info = substr($path_info, strlen($name));
+ }
+ return rtrim($path_info, '/');
}
/**
diff --git a/tests/lib/request.php b/tests/lib/request.php
index a740751f060..090cebc9231 100644
--- a/tests/lib/request.php
+++ b/tests/lib/request.php
@@ -42,6 +42,13 @@ class Test_Request extends PHPUnit_Framework_TestCase {
array('/core/ajax/translations.php', 'index.php/core/ajax/translations.php', 'index.php'),
array('/core/ajax/translations.php', '/index.php/core/ajax/translations.php', '/index.php'),
array('/core/ajax/translations.php', '//index.php/core/ajax/translations.php', '/index.php'),
+ array('', '/oc/core', '/oc/core/index.php'),
+ array('', '/oc/core/', '/oc/core/index.php'),
+ array('', '/oc/core/index.php', '/oc/core/index.php'),
+ array('/core/ajax/translations.php', '/core/ajax/translations.php', 'index.php'),
+ array('/core/ajax/translations.php', '//core/ajax/translations.php', '/index.php'),
+ array('/core/ajax/translations.php', '/oc/core/ajax/translations.php', '/oc/index.php'),
+ array('/1', '/oc/core/1', '/oc/core/index.php'),
);
}
@@ -60,9 +67,7 @@ class Test_Request extends PHPUnit_Framework_TestCase {
function rawPathInfoThrowsExceptionProvider() {
return array(
- array('core/ajax/translations.php', '/index.php'),
- array('/core/ajax/translations.php', '/index.php'),
- array('//core/ajax/translations.php', '/index.php'),
+ array('/oc/core1', '/oc/core/index.php'),
);
}
}