Add missing PHPDoc and properly throw exception

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

4 files changed, 8 insertions, 0 deletions

diff --git a/lib/private/Files/Storage/Common.php b/lib/private/Files/Storage/Common.php
index 0a0604ddd9c..6e5799be34c 100644
--- a/lib/private/Files/Storage/Common.php
+++ b/lib/private/Files/Storage/Common.php
@@ -706,6 +706,7 @@ abstract class Common implements Storage, ILockingStorage {
 			if ($logger) {
 				$logger->logException($e);
 			}
+			throw $e;
 		}
 	}
 
@@ -713,6 +714,7 @@ abstract class Common implements Storage, ILockingStorage {
 	 * @param string $path
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
 	 * @param \OCP\Lock\ILockingProvider $provider
+	 * @throws \OCP\Lock\LockedException
 	 */
 	public function releaseLock($path, $type, ILockingProvider $provider) {
 		$logger = $this->getLockLogger();
@@ -736,6 +738,7 @@ abstract class Common implements Storage, ILockingStorage {
 			if ($logger) {
 				$logger->logException($e);
 			}
+			throw $e;
 		}
 	}
 
@@ -743,6 +746,7 @@ abstract class Common implements Storage, ILockingStorage {
 	 * @param string $path
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
 	 * @param \OCP\Lock\ILockingProvider $provider
+	 * @throws \OCP\Lock\LockedException
 	 */
 	public function changeLock($path, $type, ILockingProvider $provider) {
 		$logger = $this->getLockLogger();
@@ -766,6 +770,7 @@ abstract class Common implements Storage, ILockingStorage {
 			if ($logger) {
 				$logger->logException($e);
 			}
+			throw $e;
 		}
 	}
 
diff --git a/lib/private/Files/Storage/Storage.php b/lib/private/Files/Storage/Storage.php
index 49a714587a7..281a8284107 100644
--- a/lib/private/Files/Storage/Storage.php
+++ b/lib/private/Files/Storage/Storage.php
@@ -107,6 +107,7 @@ interface Storage extends \OCP\Files\Storage {
 	 * @param string $path The path of the file to release the lock for
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
 	 * @param \OCP\Lock\ILockingProvider $provider
+	 * @throws \OCP\Lock\LockedException
 	 */
 	public function releaseLock($path, $type, ILockingProvider $provider);
 
diff --git a/lib/public/Files/Storage.php b/lib/public/Files/Storage.php
index cf67879908c..1532c84b621 100644
--- a/lib/public/Files/Storage.php
+++ b/lib/public/Files/Storage.php
@@ -425,6 +425,7 @@ interface Storage extends IStorage {
 	 * @param string $path The path of the file to acquire the lock for
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
 	 * @param \OCP\Lock\ILockingProvider $provider
+	 * @throws \OCP\Lock\LockedException
 	 * @since 8.1.0
 	 */
 	public function releaseLock($path, $type, ILockingProvider $provider);
diff --git a/lib/public/Files/Storage/ILockingStorage.php b/lib/public/Files/Storage/ILockingStorage.php
index 635c607537f..ac61e9a062e 100644
--- a/lib/public/Files/Storage/ILockingStorage.php
+++ b/lib/public/Files/Storage/ILockingStorage.php
@@ -46,6 +46,7 @@ interface ILockingStorage {
 	 * @param string $path The path of the file to acquire the lock for
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
 	 * @param \OCP\Lock\ILockingProvider $provider
+	 * @throws \OCP\Lock\LockedException
 	 * @since 9.0.0
 	 */
 	public function releaseLock($path, $type, ILockingProvider $provider);