summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJörn Friedrich Dreyer <jfd@butonic.de>2014-10-08 18:02:42 +0200
committerJörn Friedrich Dreyer <jfd@butonic.de>2014-10-20 11:29:05 +0200
commitca0e3fdfea51d8db52341c3866102e7058abc9c0 (patch)
treecc2f8d1e696d02029ce49744367ebccad5961327
parent9b0f0df7f52d16e71d40834035dd840ad4fa86b0 (diff)
downloadnextcloud-server-ca0e3fdfea51d8db52341c3866102e7058abc9c0.tar.gz
nextcloud-server-ca0e3fdfea51d8db52341c3866102e7058abc9c0.zip
throw exception in writeBack, the returned boolean is checked nowhere
-rw-r--r--lib/private/files/objectstore/objectstorestorage.php5
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/private/files/objectstore/objectstorestorage.php b/lib/private/files/objectstore/objectstorestorage.php
index 241864bcccd..ae8bff52896 100644
--- a/lib/private/files/objectstore/objectstorestorage.php
+++ b/lib/private/files/objectstore/objectstorestorage.php
@@ -349,7 +349,7 @@ class ObjectStoreStorage extends \OC\Files\Storage\Common {
public function writeBack($tmpFile) {
if (!isset(self::$tmpFiles[$tmpFile])) {
- return false;
+ return;
}
$path = self::$tmpFiles[$tmpFile];
@@ -375,9 +375,8 @@ class ObjectStoreStorage extends \OC\Files\Storage\Common {
} catch (\Exception $ex) {
$this->getCache()->remove($path);
\OCP\Util::writeLog('objectstore', 'Could not create object: ' . $ex->getMessage(), \OCP\Util::ERROR);
- return false;
+ throw $ex; // make this bubble up
}
- return true;
}
/**