diff options
| author | Robin Appelman <robin@icewind.nl> | 2023-09-20 12:29:50 +0200 |
|---|---|---|
| committer | Robin Appelman <robin@icewind.nl> | 2023-09-20 17:28:48 +0200 |
| commit | eab8dd3ca0d7bec23894d284fba5b9b5a37d0fba (patch) | |
| tree | ca57f8aeb7454073edbe75edf68aa550f0e2a5dc | |
| parent | 4ddbc55d5d1c7919ea299420283754a06ade4ddd (diff) | |
| download | nextcloud-server-eab8dd3ca0d7bec23894d284fba5b9b5a37d0fba.tar.gz nextcloud-server-eab8dd3ca0d7bec23894d284fba5b9b5a37d0fba.zip | |
use multipart copy for s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
| -rw-r--r-- | apps/files_external/lib/Lib/Storage/AmazonS3.php | 5 | ||||
| -rw-r--r-- | lib/private/Files/ObjectStore/S3ObjectTrait.php | 16 |
2 files changed, 13 insertions, 8 deletions
diff --git a/apps/files_external/lib/Lib/Storage/AmazonS3.php b/apps/files_external/lib/Lib/Storage/AmazonS3.php index 3d982bdab02..e9398815055 100644 --- a/apps/files_external/lib/Lib/Storage/AmazonS3.php +++ b/apps/files_external/lib/Lib/Storage/AmazonS3.php @@ -580,10 +580,7 @@ class AmazonS3 extends \OC\Files\Storage\Common { if ($isFile === true || $this->is_file($source)) { try { - $this->getConnection()->copyObject([ - 'Bucket' => $this->bucket, - 'Key' => $this->cleanKey($target), - 'CopySource' => S3Client::encodeKey($this->bucket . '/' . $source), + $this->copyObject($source, $target, [ 'StorageClass' => $this->storageClass, ]); $this->testTimeout(); diff --git a/lib/private/Files/ObjectStore/S3ObjectTrait.php b/lib/private/Files/ObjectStore/S3ObjectTrait.php index e0d0f2ce9c7..e9c52f11936 100644 --- a/lib/private/Files/ObjectStore/S3ObjectTrait.php +++ b/lib/private/Files/ObjectStore/S3ObjectTrait.php @@ -27,6 +27,7 @@ namespace OC\Files\ObjectStore; use Aws\S3\Exception\S3MultipartUploadException; +use Aws\S3\MultipartCopy; use Aws\S3\MultipartUploader; use Aws\S3\S3Client; use GuzzleHttp\Psr7; @@ -189,9 +190,16 @@ trait S3ObjectTrait { return $this->getConnection()->doesObjectExist($this->bucket, $urn, $this->getSSECParameters()); } - public function copyObject($from, $to) { - $this->getConnection()->copy($this->getBucket(), $from, $this->getBucket(), $to, 'private', [ - 'params' => $this->getSSECParameters() + $this->getSSECParameters(true) - ]); + public function copyObject($from, $to, array $options = []) { + $copy = new MultipartCopy($this->getConnection(), [ + "source_bucket" => $this->getBucket(), + "source_key" => $from + ], array_merge([ + "bucket" => $this->getBucket(), + "key" => $to, + "acl" => "private", + "params" => $this->getSSECParameters() + $this->getSSECParameters(true) + ], $options)); + $copy->copy(); } } |