summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Kesselberg <mail@danielkesselberg.de>2021-10-01 22:30:02 +0200
committerDaniel Kesselberg <mail@danielkesselberg.de>2021-10-01 23:08:59 +0200
commite6ab94894993f6a64402187a7a78007f0b6cc077 (patch)
treef03ba6352ad584ddab5affe5c31db3e18f7bf5ee
parentfb2fd3457650464230e052a91f573ba052950fef (diff)
downloadnextcloud-server-e6ab94894993f6a64402187a7a78007f0b6cc077.tar.gz
nextcloud-server-e6ab94894993f6a64402187a7a78007f0b6cc077.zip
Make AppsEnableTest and AppsDisableTest independet of the app version number
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
-rw-r--r--tests/Core/Command/Apps/AppsDisableTest.php18
-rw-r--r--tests/Core/Command/Apps/AppsEnableTest.php26
2 files changed, 22 insertions, 22 deletions
diff --git a/tests/Core/Command/Apps/AppsDisableTest.php b/tests/Core/Command/Apps/AppsDisableTest.php
index c6fcbf38b30..493dfc16f3e 100644
--- a/tests/Core/Command/Apps/AppsDisableTest.php
+++ b/tests/Core/Command/Apps/AppsDisableTest.php
@@ -55,31 +55,31 @@ class AppsDisableTest extends TestCase {
* @param $appId
* @param $groups
* @param $statusCode
- * @param $output
+ * @param $pattern
*/
- public function testCommandInput($appId, $statusCode, $output): void {
+ public function testCommandInput($appId, $statusCode, $pattern): void {
$input = ['app-id' => $appId];
$this->commandTester->execute($input);
- $this->assertStringContainsString($output, $this->commandTester->getDisplay());
+ $this->assertRegExp('/' . $pattern . '/', $this->commandTester->getDisplay());
$this->assertSame($statusCode, $this->commandTester->getStatusCode());
}
public function dataCommandInput(): array {
return [
- [['admin_audit'], 0, 'admin_audit 1.13.0 disabled'],
- [['comments'], 0, 'comments 1.13.0 disabled'],
+ [['admin_audit'], 0, 'admin_audit ([\d\.]*) disabled'],
+ [['comments'], 0, 'comments ([\d\.]*) disabled'],
[['invalid_app'], 0, 'No such app enabled: invalid_app'],
- [['admin_audit', 'comments'], 0, "admin_audit 1.13.0 disabled\ncomments 1.13.0 disabled"],
- [['admin_audit', 'comments', 'invalid_app'], 0, "admin_audit 1.13.0 disabled\ncomments 1.13.0 disabled\nNo such app enabled: invalid_app"],
+ [['admin_audit', 'comments'], 0, "admin_audit ([\d\.]*) disabled\ncomments ([\d\.]*) disabled"],
+ [['admin_audit', 'comments', 'invalid_app'], 0, "admin_audit ([\d\.]*) disabled\ncomments ([\d\.]*) disabled\nNo such app enabled: invalid_app"],
[['files'], 2, "files can't be disabled"],
[['provisioning_api'], 2, "provisioning_api can't be disabled"],
- [['files', 'admin_audit'], 2, "files can't be disabled.\nadmin_audit 1.13.0 disabled"],
- [['provisioning_api', 'comments'], 2, "provisioning_api can't be disabled.\ncomments 1.13.0 disabled"],
+ [['files', 'admin_audit'], 2, "files can't be disabled.\nadmin_audit ([\d\.]*) disabled"],
+ [['provisioning_api', 'comments'], 2, "provisioning_api can't be disabled.\ncomments ([\d\.]*) disabled"],
];
}
}
diff --git a/tests/Core/Command/Apps/AppsEnableTest.php b/tests/Core/Command/Apps/AppsEnableTest.php
index 77d93668a49..73a7d3f449f 100644
--- a/tests/Core/Command/Apps/AppsEnableTest.php
+++ b/tests/Core/Command/Apps/AppsEnableTest.php
@@ -56,9 +56,9 @@ class AppsEnableTest extends TestCase {
* @param $appId
* @param $groups
* @param $statusCode
- * @param $output
+ * @param $pattern
*/
- public function testCommandInput($appId, $groups, $statusCode, $output): void {
+ public function testCommandInput($appId, $groups, $statusCode, $pattern): void {
$input = ['app-id' => $appId];
if (is_array($groups)) {
@@ -67,29 +67,29 @@ class AppsEnableTest extends TestCase {
$this->commandTester->execute($input);
- $this->assertStringContainsString($output, $this->commandTester->getDisplay());
+ $this->assertRegExp('/' . $pattern . '/', $this->commandTester->getDisplay());
$this->assertSame($statusCode, $this->commandTester->getStatusCode());
}
public function dataCommandInput(): array {
return [
- [['admin_audit'], null, 0, 'admin_audit 1.13.0 enabled'],
- [['comments'], null, 0, 'comments 1.13.0 enabled'],
- [['comments', 'comments'], null, 0, "comments 1.13.0 enabled\ncomments already enabled"],
+ [['admin_audit'], null, 0, 'admin_audit ([\d\.]*) enabled'],
+ [['comments'], null, 0, 'comments ([\d\.]*) enabled'],
+ [['comments', 'comments'], null, 0, "comments ([\d\.]*) enabled\ncomments already enabled"],
[['invalid_app'], null, 1, 'Could not download app invalid_app'],
- [['admin_audit', 'comments'], null, 0, "admin_audit 1.13.0 enabled\ncomments 1.13.0 enabled"],
- [['admin_audit', 'comments', 'invalid_app'], null, 1, "admin_audit 1.13.0 enabled\ncomments 1.13.0 enabled\nCould not download app invalid_app"],
+ [['admin_audit', 'comments'], null, 0, "admin_audit ([\d\.]*) enabled\ncomments ([\d\.]*) enabled"],
+ [['admin_audit', 'comments', 'invalid_app'], null, 1, "admin_audit ([\d\.]*) enabled\ncomments ([\d\.]*) enabled\nCould not download app invalid_app"],
[['admin_audit'], ['admin'], 1, "admin_audit can't be enabled for groups"],
[['comments'], ['admin'], 1, "comments can't be enabled for groups"],
- [['updatenotification'], ['admin'], 0, 'updatenotification 1.13.0 enabled for groups: admin'],
- [['updatenotification', 'accessibility'], ['admin'], 0, "updatenotification 1.13.0 enabled for groups: admin\naccessibility 1.9.0 enabled for groups: admin"],
+ [['updatenotification'], ['admin'], 0, 'updatenotification ([\d\.]*) enabled for groups: admin'],
+ [['updatenotification', 'accessibility'], ['admin'], 0, "updatenotification ([\d\.]*) enabled for groups: admin\naccessibility ([\d\.]*) enabled for groups: admin"],
- [['updatenotification'], ['admin', 'invalid_group'], 0, 'updatenotification 1.13.0 enabled for groups: admin'],
- [['updatenotification', 'accessibility'], ['admin', 'invalid_group'], 0, "updatenotification 1.13.0 enabled for groups: admin\naccessibility 1.9.0 enabled for groups: admin"],
- [['updatenotification', 'accessibility', 'invalid_app'], ['admin', 'invalid_group'], 1, "updatenotification 1.13.0 enabled for groups: admin\naccessibility 1.9.0 enabled for groups: admin\nCould not download app invalid_app"],
+ [['updatenotification'], ['admin', 'invalid_group'], 0, 'updatenotification ([\d\.]*) enabled for groups: admin'],
+ [['updatenotification', 'accessibility'], ['admin', 'invalid_group'], 0, "updatenotification ([\d\.]*) enabled for groups: admin\naccessibility ([\d\.]*) enabled for groups: admin"],
+ [['updatenotification', 'accessibility', 'invalid_app'], ['admin', 'invalid_group'], 1, "updatenotification ([\d\.]*) enabled for groups: admin\naccessibility ([\d\.]*) enabled for groups: admin\nCould not download app invalid_app"],
];
}
}