diff options
| author | Morris Jobke <hey@morrisjobke.de> | 2016-08-18 15:44:50 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2016-08-18 15:44:50 +0200 |
| commit | f5bbf824783eef4681f991d09c6cc71633a149a7 (patch) | |
| tree | b54f793e7dfa852909a448aacb586db3575bf437 | |
| parent | 2d025db0181a789bd18e323a038067aa8f41a516 (diff) | |
| parent | f7092c981f7b5498adb474fee73c594d772d98a8 (diff) | |
| download | nextcloud-server-f5bbf824783eef4681f991d09c6cc71633a149a7.tar.gz nextcloud-server-f5bbf824783eef4681f991d09c6cc71633a149a7.zip | |
Merge pull request #933 from nextcloud/backport-930-check-isset-require-9
[stable9] Fix "Undefined index" when the values do not exist
| -rw-r--r-- | lib/private/app/codechecker/infochecker.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/private/app/codechecker/infochecker.php b/lib/private/app/codechecker/infochecker.php index 3ee99dc6478..77bf7e8182d 100644 --- a/lib/private/app/codechecker/infochecker.php +++ b/lib/private/app/codechecker/infochecker.php @@ -80,7 +80,7 @@ class InfoChecker extends BasicEmitter { $info = $this->infoParser->parse($appPath . '/appinfo/info.xml'); - if (isset($info['dependencies']['owncloud']['@attributes']['min-version']) && ($info['requiremin'] || $info['require'])) { + if (isset($info['dependencies']['owncloud']['@attributes']['min-version']) && (isset($info['requiremin']) || isset($info['require']))) { $this->emit('InfoChecker', 'duplicateRequirement', ['min']); $errors[] = [ 'type' => 'duplicateRequirement', @@ -90,7 +90,7 @@ class InfoChecker extends BasicEmitter { $this->emit('InfoChecker', 'missingRequirement', ['min']); } - if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && $info['requiremax']) { + if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && isset($info['requiremax'])) { $this->emit('InfoChecker', 'duplicateRequirement', ['max']); $errors[] = [ 'type' => 'duplicateRequirement', |