diff options
| author | Georg Ehrke <developer@georgehrke.com> | 2015-03-13 17:23:02 +0100 |
|---|---|---|
| committer | Georg Ehrke <developer@georgehrke.com> | 2015-03-16 10:57:01 +0100 |
| commit | 09b05373edc48849dc1be43dece326aec0f9cd07 (patch) | |
| tree | e6c92e05d65c067c0e52e987ba2f8d860ab1dfab | |
| parent | 0d9f149dd93997085b85e2b174f5989a1b996263 (diff) | |
| download | nextcloud-server-09b05373edc48849dc1be43dece326aec0f9cd07.tar.gz nextcloud-server-09b05373edc48849dc1be43dece326aec0f9cd07.zip | |
validate resource's integrity before using it
| -rw-r--r-- | lib/private/image.php | 5 | ||||
| -rw-r--r-- | tests/lib/image.php | 5 |
2 files changed, 9 insertions, 1 deletions
diff --git a/lib/private/image.php b/lib/private/image.php index 317b6fde160..2484aeecc63 100644 --- a/lib/private/image.php +++ b/lib/private/image.php @@ -283,9 +283,12 @@ class OC_Image { } /** - * @return string Returns the raw image data. + * @return null|string Returns the raw image data. */ function data() { + if (!$this->valid()) { + return null; + } ob_start(); switch ($this->mimeType) { case "image/png": diff --git a/tests/lib/image.php b/tests/lib/image.php index e0009b9710e..0ee517100ad 100644 --- a/tests/lib/image.php +++ b/tests/lib/image.php @@ -144,6 +144,11 @@ class Test_Image extends \Test\TestCase { $this->assertEquals($expected, $img->data()); } + public function testDataNoResource() { + $img = new \OC_Image(); + $this->assertNull($img->data()); + } + /** * @depends testData */ |