aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArthur Schiwon <blizzz@arthur-schiwon.de>2024-06-12 11:05:43 +0200
committerArthur Schiwon <blizzz@arthur-schiwon.de>2024-06-12 11:05:43 +0200
commitfc584b78746bfff6e9f396417767afcca25f40f6 (patch)
treedbdc97d3b003bacff3e6db439fff3b3d391b3db1
parenta51237a7a1af60af34ebd1662889630eed44fd88 (diff)
downloadnextcloud-server-fc584b78746bfff6e9f396417767afcca25f40f6.tar.gz
nextcloud-server-fc584b78746bfff6e9f396417767afcca25f40f6.zip
fix(Token): make new scope future compatible
- "password-unconfirmable" is the effective name for 30, but a draft name was backported. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
-rw-r--r--lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php2
-rw-r--r--lib/private/Template/JSConfigHelper.php2
-rw-r--r--lib/private/legacy/OC_User.php2
-rw-r--r--tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php2
4 files changed, 4 insertions, 4 deletions
diff --git a/lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php b/lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
index 27328e17b03..8d00f6b7423 100644
--- a/lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
+++ b/lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
@@ -103,7 +103,7 @@ class PasswordConfirmationMiddleware extends Middleware {
return;
}
$scope = $token->getScopeAsArray();
- if (isset($scope['sso-based-login']) && $scope['sso-based-login'] === true) {
+ if (isset($scope['password-unconfirmable']) && $scope['password-unconfirmable'] === true) {
// Users logging in from SSO backends cannot confirm their password by design
return;
}
diff --git a/lib/private/Template/JSConfigHelper.php b/lib/private/Template/JSConfigHelper.php
index 48bf84d7306..7148e4ce696 100644
--- a/lib/private/Template/JSConfigHelper.php
+++ b/lib/private/Template/JSConfigHelper.php
@@ -312,6 +312,6 @@ class JSConfigHelper {
return true;
}
$scope = $token->getScopeAsArray();
- return !isset($scope['sso-based-login']) || $scope['sso-based-login'] === false;
+ return !isset($scope['password-unconfirmable']) || $scope['password-unconfirmable'] === false;
}
}
diff --git a/lib/private/legacy/OC_User.php b/lib/private/legacy/OC_User.php
index 1d6085f72ee..7f2dd195ecc 100644
--- a/lib/private/legacy/OC_User.php
+++ b/lib/private/legacy/OC_User.php
@@ -202,7 +202,7 @@ class OC_User {
if (empty($password)) {
$tokenProvider = \OC::$server->get(IProvider::class);
$token = $tokenProvider->getToken($userSession->getSession()->getId());
- $token->setScope(['sso-based-login' => true]);
+ $token->setScope(['password-unconfirmable' => true]);
$tokenProvider->updateToken($token);
}
diff --git a/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php b/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php
index ed51837acbf..280a10fe90a 100644
--- a/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php
+++ b/tests/lib/AppFramework/Middleware/Security/PasswordConfirmationMiddlewareTest.php
@@ -198,7 +198,7 @@ class PasswordConfirmationMiddlewareTest extends TestCase {
$token = $this->createMock(IToken::class);
$token->method('getScopeAsArray')
- ->willReturn(['sso-based-login' => true]);
+ ->willReturn(['password-unconfirmable' => true]);
$this->tokenProvider->expects($this->once())
->method('getToken')
->with($sessionId)