diff options
| author | Abijeet <abijeetpatro@gmail.com> | 2018-01-19 02:10:26 +0530 |
|---|---|---|
| committer | Abijeet <abijeetpatro@gmail.com> | 2018-03-27 00:49:34 +0530 |
| commit | 61b38a16fa69880603d3aa2ad21fd2b541c67772 (patch) | |
| tree | 1064696cd793a162246238e3af495270b479d09c /apps/comments/js | |
| parent | b3e1026cabc4f64670f404a3ae45d01507dac17d (diff) | |
| download | nextcloud-server-61b38a16fa69880603d3aa2ad21fd2b541c67772.tar.gz nextcloud-server-61b38a16fa69880603d3aa2ad21fd2b541c67772.zip | |
Fixes the following UI issues,
1. Increased the size of the delete, edit, close and submit buttons to take up 44x44px.
2. Now showing the delete button at all times when editing to avoid usability issues with touch screens.
3. Edit icon is also shown at all times, rather than only on hover.
4. Reduced the gap between comments a wee bit.
5. Fixed issues with focus event now working properly for edit and delete.
6. Removed absolute positioning of elements for alignment.
7. Fixed issue with tooltips becoming too high due to padding around actions. Occurred due to my changes.
8. Changed the position of the submit and close icons.
9. Fixed issue with jumping of the delete icon in Firefox. Occurred due to my changes.
10. Fixed issue with wrapping of content due to long author names. Occurred due to my changes.
11. Fixed issue with longer comments not appearing properly. This might have occurred due to my changes.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Diffstat (limited to 'apps/comments/js')
| -rw-r--r-- | apps/comments/js/commentstabview.js | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/apps/comments/js/commentstabview.js b/apps/comments/js/commentstabview.js index 73f19b7cd0b..36495e0690a 100644 --- a/apps/comments/js/commentstabview.js +++ b/apps/comments/js/commentstabview.js @@ -26,16 +26,16 @@ ' <div class="avatar currentUser" data-username="{{actorId}}"></div>' + ' <div class="author currentUser">{{actorDisplayName}}</div>' + '{{#if isEditMode}}' + - ' <a href="#" class="action delete icon icon-delete has-tooltip" title="{{deleteTooltip}}"></a>' + - ' <div class="deleteLoading icon-loading-small hidden"></div>'+ + ' <div class="action-container">' + + ' <a href="#" class="action delete icon icon-delete has-tooltip" title="{{deleteTooltip}}"></a>' + + ' <a href="#" class="action cancel icon icon-close has-tooltip" title="{{cancelText}}"></a>' + + ' <div class="deleteLoading icon-loading-small hidden"></div>'+ + ' </div>' + '{{/if}}' + ' </div>' + ' <form class="newCommentForm">' + ' <div contentEditable="true" class="message" data-placeholder="{{newMessagePlaceholder}}">{{message}}</div>' + ' <input class="submit icon-confirm" type="submit" value="" />' + - '{{#if isEditMode}}' + - ' <input class="cancel pull-right" type="button" value="{{cancelText}}" />' + - '{{/if}}' + ' <div class="submitLoading icon-loading-small hidden"></div>'+ ' </form>' + '</{{tag}}>'; |