diff options
| author | Hamid Dehnavi <hamid.dev.pro@gmail.com> | 2023-07-17 18:59:30 +0330 |
|---|---|---|
| committer | Faraz Samapoor <f.samapoor@gmail.com> | 2023-09-28 09:16:03 +0330 |
| commit | 92b75bc7984f1c663f553736f8e61fb9c17bacab (patch) | |
| tree | 96fa3f20c1145ab4fa7c2e82bcaa8072413c9912 /apps/comments | |
| parent | 878288004e728839bda930cf655a68ae0a1c2b31 (diff) | |
| download | nextcloud-server-92b75bc7984f1c663f553736f8e61fb9c17bacab.tar.gz nextcloud-server-92b75bc7984f1c663f553736f8e61fb9c17bacab.zip | |
Make adjustments based on the review
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
Diffstat (limited to 'apps/comments')
| -rw-r--r-- | apps/comments/lib/Activity/Listener.php | 3 | ||||
| -rw-r--r-- | apps/comments/lib/Activity/Provider.php | 3 | ||||
| -rw-r--r-- | apps/comments/lib/Controller/NotificationsController.php | 3 | ||||
| -rw-r--r-- | apps/comments/lib/Search/Result.php | 15 |
4 files changed, 12 insertions, 12 deletions
diff --git a/apps/comments/lib/Activity/Listener.php b/apps/comments/lib/Activity/Listener.php index 88e61f8ebcc..341b2e7ac65 100644 --- a/apps/comments/lib/Activity/Listener.php +++ b/apps/comments/lib/Activity/Listener.php @@ -35,9 +35,6 @@ use OCP\IUserSession; use OCP\Share\IShareHelper; class Listener { - /** - * Listener constructor. - */ public function __construct( protected IManager $activityManager, protected IUserSession $session, diff --git a/apps/comments/lib/Activity/Provider.php b/apps/comments/lib/Activity/Provider.php index d64eaff062a..b139b18371d 100644 --- a/apps/comments/lib/Activity/Provider.php +++ b/apps/comments/lib/Activity/Provider.php @@ -39,7 +39,8 @@ class Provider implements IProvider { public function __construct( protected IFactory $languageFactory, - protected IURLGenerator $url, protected ICommentsManager $commentsManager, + protected IURLGenerator $url, + protected ICommentsManager $commentsManager, protected IUserManager $userManager, protected IManager $activityManager, ) { diff --git a/apps/comments/lib/Controller/NotificationsController.php b/apps/comments/lib/Controller/NotificationsController.php index 0a1f1c1c149..b0255e62639 100644 --- a/apps/comments/lib/Controller/NotificationsController.php +++ b/apps/comments/lib/Controller/NotificationsController.php @@ -43,9 +43,6 @@ use OCP\Notification\IManager; */ #[IgnoreOpenAPI] class NotificationsController extends Controller { - /** - * NotificationsController constructor. - */ public function __construct( string $appName, IRequest $request, diff --git a/apps/comments/lib/Search/Result.php b/apps/comments/lib/Search/Result.php index 6e1e3790818..f4abf3864c1 100644 --- a/apps/comments/lib/Search/Result.php +++ b/apps/comments/lib/Search/Result.php @@ -39,19 +39,23 @@ class Result extends BaseResult { /** * @deprecated 20.0.0 */ - public string $comment; + public $comment; /** * @deprecated 20.0.0 */ - public string $authorId; + public $authorId; /** * @deprecated 20.0.0 */ - public string $path; + public string $authorName; /** * @deprecated 20.0.0 */ - public string $fileName; + public $path; + /** + * @deprecated 20.0.0 + */ + public $fileName; /** * @throws NotFoundException @@ -60,7 +64,7 @@ class Result extends BaseResult { public function __construct( string $search, IComment $comment, - public string $authorName, + string $authorName, string $path, ) { parent::__construct( @@ -71,6 +75,7 @@ class Result extends BaseResult { $this->comment = $this->getRelevantMessagePart($comment->getMessage(), $search); $this->authorId = $comment->getActorId(); + $this->authorName = $authorName; $this->fileName = basename($path); $this->path = $this->getVisiblePath($path); } |