diff options
| author | Roeland Jago Douma <roeland@famdouma.nl> | 2017-12-29 21:09:19 +0100 |
|---|---|---|
| committer | Roeland Jago Douma <roeland@famdouma.nl> | 2018-01-02 10:28:09 +0100 |
| commit | 4c0c3c0bef43fcaf831f82bd00ee90261408bfbd (patch) | |
| tree | 158dbc2af730790817becb0dea357da48dd700bf /apps/comments | |
| parent | fa2fe34b7a2189fd147f5796b8c24696a4ed8131 (diff) | |
| download | nextcloud-server-4c0c3c0bef43fcaf831f82bd00ee90261408bfbd.tar.gz nextcloud-server-4c0c3c0bef43fcaf831f82bd00ee90261408bfbd.zip | |
Show max warning comment lenth again
Fixes #7414
Since we no longer use an input field we have to use text instead of
val.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Diffstat (limited to 'apps/comments')
| -rw-r--r-- | apps/comments/js/commentstabview.js | 2 | ||||
| -rw-r--r-- | apps/comments/tests/js/commentstabviewSpec.js | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/apps/comments/js/commentstabview.js b/apps/comments/js/commentstabview.js index 9b75cb4671e..bd89c8bbb49 100644 --- a/apps/comments/js/commentstabview.js +++ b/apps/comments/js/commentstabview.js @@ -512,7 +512,7 @@ _onTypeComment: function(ev) { var $field = $(ev.target); - var len = $field.val().length; + var len = $field.text().length; var $submitButton = $field.data('submitButtonEl'); if (!$submitButton) { $submitButton = $field.closest('form').find('.submit'); diff --git a/apps/comments/tests/js/commentstabviewSpec.js b/apps/comments/tests/js/commentstabviewSpec.js index 813b2a72eae..0131bc7bce3 100644 --- a/apps/comments/tests/js/commentstabviewSpec.js +++ b/apps/comments/tests/js/commentstabviewSpec.js @@ -411,7 +411,7 @@ describe('OCA.Comments.CommentsTabView tests', function() { expect($message.hasClass('error')).toEqual(false); }); it('displays tooltip when limit is almost reached', function() { - $message.val(createMessageWithLength(view._commentMaxLength - 2)); + $message.text(createMessageWithLength(view._commentMaxLength - 2)); $message.trigger('change'); expect(tooltipStub.calledWith('show')).toEqual(true); @@ -419,7 +419,7 @@ describe('OCA.Comments.CommentsTabView tests', function() { expect($message.hasClass('error')).toEqual(false); }); it('displays tooltip and disabled button when limit is exceeded', function() { - $message.val(createMessageWithLength(view._commentMaxLength + 2)); + $message.text(createMessageWithLength(view._commentMaxLength + 2)); $message.trigger('change'); expect(tooltipStub.calledWith('show')).toEqual(true); |