diff options
| author | Daniel Kesselberg <mail@danielkesselberg.de> | 2023-09-14 11:56:25 +0200 |
|---|---|---|
| committer | Daniel <mail@danielkesselberg.de> | 2023-09-14 12:19:22 +0200 |
| commit | 108916cf5eafbbbba1707867619cb828c75771d6 (patch) | |
| tree | 724bbfe8b28b330539e251d6eebedd42b58595dd /apps/dav/lib/Migration | |
| parent | 30a7eabad3f00fe10fa2d66725297a559aa82c3c (diff) | |
| download | nextcloud-server-108916cf5eafbbbba1707867619cb828c75771d6.tar.gz nextcloud-server-108916cf5eafbbbba1707867619cb828c75771d6.zip | |
fix: use faster method to fetch user count
countUsers: the actual user count reported by the backend.
countSeenUsers: count every user who was logged in once.
1: We should avoid expensive operations (like asking every backend for it's user count) in migrations.
2: The current check is wrong because countUsers returns an array. var_dump([] > 1000) => true ;)
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Diffstat (limited to 'apps/dav/lib/Migration')
| -rw-r--r-- | apps/dav/lib/Migration/Version1027Date20230504122946.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/dav/lib/Migration/Version1027Date20230504122946.php b/apps/dav/lib/Migration/Version1027Date20230504122946.php index 998be8111ca..6d0ac9f6f86 100644 --- a/apps/dav/lib/Migration/Version1027Date20230504122946.php +++ b/apps/dav/lib/Migration/Version1027Date20230504122946.php @@ -49,7 +49,7 @@ class Version1027Date20230504122946 extends SimpleMigrationStep { * @param array $options */ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void { - if($this->userManager->countUsers() > 1000) { + if($this->userManager->countSeenUsers() > 1000) { $this->config->setAppValue('dav', 'needs_system_address_book_sync', 'yes'); $output->info('Could not sync system address books during update - too many user records have been found. Please call occ dav:sync-system-addressbook manually.'); return; |