summaryrefslogtreecommitdiffstats
path: root/apps/dav/lib
diff options
context:
space:
mode:
authorRobin Appelman <robin@icewind.nl>2018-06-28 14:53:44 +0200
committerRobin Appelman <robin@icewind.nl>2018-07-18 15:32:58 +0200
commit821d658ec357c167e37760fc8c099e00a24d6dd3 (patch)
tree905b0ee33c8a724e9a3a9a8b5def9b38b07af2bb /apps/dav/lib
parent01eb420a1e6f06a1089ad45fb9102ddf39c23533 (diff)
downloadnextcloud-server-821d658ec357c167e37760fc8c099e00a24d6dd3.tar.gz
nextcloud-server-821d658ec357c167e37760fc8c099e00a24d6dd3.zip
Fix search related results in OPTIONS requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
Diffstat (limited to 'apps/dav/lib')
-rw-r--r--apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php3
-rw-r--r--apps/dav/lib/Files/LazySearchBackend.php72
-rw-r--r--apps/dav/lib/Server.php10
3 files changed, 82 insertions, 3 deletions
diff --git a/apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php b/apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php
index cefa0d5a19a..7a62f706378 100644
--- a/apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php
+++ b/apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php
@@ -56,6 +56,9 @@ class AnonymousOptionsPlugin extends ServerPlugin {
// setup a fake tree for anonymous access
$this->server->tree = new Tree(new Directory(''));
$corePlugin->httpOptions($request, $response);
+ $this->server->emit('afterMethod', [$request, $response]);
+ $this->server->emit('afterMethod:OPTIONS', [$request, $response]);
+
$this->server->sapi->sendResponse($response);
return false;
}
diff --git a/apps/dav/lib/Files/LazySearchBackend.php b/apps/dav/lib/Files/LazySearchBackend.php
new file mode 100644
index 00000000000..6369046ae10
--- /dev/null
+++ b/apps/dav/lib/Files/LazySearchBackend.php
@@ -0,0 +1,72 @@
+<?php
+/**
+ * @copyright Copyright (c) 2018 Robin Appelman <robin@icewind.nl>
+ *
+ * @author Robin Appelman <robin@icewind.nl>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\DAV\Files;
+
+use SearchDAV\Backend\ISearchBackend;
+use SearchDAV\Query\Query;
+
+class LazySearchBackend implements ISearchBackend {
+ /**
+ * @var ISearchBackend $backend
+ */
+ private $backend = null;
+
+ public function setBackend(ISearchBackend $backend) {
+ $this->backend = $backend;
+ }
+
+ public function getArbiterPath() {
+ if ($this->backend) {
+ return $this->backend->getArbiterPath();
+ } else {
+ return '';
+ }
+ }
+
+ public function isValidScope($href, $depth, $path) {
+ if ($this->backend) {
+ return $this->backend->getArbiterPath();
+ } else {
+ return false;
+ }
+ }
+
+ public function getPropertyDefinitionsForScope($href, $path) {
+ if ($this->backend) {
+ return $this->backend->getArbiterPath();
+ } else {
+ return [];
+ }
+ }
+
+ public function search(Query $query) {
+ if ($this->backend) {
+ return $this->backend->getArbiterPath();
+ } else {
+ return [];
+ }
+ }
+
+
+}
diff --git a/apps/dav/lib/Server.php b/apps/dav/lib/Server.php
index 7aae79e2101..a9cbfca7144 100644
--- a/apps/dav/lib/Server.php
+++ b/apps/dav/lib/Server.php
@@ -55,6 +55,7 @@ use OCA\DAV\DAV\CustomPropertiesBackend;
use OCA\DAV\Connector\Sabre\QuotaPlugin;
use OCA\DAV\Files\BrowserErrorPagePlugin;
use OCA\DAV\Connector\Sabre\AnonymousOptionsPlugin;
+use OCA\DAV\Files\LazySearchBackend;
use OCA\DAV\SystemTag\SystemTagPlugin;
use OCA\DAV\Upload\ChunkingPlugin;
use OCP\IRequest;
@@ -197,8 +198,11 @@ class Server {
$this->server->addPlugin(new BrowserErrorPagePlugin());
}
+ $lazySearchBackend = new LazySearchBackend();
+ $this->server->addPlugin(new SearchPlugin($lazySearchBackend));
+
// wait with registering these until auth is handled and the filesystem is setup
- $this->server->on('beforeMethod', function () use ($root) {
+ $this->server->on('beforeMethod', function () use ($root, $lazySearchBackend) {
// custom properties plugin must be the last one
$userSession = \OC::$server->getUserSession();
$user = $userSession->getUser();
@@ -257,13 +261,13 @@ class Server {
\OC::$server->getGroupManager(),
$userFolder
));
- $this->server->addPlugin(new SearchPlugin(new \OCA\DAV\Files\FileSearchBackend(
+ $lazySearchBackend->setBackend(new \OCA\DAV\Files\FileSearchBackend(
$this->server->tree,
$user,
\OC::$server->getRootFolder(),
\OC::$server->getShareManager(),
$view
- )));
+ ));
}
$this->server->addPlugin(new \OCA\DAV\CalDAV\BirthdayCalendar\EnablePlugin(
\OC::$server->getConfig(),