Add command to move a calendar from an user to another

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

Add a basic check for displaynames in case we fail to get calendar from uri and put some sf console styles & refactor a bit

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

basic Tests

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

add forgotten createNamedParameter()

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

2 files changed, 138 insertions, 0 deletions

diff --git a/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php b/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php
index 44609f2ca6c..1b2169b6675 100644
--- a/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php
+++ b/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php
@@ -983,4 +983,21 @@ EOD;
 
 		$this->assertEquals(null, $this->backend->getCalendarObject($subscriptionId, $uri, CalDavBackend::CALENDAR_TYPE_SUBSCRIPTION));
 	}
+
+	public function testCalendarMovement()
+	{
+		$this->backend->createCalendar(self::UNIT_TEST_USER, 'Example', []);
+
+		$this->assertCount(1, $this->backend->getCalendarsForUser(self::UNIT_TEST_USER));
+
+		$calendarInfoUser = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER)[0];
+
+		$this->backend->moveCalendar('Example', self::UNIT_TEST_USER, self::UNIT_TEST_USER1);
+		$this->assertCount(0, $this->backend->getCalendarsForUser(self::UNIT_TEST_USER));
+		$this->assertCount(1, $this->backend->getCalendarsForUser(self::UNIT_TEST_USER1));
+
+		$calendarInfoUser1 = $this->backend->getCalendarsForUser(self::UNIT_TEST_USER1)[0];
+		$this->assertEquals($calendarInfoUser['id'], $calendarInfoUser1['id']);
+		$this->assertEquals($calendarInfoUser['uri'], $calendarInfoUser1['uri']);
+	}
 }
diff --git a/apps/dav/tests/unit/Command/MoveCalendarTest.php b/apps/dav/tests/unit/Command/MoveCalendarTest.php
new file mode 100644
index 00000000000..12329fd4af1
--- /dev/null
+++ b/apps/dav/tests/unit/Command/MoveCalendarTest.php
@@ -0,0 +1,121 @@
+<?php
+/**
+ * @author Thomas Citharel <tcit@tcit.fr>
+ *
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+namespace OCA\DAV\Tests\Command;
+
+use InvalidArgumentException;
+use OCA\DAV\Command\MoveCalendar;
+use OCP\IDBConnection;
+use OCP\IGroupManager;
+use OCP\IL10N;
+use OCP\IUserManager;
+use Symfony\Component\Console\Tester\CommandTester;
+use Test\TestCase;
+
+
+/**
+ * Class MoveCalendarTest
+ *
+ * @package OCA\DAV\Tests\Command
+ * @group DB
+ */
+class MoveCalendarTest extends TestCase {
+
+	/** @var \OCP\IUserManager|\PHPUnit_Framework_MockObject_MockObject $userManager */
+	private $userManager;
+
+	/** @var \OCP\IGroupManager|\PHPUnit_Framework_MockObject_MockObject $groupManager */
+	private $groupManager;
+
+	/** @var \OCP\IDBConnection|\PHPUnit_Framework_MockObject_MockObject $dbConnection */
+	private $dbConnection;
+
+	/** @var \OCP\IL10N|\PHPUnit_Framework_MockObject_MockObject $l10n */
+	private $l10n;
+
+	/** @var MoveCalendar */
+	private $command;
+
+	protected function setUp() {
+		parent::setUp();
+
+		$this->userManager = $this->createMock(IUserManager::class);
+		$this->groupManager = $this->createMock(IGroupManager::class);
+		$this->dbConnection = $this->createMock(IDBConnection::class);
+		$this->l10n = $this->createMock(IL10N::class);
+
+		$this->command = new MoveCalendar(
+			$this->userManager,
+			$this->groupManager,
+			$this->dbConnection,
+			$this->l10n
+		);
+	}
+
+	public function dataExecute() {
+		return [
+			[false, true],
+			[true, false]
+		];
+	}
+
+	/**
+	 * @dataProvider dataExecute
+	 *
+	 * @expectedException InvalidArgumentException
+	 * @param $userOriginExists
+	 * @param $userDestinationExists
+	 */
+	public function testWithBadUserOrigin($userOriginExists, $userDestinationExists)
+	{
+		$this->userManager->expects($this->at(0))
+			->method('userExists')
+			->with('user')
+			->willReturn($userOriginExists);
+
+		if (!$userDestinationExists) {
+			$this->userManager->expects($this->at(1))
+				->method('userExists')
+				->with('user2')
+				->willReturn($userDestinationExists);
+		}
+
+		$commandTester = new CommandTester($this->command);
+		$commandTester->execute([
+			'name' => $this->command->getName(),
+			'userorigin' => 'user',
+			'userdestination' => 'user2',
+		]);
+	}
+
+	/**
+	 * @expectedException InvalidArgumentException
+	 * @expectedExceptionMessage User can't be system
+	 */
+	public function testTryToMoveToOrFromSystem()
+	{
+		$commandTester = new CommandTester($this->command);
+		$commandTester->execute([
+			'name' => $this->command->getName(),
+			'userorigin' => 'system',
+			'userdestination' => 'user2',
+		]);
+	}
+}
\ No newline at end of file