Provide dav setting for user's default calendar

And add tests to handle schedule-default-calendar-URL

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

1 files changed, 221 insertions, 2 deletions

diff --git a/apps/dav/tests/unit/CalDAV/Schedule/PluginTest.php b/apps/dav/tests/unit/CalDAV/Schedule/PluginTest.php
index 859dccbe489..aa245b71419 100644
--- a/apps/dav/tests/unit/CalDAV/Schedule/PluginTest.php
+++ b/apps/dav/tests/unit/CalDAV/Schedule/PluginTest.php
@@ -25,28 +25,68 @@
 
 namespace OCA\DAV\Tests\unit\CalDAV\Schedule;
 
+use OCA\DAV\CalDAV\CalDavBackend;
+use OCA\DAV\CalDAV\CalendarHome;
+use OCA\DAV\CalDAV\Plugin as CalDAVPlugin;
 use OCA\DAV\CalDAV\Schedule\Plugin;
+use OCP\IConfig;
+use PHPUnit\Framework\MockObject\MockObject;
+use Sabre\DAV\PropFind;
 use Sabre\DAV\Server;
+use Sabre\DAV\Tree;
 use Sabre\DAV\Xml\Property\Href;
+use Sabre\DAV\Xml\Property\LocalHref;
+use Sabre\DAVACL\IPrincipal;
+use Sabre\HTTP\ResponseInterface;
 use Sabre\VObject\Parameter;
 use Sabre\VObject\Property\ICalendar\CalAddress;
+use Sabre\Xml\Service;
 use Test\TestCase;
 
 class PluginTest extends TestCase {
 	/** @var Plugin */
 	private $plugin;
-	/** @var Server|\PHPUnit_Framework_MockObject_MockObject */
+	/** @var Server|MockObject */
 	private $server;
 
+	/** @var IConfig|MockObject  */
+	private $config;
+
 	protected function setUp(): void {
 		parent::setUp();
 
 		$this->server = $this->createMock(Server::class);
+		$this->config = $this->createMock(IConfig::class);
+
+		$response = $this->getMockBuilder(ResponseInterface::class)
+			->disableOriginalConstructor()
+			->getMock();
 
-		$this->plugin = new Plugin();
+		$this->server->httpResponse = $response;
+		$this->server->xml = new Service();
+
+		$this->plugin = new Plugin($this->config);
 		$this->plugin->initialize($this->server);
 	}
 
+	public function testInitialize() {
+		$plugin = new Plugin($this->config);
+
+		$this->server->expects($this->at(7))
+			->method('on')
+			->with('propFind', [$plugin, 'propFindDefaultCalendarUrl'], 90);
+
+		$this->server->expects($this->at(8))
+			->method('on')
+			->with('afterWriteContent', [$plugin, 'dispatchSchedulingResponses']);
+
+		$this->server->expects($this->at(9))
+			->method('on')
+			->with('afterCreateFile', [$plugin, 'dispatchSchedulingResponses']);
+
+		$plugin->initialize($this->server);
+	}
+
 	public function testGetAddressesForPrincipal() {
 		$href = $this->createMock(Href::class);
 		$href
@@ -125,4 +165,183 @@ class PluginTest extends TestCase {
 		$this->assertFalse($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property2]));
 		$this->assertFalse($this->invokePrivate($this->plugin, 'getAttendeeRSVP', [$property3]));
 	}
+
+	public function propFindDefaultCalendarUrlProvider(): array {
+		return [
+			[
+				'principals/users/myuser',
+				'calendars/myuser',
+				false,
+				CalDavBackend::PERSONAL_CALENDAR_URI,
+				CalDavBackend::PERSONAL_CALENDAR_NAME,
+				true
+			],
+			[
+				'principals/users/myuser',
+				'calendars/myuser',
+				false,
+				CalDavBackend::PERSONAL_CALENDAR_URI,
+				CalDavBackend::PERSONAL_CALENDAR_NAME,
+				false
+			],
+			[
+				'principals/users/myuser',
+				null,
+				false,
+				CalDavBackend::PERSONAL_CALENDAR_URI,
+				CalDavBackend::PERSONAL_CALENDAR_NAME,
+				true
+			],
+			[
+				'principals/users/myuser',
+				'calendars/myuser',
+				false,
+				CalDavBackend::PERSONAL_CALENDAR_URI,
+				CalDavBackend::PERSONAL_CALENDAR_NAME,
+				true,
+				false,
+			],
+			[
+				'principals/users/myuser',
+				'calendars/myuser',
+				false,
+				'my_other_calendar',
+				'My Other Calendar',
+				true
+			],
+			[
+				'principals/calendar-resources',
+				'system-calendars/calendar-resources/myuser',
+				true,
+				CalDavBackend::RESOURCE_BOOKING_CALENDAR_URI,
+				CalDavBackend::RESOURCE_BOOKING_CALENDAR_NAME,
+				true
+			],
+			[
+				'principals/calendar-resources',
+				'system-calendars/calendar-resources/myuser',
+				true,
+				CalDavBackend::RESOURCE_BOOKING_CALENDAR_URI,
+				CalDavBackend::RESOURCE_BOOKING_CALENDAR_NAME,
+				false
+			],
+			[
+				'principals/something-else',
+				'calendars/whatever',
+				false,
+				CalDavBackend::PERSONAL_CALENDAR_URI,
+				CalDavBackend::PERSONAL_CALENDAR_NAME,
+				true
+			],
+		];
+	}
+
+	/**
+	 * @dataProvider propFindDefaultCalendarUrlProvider
+	 * @param string $principalUri
+	 * @param string $calendarHome
+	 * @param bool $isResource
+	 * @param string $calendarUri
+	 * @param string $displayName
+	 * @param bool $exists
+	 * @param bool $propertiesForPath
+	 */
+	public function testPropFindDefaultCalendarUrl(string $principalUri, ?string $calendarHome, bool $isResource, string $calendarUri, string $displayName, bool $exists, bool $propertiesForPath = true) {
+		/** @var PropFind $propFind */
+		$propFind = new PropFind(
+			$principalUri,
+			[
+				Plugin::SCHEDULE_DEFAULT_CALENDAR_URL
+			],
+			0
+		);
+		/** @var IPrincipal|MockObject $node */
+		$node = $this->getMockBuilder(IPrincipal::class)
+			->disableOriginalConstructor()
+			->getMock();
+
+		$node->expects($this->once())
+			->method('getPrincipalUrl')
+			->with()
+			->willReturn($principalUri);
+
+		$calDAVPlugin = $this->getMockBuilder(CalDAVPlugin::class)
+			->disableOriginalConstructor()
+			->getMock();
+
+		$calDAVPlugin->expects($this->once())
+			->method('getCalendarHomeForPrincipal')
+			->willReturn($calendarHome);
+
+		$this->server->expects($this->once())
+			->method('getPlugin')
+			->with('caldav')
+			->willReturn($calDAVPlugin);
+		if (!$calendarHome) {
+			$this->plugin->propFindDefaultCalendarUrl($propFind, $node);
+
+			$this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
+			return;
+		}
+		if ($principalUri === 'principals/something-else') {
+			$this->plugin->propFindDefaultCalendarUrl($propFind, $node);
+
+			$this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
+			return;
+		}
+		if (!$isResource) {
+			$this->config->expects($this->once())
+				->method('getUserValue')
+				->with('myuser', 'dav', 'defaultCalendar', CalDavBackend::PERSONAL_CALENDAR_URI)
+				->willReturn($calendarUri);
+		}
+
+		$calendarHomeObject = $this->createMock(CalendarHome::class);
+		$calendarHomeObject->expects($this->once())
+			->method('childExists')
+			->with($calendarUri)
+			->willReturn($exists);
+
+		if (!$exists) {
+			$calendarBackend = $this->createMock(CalDavBackend::class);
+			$calendarBackend->expects($this->once())
+				->method('createCalendar')
+				->with($principalUri, $calendarUri, [
+					'{DAV:}displayname' => $displayName,
+				]);
+
+			$calendarHomeObject->expects($this->once())
+				->method('getCalDAVBackend')
+				->with()
+				->willReturn($calendarBackend);
+		}
+
+		/** @var Tree|MockObject $tree */
+		$tree = $this->createMock(Tree::class);
+		$tree->expects($this->once())
+			->method('getNodeForPath')
+			->with($calendarHome)
+			->willReturn($calendarHomeObject);
+		$this->server->tree = $tree;
+
+		$properties = $propertiesForPath ? [
+			['href' => '/remote.php/dav/' . $calendarHome . '/' . $calendarUri]
+		] : [];
+
+		$this->server->expects($this->once())
+			->method('getPropertiesForPath')
+			->with($calendarHome .'/' . $calendarUri, [], 1)
+			->willReturn($properties);
+
+		$this->plugin->propFindDefaultCalendarUrl($propFind, $node);
+
+		if (!$propertiesForPath) {
+			$this->assertNull($propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL));
+			return;
+		}
+
+		/** @var LocalHref $result */
+		$result = $propFind->get(Plugin::SCHEDULE_DEFAULT_CALENDAR_URL);
+		$this->assertEquals('/remote.php/dav/'. $calendarHome . '/' . $calendarUri, $result->getHref());
+	}
 }