Merge pull request #8112 from nextcloud/fix-integer-overflow

Fix integer overflow in ChunkingPlugin

1 files changed, 4 insertions, 1 deletions

diff --git a/apps/dav/lib/Upload/ChunkingPlugin.php b/apps/dav/lib/Upload/ChunkingPlugin.php
index a3f6e528c6b..421a2dd519a 100644
--- a/apps/dav/lib/Upload/ChunkingPlugin.php
+++ b/apps/dav/lib/Upload/ChunkingPlugin.php
@@ -97,7 +97,10 @@ class ChunkingPlugin extends ServerPlugin {
 			return;
 		}
 		$actualSize = $this->sourceNode->getSize();
-		if ((int)$expectedSize !== $actualSize) {
+
+		// casted to string because cast to float cause equality for non equal numbers
+		// and integer has the problem of limited size on 32 bit systems
+		if ((string)$expectedSize !== (string)$actualSize) {
 			throw new BadRequest("Chunks on server do not sum up to $expectedSize but to $actualSize bytes");
 		}
 	}