Move index.php from files to AppFramework

1. Allows it to use the more secure CSP rules of the AppFramework.
2. Adds some unit tests.

1 files changed, 224 insertions, 0 deletions

diff --git a/apps/files/controller/viewcontroller.php b/apps/files/controller/viewcontroller.php
new file mode 100644
index 00000000000..c274680e525
--- /dev/null
+++ b/apps/files/controller/viewcontroller.php
@@ -0,0 +1,224 @@
+<?php
+/**
+ * @author Lukas Reschke <lukas@owncloud.com>
+ *
+ * @copyright Copyright (c) 2015, ownCloud, Inc.
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+namespace OCA\Files\Controller;
+
+use OC\AppFramework\Http\Request;
+use OCP\AppFramework\Controller;
+use OCP\AppFramework\Http\RedirectResponse;
+use OCP\AppFramework\Http\TemplateResponse;
+use OCP\IL10N;
+use OCP\INavigationManager;
+use OCP\IRequest;
+use OCP\IURLGenerator;
+use OCP\IConfig;
+use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+
+/**
+ * Class ViewController
+ *
+ * @package OCA\Files\Controller
+ */
+class ViewController extends Controller {
+	/** @var string */
+	protected $appName;
+	/** @var IRequest */
+	protected $request;
+	/** @var IURLGenerator */
+	protected $urlGenerator;
+	/** @var INavigationManager */
+	protected $navigationManager;
+	/** @var IL10N */
+	protected $l10n;
+	/** @var IConfig */
+	protected $config;
+	/** @var EventDispatcherInterface */
+	protected $eventDispatcher;
+
+	/**
+	 * @param string $appName
+	 * @param IRequest $request
+	 * @param IURLGenerator $urlGenerator
+	 * @param INavigationManager $navigationManager
+	 * @param IL10N $l10n
+	 * @param IConfig $config
+	 * @param EventDispatcherInterface $eventDispatcherInterface
+	 */
+	public function __construct($appName,
+								IRequest $request,
+								IURLGenerator $urlGenerator,
+								INavigationManager $navigationManager,
+								IL10N $l10n,
+								IConfig $config,
+								EventDispatcherInterface $eventDispatcherInterface) {
+		parent::__construct($appName, $request);
+		$this->appName = $appName;
+		$this->request = $request;
+		$this->urlGenerator = $urlGenerator;
+		$this->navigationManager = $navigationManager;
+		$this->l10n = $l10n;
+		$this->config = $config;
+		$this->eventDispatcher = $eventDispatcherInterface;
+	}
+
+	/**
+	 * @param string $appName
+	 * @param string $scriptName
+	 * @return string
+	 */
+	protected function renderScript($appName, $scriptName) {
+		$content = '';
+		$appPath = \OC_App::getAppPath($appName);
+		$scriptPath = $appPath . '/' . $scriptName;
+		if (file_exists($scriptPath)) {
+			// TODO: sanitize path / script name ?
+			ob_start();
+			include $scriptPath;
+			$content = ob_get_contents();
+			@ob_end_clean();
+		}
+		return $content;
+	}
+
+	/**
+	 * FIXME: Replace with non static code
+	 *
+	 * @return array
+	 * @throws \OCP\Files\NotFoundException
+	 */
+	protected function getStorageInfo() {
+		$dirInfo = \OC\Files\Filesystem::getFileInfo('/', false);
+		return \OC_Helper::getStorageInfo('/', $dirInfo);
+	}
+
+	/**
+	 * @NoCSRFRequired
+	 * @NoAdminRequired
+	 *
+	 * @param string $dir
+	 * @param string $view
+	 * @return TemplateResponse
+	 * @throws \OCP\Files\NotFoundException
+	 */
+	public function index($dir = '', $view = '') {
+		// Load the files we need
+		\OCP\Util::addStyle('files', 'files');
+		\OCP\Util::addStyle('files', 'upload');
+		\OCP\Util::addStyle('files', 'mobile');
+		\OCP\Util::addscript('files', 'app');
+		\OCP\Util::addscript('files', 'file-upload');
+		\OCP\Util::addscript('files', 'newfilemenu');
+		\OCP\Util::addscript('files', 'jquery.iframe-transport');
+		\OCP\Util::addscript('files', 'jquery.fileupload');
+		\OCP\Util::addscript('files', 'jquery-visibility');
+		\OCP\Util::addscript('files', 'fileinfomodel');
+		\OCP\Util::addscript('files', 'filesummary');
+		\OCP\Util::addscript('files', 'breadcrumb');
+		\OCP\Util::addscript('files', 'filelist');
+		\OCP\Util::addscript('files', 'search');
+
+		\OCP\Util::addScript('files', 'favoritesfilelist');
+		\OCP\Util::addScript('files', 'tagsplugin');
+		\OCP\Util::addScript('files', 'favoritesplugin');
+
+		\OCP\Util::addScript('files', 'detailfileinfoview');
+		\OCP\Util::addScript('files', 'detailtabview');
+		\OCP\Util::addScript('files', 'mainfileinfodetailview');
+		\OCP\Util::addScript('files', 'detailsview');
+		\OCP\Util::addStyle('files', 'detailsView');
+
+		\OC_Util::addVendorScript('core', 'handlebars/handlebars');
+
+		\OCP\Util::addscript('files', 'fileactions');
+		\OCP\Util::addscript('files', 'fileactionsmenu');
+		\OCP\Util::addscript('files', 'files');
+		\OCP\Util::addscript('files', 'keyboardshortcuts');
+		\OCP\Util::addscript('files', 'navigation');
+
+		// if IE8 and "?dir=path&view=someview" was specified, reformat the URL to use a hash like "#?dir=path&view=someview"
+		$isIE8 = $this->request->isUserAgent([Request::USER_AGENT_IE_8]);
+		if ($isIE8 && ($dir !== '' || $view !== '')) {
+			$dir = !empty($dir) ? $dir : '/';
+			$view = !empty($view) ? $view : 'files';
+			$hash = '#?dir=' . \OCP\Util::encodePath($dir);
+			if ($view !== 'files') {
+				$hash .= '&view=' . urlencode($view);
+			}
+			return new RedirectResponse($this->urlGenerator->linkToRoute('files.view.index') . $hash);
+		}
+
+		// mostly for the home storage's free space
+		// FIXME: Make non static
+		$storageInfo = $this->getStorageInfo();
+
+		$nav = new \OCP\Template('files', 'appnavigation', '');
+
+		\OCA\Files\App::getNavigationManager()->add(
+			[
+				'id' => 'favorites',
+				'appname' => 'files',
+				'script' => 'simplelist.php',
+				'order' => 5,
+				'name' => $this->l10n->t('Favorites')
+			]
+		);
+
+		$navItems = \OCA\Files\App::getNavigationManager()->getAll();
+		usort($navItems, function($item1, $item2) {
+			return $item1['order'] - $item2['order'];
+		});
+		$nav->assign('navigationItems', $navItems);
+
+		$contentItems = [];
+
+		// render the container content for every navigation item
+		foreach ($navItems as $item) {
+			$content = '';
+			if (isset($item['script'])) {
+				$content = $this->renderScript($item['appname'], $item['script']);
+			}
+			$contentItem = [];
+			$contentItem['id'] = $item['id'];
+			$contentItem['content'] = $content;
+			$contentItems[] = $contentItem;
+		}
+
+		$this->eventDispatcher->dispatch('OCA\Files::loadAdditionalScripts');
+
+		$params = [];
+		$params['usedSpacePercent'] = (int)$storageInfo['relative'];
+		$params['owner'] = $storageInfo['owner'];
+		$params['ownerDisplayName'] = $storageInfo['ownerDisplayName'];
+		$params['isPublic'] = false;
+		$params['mailNotificationEnabled'] = $this->config->getAppValue('core', 'shareapi_allow_mail_notification', 'no');
+		$params['mailPublicNotificationEnabled'] = $this->config->getAppValue('core', 'shareapi_allow_public_notification', 'no');
+		$params['allowShareWithLink'] = $this->config->getAppValue('core', 'shareapi_allow_links', 'yes');
+		$params['appNavigation'] = $nav;
+		$params['appContents'] = $contentItems;
+		$this->navigationManager->setActiveEntry('files_index');
+
+		return new TemplateResponse(
+			$this->appName,
+			'index',
+			$params
+		);
+	}
+}