Ignore favorites that are not available when creating the favorites list

Also correctly return the exception for all cases when adding/removing favos

1 files changed, 6 insertions, 0 deletions

diff --git a/apps/files/controller/apicontroller.php b/apps/files/controller/apicontroller.php
index 902731a0492..a8bea27e4bb 100644
--- a/apps/files/controller/apicontroller.php
+++ b/apps/files/controller/apicontroller.php
@@ -67,6 +67,7 @@ class ApiController extends Controller {
 	 *
 	 * @param string $path path
 	 * @param array  $tags array of tags
+	 * @return DataResponse
 	 */
 	public function updateFileTags($path, $tags = null) {
 		$result = array();
@@ -76,6 +77,10 @@ class ApiController extends Controller {
 				$this->tagService->updateFileTags($path, $tags);
 			} catch (\OCP\Files\NotFoundException $e) {
 				return new DataResponse($e->getMessage(), Http::STATUS_NOT_FOUND);
+			} catch (\OCP\Files\StorageNotAvailableException $e) {
+				return new DataResponse($e->getMessage(), Http::STATUS_SERVICE_UNAVAILABLE);
+			} catch (\Exception $e) {
+				return new DataResponse($e->getMessage(), Http::STATUS_NOT_FOUND);
 			}
 			$result['tags'] = $tags;
 		}
@@ -89,6 +94,7 @@ class ApiController extends Controller {
 	 * @CORS
 	 *
 	 * @param array $tagName tag name to filter by
+	 * @return DataResponse
 	 */
 	public function getFilesByTag($tagName) {
 		$files = array();