Merge pull request #37453 from nextcloud/fix/36918-The_breadcrumb_navigation_represents_a_list_and_should_best_be_implemented_as_such

 the breadcrumb navigation represents a list and should best be implemented as such

1 files changed, 5 insertions, 3 deletions

diff --git a/apps/files/js/breadcrumb.js b/apps/files/js/breadcrumb.js
index 1083be461bb..ed1170b0f59 100644
--- a/apps/files/js/breadcrumb.js
+++ b/apps/files/js/breadcrumb.js
@@ -32,7 +32,7 @@
 	 * the URL of a given breadcrumb
 	 */
 	var BreadCrumb = function(options){
-		this.$el = $('<div class="breadcrumb"></div>');
+		this.$el = $('<nav></nav>');
 		this.$menu = $('<div class="popovermenu menu-center"><ul></ul></div>');
 
 		this.crumbSelector = '.crumb:not(.hidden):not(.crumbhome):not(.crumbmenu)';
@@ -123,12 +123,13 @@
 			var $menuItem;
 			this.$el.empty();
 			this.breadcrumbs = [];
+			var $crumbList = $('<ul class="breadcrumb"></ul>');
 
 			for (var i = 0; i < parts.length; i++) {
 				var part = parts[i];
 				var $image;
 				var $link = $('<a></a>');
-				$crumb = $('<div class="crumb svg"></div>');
+				$crumb = $('<li class="crumb svg"></li>');
 				if(part.dir) {
 					$link.attr('href', this.getCrumbUrl(part, i));
 				}
@@ -149,12 +150,13 @@
 					$link.append($image);
 				}
 				this.breadcrumbs.push($crumb);
-				this.$el.append($crumb);
+				$crumbList.append($crumb);
 				// Only add feedback if not menu
 				if (this.onClick && i !== 0) {
 					$link.on('click', this.onClick);
 				}
 			}
+			this.$el.append($crumbList);
 
 			// Menu creation
 			this._createMenu();