diff options
author | Ferdinand Thiessen <opensource@fthiessen.de> | 2024-06-17 17:06:53 +0200 |
---|---|---|
committer | Ferdinand Thiessen <opensource@fthiessen.de> | 2024-06-23 16:53:09 +0200 |
commit | a83f276352785ddde18954ee14de772037690428 (patch) | |
tree | 5155014bdbb58f988fe52812e3b68af6de68fbaa /apps/files | |
parent | 475edf24c2c6c4216b77f8031ddcdada752fca32 (diff) | |
download | nextcloud-server-a83f276352785ddde18954ee14de772037690428.tar.gz nextcloud-server-a83f276352785ddde18954ee14de772037690428.zip |
refactor(files): Update `@nextcloud/files` to v3.5.0
* Removed now duplicated code
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Diffstat (limited to 'apps/files')
-rw-r--r-- | apps/files/src/actions/moveOrCopyAction.ts | 3 | ||||
-rw-r--r-- | apps/files/src/actions/openFolderAction.ts | 2 | ||||
-rw-r--r-- | apps/files/src/components/BreadCrumbs.vue | 2 | ||||
-rw-r--r-- | apps/files/src/components/DragAndDropPreview.vue | 2 | ||||
-rw-r--r-- | apps/files/src/components/FileEntryMixin.ts | 6 | ||||
-rw-r--r-- | apps/files/src/components/NewNodeDialog.vue | 2 | ||||
-rw-r--r-- | apps/files/src/utils/davUtils.js | 9 | ||||
-rw-r--r-- | apps/files/src/utils/fileUtils.ts | 35 | ||||
-rw-r--r-- | apps/files/src/views/FilesList.vue | 4 |
9 files changed, 10 insertions, 55 deletions
diff --git a/apps/files/src/actions/moveOrCopyAction.ts b/apps/files/src/actions/moveOrCopyAction.ts index d7c7fa8d057..623170d3be6 100644 --- a/apps/files/src/actions/moveOrCopyAction.ts +++ b/apps/files/src/actions/moveOrCopyAction.ts @@ -10,7 +10,7 @@ import type { MoveCopyResult } from './moveOrCopyActionUtils' import { isAxiosError } from '@nextcloud/axios' import { FilePickerClosed, getFilePickerBuilder, showError } from '@nextcloud/dialogs' import { emit } from '@nextcloud/event-bus' -import { Permission, FileAction, FileType, NodeStatus, davGetClient, davRootPath, davResultToNode, davGetDefaultPropfind } from '@nextcloud/files' +import { FileAction, FileType, NodeStatus, davGetClient, davRootPath, davResultToNode, davGetDefaultPropfind, getUniqueName } from '@nextcloud/files' import { translate as t } from '@nextcloud/l10n' import { openConflictPicker, hasConflict } from '@nextcloud/upload' import { basename, join } from 'path' @@ -22,7 +22,6 @@ import FolderMoveSvg from '@mdi/svg/svg/folder-move.svg?raw' import { MoveCopyAction, canCopy, canMove, getQueue } from './moveOrCopyActionUtils' import { getContents } from '../services/Files' import logger from '../logger' -import { getUniqueName } from '../utils/fileUtils' /** * Return the action that is possible for the given nodes diff --git a/apps/files/src/actions/openFolderAction.ts b/apps/files/src/actions/openFolderAction.ts index f6de2fdf6b2..8c40ac6ede8 100644 --- a/apps/files/src/actions/openFolderAction.ts +++ b/apps/files/src/actions/openFolderAction.ts @@ -10,7 +10,7 @@ export const action = new FileAction({ id: 'open-folder', displayName(files: Node[]) { // Only works on single node - const displayName = files[0].attributes.displayName || files[0].basename + const displayName = files[0].attributes.displayname || files[0].basename return t('files', 'Open folder {displayName}', { displayName }) }, iconSvgInline: () => FolderSvg, diff --git a/apps/files/src/components/BreadCrumbs.vue b/apps/files/src/components/BreadCrumbs.vue index 88f592a4cdf..2c678ba82fa 100644 --- a/apps/files/src/components/BreadCrumbs.vue +++ b/apps/files/src/components/BreadCrumbs.vue @@ -160,7 +160,7 @@ export default defineComponent({ const source: FileSource | undefined = this.getFileSourceFromPath(path) const node: Node | undefined = source ? this.getNodeFromSource(source) : undefined - return node?.attributes?.displayName || basename(path) + return node?.attributes?.displayname || basename(path) }, onClick(to) { diff --git a/apps/files/src/components/DragAndDropPreview.vue b/apps/files/src/components/DragAndDropPreview.vue index 0ef6bed9abc..c19b166581f 100644 --- a/apps/files/src/components/DragAndDropPreview.vue +++ b/apps/files/src/components/DragAndDropPreview.vue @@ -62,7 +62,7 @@ export default Vue.extend({ summary(): string { if (this.isSingleNode) { const node = this.nodes[0] - return node.attributes?.displayName || node.basename + return node.attributes?.displayname || node.basename } return getSummaryFor(this.nodes) diff --git a/apps/files/src/components/FileEntryMixin.ts b/apps/files/src/components/FileEntryMixin.ts index 6a6b69b99fc..f0f63f9dd30 100644 --- a/apps/files/src/components/FileEntryMixin.ts +++ b/apps/files/src/components/FileEntryMixin.ts @@ -71,14 +71,14 @@ export default defineComponent({ }, extension() { - if (this.source.attributes?.displayName) { - return extname(this.source.attributes.displayName) + if (this.source.attributes?.displayname) { + return extname(this.source.attributes.displayname) } return this.source.extension || '' }, displayName() { const ext = this.extension - const name = String(this.source.attributes.displayName + const name = String(this.source.attributes.displayname || this.source.basename) // Strip extension from name if defined diff --git a/apps/files/src/components/NewNodeDialog.vue b/apps/files/src/components/NewNodeDialog.vue index a4477408faf..1ac65421dfe 100644 --- a/apps/files/src/components/NewNodeDialog.vue +++ b/apps/files/src/components/NewNodeDialog.vue @@ -30,7 +30,7 @@ import type { PropType } from 'vue' import { defineComponent } from 'vue' import { translate as t } from '@nextcloud/l10n' -import { getUniqueName } from '../utils/fileUtils' +import { getUniqueName } from '@nextcloud/files' import NcButton from '@nextcloud/vue/dist/Components/NcButton.js' import NcDialog from '@nextcloud/vue/dist/Components/NcDialog.js' diff --git a/apps/files/src/utils/davUtils.js b/apps/files/src/utils/davUtils.js index a4c9ccac755..8c28c25c044 100644 --- a/apps/files/src/utils/davUtils.js +++ b/apps/files/src/utils/davUtils.js @@ -3,17 +3,8 @@ * SPDX-License-Identifier: AGPL-3.0-or-later */ -import { generateRemoteUrl } from '@nextcloud/router' import { getCurrentUser } from '@nextcloud/auth' -export const getRootPath = function() { - if (getCurrentUser()) { - return generateRemoteUrl(`dav/files/${getCurrentUser().uid}`) - } else { - return generateRemoteUrl('webdav').replace('/remote.php', '/public.php') - } -} - export const isPublic = function() { return !getCurrentUser() } diff --git a/apps/files/src/utils/fileUtils.ts b/apps/files/src/utils/fileUtils.ts index 2427e330352..255c106740d 100644 --- a/apps/files/src/utils/fileUtils.ts +++ b/apps/files/src/utils/fileUtils.ts @@ -2,44 +2,9 @@ * SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors * SPDX-License-Identifier: AGPL-3.0-or-later */ -import { basename, extname } from 'path' import { FileType, type Node } from '@nextcloud/files' import { translate as t, translatePlural as n } from '@nextcloud/l10n' -// TODO: move to @nextcloud/files -/** - * Create an unique file name - * @param name The initial name to use - * @param otherNames Other names that are already used - * @param options Optional parameters for tuning the behavior - * @param options.suffix A function that takes an index and returns a suffix to add to the file name, defaults to '(index)' - * @param options.ignoreFileExtension Set to true to ignore the file extension when adding the suffix (when getting a unique directory name) - * @return Either the initial name, if unique, or the name with the suffix so that the name is unique - */ -export const getUniqueName = ( - name: string, - otherNames: string[], - options: { - suffix?: (i: number) => string, - ignoreFileExtension?: boolean, - } = {}, -): string => { - const opts = { - suffix: (n: number) => `(${n})`, - ignoreFileExtension: false, - ...options, - } - - let newName = name - let i = 1 - while (otherNames.includes(newName)) { - const ext = opts.ignoreFileExtension ? '' : extname(name) - const base = basename(name, ext) - newName = `${base} ${opts.suffix(i++)}${ext}` - } - return newName -} - /** * Extract dir and name from file path * diff --git a/apps/files/src/views/FilesList.vue b/apps/files/src/views/FilesList.vue index ae20c58ea32..493437225d6 100644 --- a/apps/files/src/views/FilesList.vue +++ b/apps/files/src/views/FilesList.vue @@ -284,8 +284,8 @@ export default defineComponent({ ...(this.userConfig.sort_folders_first ? [v => v.type !== 'folder'] : []), // 3: Use sorting mode if NOT basename (to be able to use displayName too) ...(this.sortingMode !== 'basename' ? [v => v[this.sortingMode]] : []), - // 4: Use displayName if available, fallback to name - v => v.attributes?.displayName || v.basename, + // 4: Use displayname if available, fallback to name + v => v.attributes?.displayname || v.basename, // 5: Finally, use basename if all previous sorting methods failed v => v.basename, ] |