Merge pull request #2496 from nextcloud/add-activities-for-favorite-managemet

Add an activity when managing favorites

9 files changed, 605 insertions, 23 deletions

diff --git a/apps/files/appinfo/info.xml b/apps/files/appinfo/info.xml
index 1992b94a03c..35e58b7202e 100644
--- a/apps/files/appinfo/info.xml
+++ b/apps/files/appinfo/info.xml
@@ -19,6 +19,7 @@
 
 	<activity>
 		<settings>
+			<setting>OCA\Files\Activity\Settings\FavoriteAction</setting>
 			<setting>OCA\Files\Activity\Settings\FileChanged</setting>
 			<setting>OCA\Files\Activity\Settings\FileCreated</setting>
 			<setting>OCA\Files\Activity\Settings\FileDeleted</setting>
@@ -32,6 +33,7 @@
 		</filters>
 
 		<providers>
+			<provider>OCA\Files\Activity\FavoriteProvider</provider>
 			<provider>OCA\Files\Activity\Provider</provider>
 		</providers>
 	</activity>
diff --git a/apps/files/lib/Activity/FavoriteProvider.php b/apps/files/lib/Activity/FavoriteProvider.php
new file mode 100644
index 00000000000..8047eb1319e
--- /dev/null
+++ b/apps/files/lib/Activity/FavoriteProvider.php
@@ -0,0 +1,151 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Files\Activity;
+
+use OCP\Activity\IEvent;
+use OCP\Activity\IEventMerger;
+use OCP\Activity\IManager;
+use OCP\Activity\IProvider;
+use OCP\IL10N;
+use OCP\IURLGenerator;
+use OCP\L10N\IFactory;
+
+class FavoriteProvider implements IProvider {
+
+	const SUBJECT_ADDED = 'added_favorite';
+	const SUBJECT_REMOVED = 'removed_favorite';
+
+	/** @var IFactory */
+	protected $languageFactory;
+
+	/** @var IL10N */
+	protected $l;
+
+	/** @var IURLGenerator */
+	protected $url;
+
+	/** @var IManager */
+	protected $activityManager;
+
+	/** @var IEventMerger */
+	protected $eventMerger;
+
+	/**
+	 * @param IFactory $languageFactory
+	 * @param IURLGenerator $url
+	 * @param IManager $activityManager
+	 * @param IEventMerger $eventMerger
+	 */
+	public function __construct(IFactory $languageFactory, IURLGenerator $url, IManager $activityManager, IEventMerger $eventMerger) {
+		$this->languageFactory = $languageFactory;
+		$this->url = $url;
+		$this->activityManager = $activityManager;
+		$this->eventMerger = $eventMerger;
+	}
+
+	/**
+	 * @param string $language
+	 * @param IEvent $event
+	 * @param IEvent|null $previousEvent
+	 * @return IEvent
+	 * @throws \InvalidArgumentException
+	 * @since 11.0.0
+	 */
+	public function parse($language, IEvent $event, IEvent $previousEvent = null) {
+		if ($event->getApp() !== 'files' || $event->getType() !== 'favorite') {
+			throw new \InvalidArgumentException();
+		}
+
+		$this->l = $this->languageFactory->get('files', $language);
+
+		if ($this->activityManager->isFormattingFilteredObject()) {
+			try {
+				return $this->parseShortVersion($event);
+			} catch (\InvalidArgumentException $e) {
+				// Ignore and simply use the long version...
+			}
+		}
+
+		return $this->parseLongVersion($event, $previousEvent);
+	}
+
+	/**
+	 * @param IEvent $event
+	 * @return IEvent
+	 * @throws \InvalidArgumentException
+	 * @since 11.0.0
+	 */
+	public function parseShortVersion(IEvent $event) {
+
+		if ($event->getSubject() === self::SUBJECT_ADDED) {
+			$event->setParsedSubject($this->l->t('Added to favorites'))
+				->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/starred.svg')));
+		} else if ($event->getSubject() === self::SUBJECT_REMOVED) {
+			$event->setParsedSubject($this->l->t('Removed from favorites'))
+				->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/star.svg')));
+		} else {
+			throw new \InvalidArgumentException();
+		}
+
+		return $event;
+	}
+
+	/**
+	 * @param IEvent $event
+	 * @param IEvent|null $previousEvent
+	 * @return IEvent
+	 * @throws \InvalidArgumentException
+	 * @since 11.0.0
+	 */
+	public function parseLongVersion(IEvent $event, IEvent $previousEvent = null) {
+
+		if ($event->getSubject() === self::SUBJECT_ADDED) {
+			$subject = $this->l->t('You added {file} to your favorites');
+			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/starred.svg')));
+		} else if ($event->getSubject() === self::SUBJECT_REMOVED) {
+			$subject = $this->l->t('You removed {file} from your favorites');
+			$event->setIcon($this->url->getAbsoluteURL($this->url->imagePath('core', 'actions/star.svg')));
+		} else {
+			throw new \InvalidArgumentException();
+		}
+
+		$this->setSubjects($event, $subject);
+		$event = $this->eventMerger->mergeEvents('file', $event, $previousEvent);
+		return $event;
+	}
+
+	/**
+	 * @param IEvent $event
+	 * @param string $subject
+	 */
+	protected function setSubjects(IEvent $event, $subject) {
+		$parameter = [
+			'type' => 'file',
+			'id' => $event->getObjectId(),
+			'name' => basename($event->getObjectName()),
+			'path' => $event->getObjectName(),
+		];
+
+		$event->setParsedSubject(str_replace('{file}', trim($parameter['path'], '/'), $subject))
+			->setRichSubject($subject, ['file' => $parameter]);
+	}
+}
diff --git a/apps/files/lib/Activity/Filter/FileChanges.php b/apps/files/lib/Activity/Filter/FileChanges.php
index dc7daf96bac..d8d1a698816 100644
--- a/apps/files/lib/Activity/Filter/FileChanges.php
+++ b/apps/files/lib/Activity/Filter/FileChanges.php
@@ -34,6 +34,10 @@ class FileChanges implements IFilter {
 	/** @var IURLGenerator */
 	protected $url;
 
+	/**
+	 * @param IL10N $l
+	 * @param IURLGenerator $url
+	 */
 	public function __construct(IL10N $l, IURLGenerator $url) {
 		$this->l = $l;
 		$this->url = $url;
diff --git a/apps/files/lib/Activity/Settings/FavoriteAction.php b/apps/files/lib/Activity/Settings/FavoriteAction.php
new file mode 100644
index 00000000000..509c0883e1e
--- /dev/null
+++ b/apps/files/lib/Activity/Settings/FavoriteAction.php
@@ -0,0 +1,98 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Files\Activity\Settings;
+
+
+use OCP\Activity\ISetting;
+use OCP\IL10N;
+
+class FavoriteAction implements ISetting {
+
+	/** @var IL10N */
+	protected $l;
+
+	/**
+	 * @param IL10N $l
+	 */
+	public function __construct(IL10N $l) {
+		$this->l = $l;
+	}
+
+	/**
+	 * @return string Lowercase a-z and underscore only identifier
+	 * @since 11.0.0
+	 */
+	public function getIdentifier() {
+		return 'favorite';
+	}
+
+	/**
+	 * @return string A translated string
+	 * @since 11.0.0
+	 */
+	public function getName() {
+		return $this->l->t('A file has been added to or removed from your <strong>favorites</strong>');
+	}
+
+	/**
+	 * @return int whether the filter should be rather on the top or bottom of
+	 * the admin section. The filters are arranged in ascending order of the
+	 * priority values. It is required to return a value between 0 and 100.
+	 * @since 11.0.0
+	 */
+	public function getPriority() {
+		return 5;
+	}
+
+	/**
+	 * @return bool True when the option can be changed for the stream
+	 * @since 11.0.0
+	 */
+	public function canChangeStream() {
+		return true;
+	}
+
+	/**
+	 * @return bool True when the option can be changed for the stream
+	 * @since 11.0.0
+	 */
+	public function isDefaultEnabledStream() {
+		return true;
+	}
+
+	/**
+	 * @return bool True when the option can be changed for the mail
+	 * @since 11.0.0
+	 */
+	public function canChangeMail() {
+		return true;
+	}
+
+	/**
+	 * @return bool True when the option can be changed for the stream
+	 * @since 11.0.0
+	 */
+	public function isDefaultEnabledMail() {
+		return false;
+	}
+}
+
diff --git a/apps/files/lib/AppInfo/Application.php b/apps/files/lib/AppInfo/Application.php
index fc91e05ba7e..4e5ec03eecf 100644
--- a/apps/files/lib/AppInfo/Application.php
+++ b/apps/files/lib/AppInfo/Application.php
@@ -84,6 +84,7 @@ class Application extends App {
 			$homeFolder = $c->query('ServerContainer')->getUserFolder();
 			return new TagService(
 				$c->query('ServerContainer')->getUserSession(),
+				$c->query('ServerContainer')->getActivityManager(),
 				$c->query('Tagger'),
 				$homeFolder
 			);
diff --git a/apps/files/lib/Service/TagService.php b/apps/files/lib/Service/TagService.php
index 4482fb45371..cf80d780eaf 100644
--- a/apps/files/lib/Service/TagService.php
+++ b/apps/files/lib/Service/TagService.php
@@ -25,35 +25,42 @@
 
 namespace OCA\Files\Service;
 
-use OC\Files\FileInfo;
-use OCP\Files\Node;
+use OC\Tags;
+use OCA\Files\Activity\FavoriteProvider;
+use OCP\Activity\IManager;
+use OCP\Files\Folder;
+use OCP\ITags;
+use OCP\IUser;
+use OCP\IUserSession;
 
 /**
  * Service class to manage tags on files.
  */
 class TagService {
 
-	/**
-	 * @var \OCP\IUserSession
-	 */
+	/** @var IUserSession */
 	private $userSession;
-
-	/**
-	 * @var \OCP\ITags
-	 */
+	/** @var IManager */
+	private $activityManager;
+	/** @var ITags */
 	private $tagger;
+	/** @var Folder */
+	private $homeFolder;
 
 	/**
-	 * @var \OCP\Files\Folder
+	 * @param IUserSession $userSession
+	 * @param IManager $activityManager
+	 * @param ITags $tagger
+	 * @param Folder $homeFolder
 	 */
-	private $homeFolder;
-
 	public function __construct(
-		\OCP\IUserSession $userSession,
-		\OCP\ITags $tagger,
-		\OCP\Files\Folder $homeFolder
+		IUserSession $userSession,
+		IManager $activityManager,
+		ITags $tagger,
+		Folder $homeFolder
 	) {
 		$this->userSession = $userSession;
+		$this->activityManager = $activityManager;
 		$this->tagger = $tagger;
 		$this->homeFolder = $homeFolder;
 	}
@@ -79,10 +86,16 @@ class TagService {
 
 		$newTags = array_diff($tags, $currentTags);
 		foreach ($newTags as $tag) {
+			if ($tag === Tags::TAG_FAVORITE) {
+				$this->addActivity(true, $fileId, $path);
+			}
 			$this->tagger->tagAs($fileId, $tag);
 		}
 		$deletedTags = array_diff($currentTags, $tags);
 		foreach ($deletedTags as $tag) {
+			if ($tag === Tags::TAG_FAVORITE) {
+				$this->addActivity(false, $fileId, $path);
+			}
 			$this->tagger->unTag($fileId, $tag);
 		}
 
@@ -90,5 +103,27 @@ class TagService {
 		// list is up to date, in case of concurrent changes ?
 		return $tags;
 	}
+
+	/**
+	 * @param bool $addToFavorite
+	 * @param int $fileId
+	 * @param string $path
+	 */
+	protected function addActivity($addToFavorite, $fileId, $path) {
+		$user = $this->userSession->getUser();
+		if (!$user instanceof IUser) {
+			return;
+		}
+
+		$event = $this->activityManager->generateEvent();
+		$event->setApp('files')
+			->setObject('files', $fileId, $path)
+			->setType('favorite')
+			->setAuthor($user->getUID())
+			->setAffectedUser($user->getUID())
+			->setTimestamp(time())
+			->setSubject($addToFavorite ? FavoriteProvider::SUBJECT_ADDED : FavoriteProvider::SUBJECT_REMOVED);
+		$this->activityManager->publish($event);
+	}
 }
 
diff --git a/apps/files/tests/Activity/Filter/GenericTest.php b/apps/files/tests/Activity/Filter/GenericTest.php
new file mode 100644
index 00000000000..3788126dd94
--- /dev/null
+++ b/apps/files/tests/Activity/Filter/GenericTest.php
@@ -0,0 +1,117 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Files\Tests\Activity\Filter;
+
+
+use OCA\Files\Activity\Filter\Favorites;
+use OCA\Files\Activity\Filter\FileChanges;
+use OCP\Activity\IFilter;
+use Test\TestCase;
+
+/**
+ * Class GenericTest
+ *
+ * @package OCA\Files\Tests\Activity\Filter
+ * @group DB
+ */
+class GenericTest extends TestCase {
+
+	public function dataFilters() {
+		return [
+			[Favorites::class],
+			[FileChanges::class],
+		];
+	}
+
+	/**
+	 * @dataProvider dataFilters
+	 * @param string $filterClass
+	 */
+	public function testImplementsInterface($filterClass) {
+		$filter = \OC::$server->query($filterClass);
+		$this->assertInstanceOf(IFilter::class, $filter);
+	}
+
+	/**
+	 * @dataProvider dataFilters
+	 * @param string $filterClass
+	 */
+	public function testGetIdentifier($filterClass) {
+		/** @var IFilter $filter */
+		$filter = \OC::$server->query($filterClass);
+		$this->assertInternalType('string', $filter->getIdentifier());
+	}
+
+	/**
+	 * @dataProvider dataFilters
+	 * @param string $filterClass
+	 */
+	public function testGetName($filterClass) {
+		/** @var IFilter $filter */
+		$filter = \OC::$server->query($filterClass);
+		$this->assertInternalType('string', $filter->getName());
+	}
+
+	/**
+	 * @dataProvider dataFilters
+	 * @param string $filterClass
+	 */
+	public function testGetPriority($filterClass) {
+		/** @var IFilter $filter */
+		$filter = \OC::$server->query($filterClass);
+		$priority = $filter->getPriority();
+		$this->assertInternalType('int', $filter->getPriority());
+		$this->assertGreaterThanOrEqual(0, $priority);
+		$this->assertLessThanOrEqual(100, $priority);
+	}
+
+	/**
+	 * @dataProvider dataFilters
+	 * @param string $filterClass
+	 */
+	public function testGetIcon($filterClass) {
+		/** @var IFilter $filter */
+		$filter = \OC::$server->query($filterClass);
+		$this->assertInternalType('string', $filter->getIcon());
+		$this->assertStringStartsWith('http', $filter->getIcon());
+	}
+
+	/**
+	 * @dataProvider dataFilters
+	 * @param string $filterClass
+	 */
+	public function testFilterTypes($filterClass) {
+		/** @var IFilter $filter */
+		$filter = \OC::$server->query($filterClass);
+		$this->assertInternalType('array', $filter->filterTypes([]));
+	}
+
+	/**
+	 * @dataProvider dataFilters
+	 * @param string $filterClass
+	 */
+	public function testAllowedApps($filterClass) {
+		/** @var IFilter $filter */
+		$filter = \OC::$server->query($filterClass);
+		$this->assertInternalType('array', $filter->allowedApps());
+	}
+}
diff --git a/apps/files/tests/Activity/Setting/GenericTest.php b/apps/files/tests/Activity/Setting/GenericTest.php
new file mode 100644
index 00000000000..5ae15f02a02
--- /dev/null
+++ b/apps/files/tests/Activity/Setting/GenericTest.php
@@ -0,0 +1,127 @@
+<?php
+/**
+ * @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace OCA\Files\Tests\Activity\Setting;
+
+use OCA\Files\Activity\Settings\FavoriteAction;
+use OCA\Files\Activity\Settings\FileChanged;
+use OCA\Files\Activity\Settings\FileCreated;
+use OCA\Files\Activity\Settings\FileDeleted;
+use OCA\Files\Activity\Settings\FileFavorite;
+use OCA\Files\Activity\Settings\FileRestored;
+use OCP\Activity\ISetting;
+use Test\TestCase;
+
+class GenericTest extends TestCase {
+
+	public function dataSettings() {
+		return [
+			[FavoriteAction::class],
+			[FileChanged::class],
+			[FileCreated::class],
+			[FileDeleted::class],
+			[FileFavorite::class],
+			[FileRestored::class],
+		];
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testImplementsInterface($settingClass) {
+		$setting = \OC::$server->query($settingClass);
+		$this->assertInstanceOf(ISetting::class, $setting);
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testGetIdentifier($settingClass) {
+		/** @var ISetting $setting */
+		$setting = \OC::$server->query($settingClass);
+		$this->assertInternalType('string', $setting->getIdentifier());
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testGetName($settingClass) {
+		/** @var ISetting $setting */
+		$setting = \OC::$server->query($settingClass);
+		$this->assertInternalType('string', $setting->getName());
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testGetPriority($settingClass) {
+		/** @var ISetting $setting */
+		$setting = \OC::$server->query($settingClass);
+		$priority = $setting->getPriority();
+		$this->assertInternalType('int', $setting->getPriority());
+		$this->assertGreaterThanOrEqual(0, $priority);
+		$this->assertLessThanOrEqual(100, $priority);
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testCanChangeStream($settingClass) {
+		/** @var ISetting $setting */
+		$setting = \OC::$server->query($settingClass);
+		$this->assertInternalType('bool', $setting->canChangeStream());
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testIsDefaultEnabledStream($settingClass) {
+		/** @var ISetting $setting */
+		$setting = \OC::$server->query($settingClass);
+		$this->assertInternalType('bool', $setting->isDefaultEnabledStream());
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testCanChangeMail($settingClass) {
+		/** @var ISetting $setting */
+		$setting = \OC::$server->query($settingClass);
+		$this->assertInternalType('bool', $setting->canChangeMail());
+	}
+
+	/**
+	 * @dataProvider dataSettings
+	 * @param string $settingClass
+	 */
+	public function testIsDefaultEnabledMail($settingClass) {
+		/** @var ISetting $setting */
+		$setting = \OC::$server->query($settingClass);
+		$this->assertInternalType('bool', $setting->isDefaultEnabledMail());
+	}
+}
diff --git a/apps/files/tests/Service/TagServiceTest.php b/apps/files/tests/Service/TagServiceTest.php
index b8d36487585..1c4ac2328ec 100644
--- a/apps/files/tests/Service/TagServiceTest.php
+++ b/apps/files/tests/Service/TagServiceTest.php
@@ -24,7 +24,9 @@
  */
 namespace OCA\Files\Tests\Service;
 
+use OC\Tags;
 use OCA\Files\Service\TagService;
+use OCP\Activity\IManager;
 use OCP\IUserSession;
 
 /**
@@ -41,13 +43,19 @@ class TagServiceTest extends \Test\TestCase {
 	 */
 	private $user;
 
+	/** @var IUserSession|\PHPUnit_Framework_MockObject_MockObject */
+	private $userSession;
+
+	/** @var IManager|\PHPUnit_Framework_MockObject_MockObject */
+	private $activityManager;
+
 	/**
 	 * @var \OCP\Files\Folder
 	 */
 	private $root;
 
 	/**
-	 * @var \OCA\Files\Service\TagService
+	 * @var \OCA\Files\Service\TagService|\PHPUnit_Framework_MockObject_MockObject
 	 */
 	private $tagService;
 
@@ -59,6 +67,7 @@ class TagServiceTest extends \Test\TestCase {
 	protected function setUp() {
 		parent::setUp();
 		$this->user = $this->getUniqueID('user');
+		$this->activityManager = $this->createMock(IManager::class);
 		\OC::$server->getUserManager()->createUser($this->user, 'test');
 		\OC_User::setUserId($this->user);
 		\OC_Util::setupFS($this->user);
@@ -67,8 +76,8 @@ class TagServiceTest extends \Test\TestCase {
 		/**
 		 * @var \OCP\IUserSession
 		 */
-		$userSession = $this->createMock(IUserSession::class);
-		$userSession->expects($this->any())
+		$this->userSession = $this->createMock(IUserSession::class);
+		$this->userSession->expects($this->any())
 			->method('getUser')
 			->withAnyParameters()
 			->will($this->returnValue($user));
@@ -76,11 +85,24 @@ class TagServiceTest extends \Test\TestCase {
 		$this->root = \OC::$server->getUserFolder();
 
 		$this->tagger = \OC::$server->getTagManager()->load('files');
-		$this->tagService = new TagService(
-			$userSession,
-			$this->tagger,
-			$this->root
-		);
+		$this->tagService = $this->getTagService(['addActivity']);
+	}
+
+	/**
+	 * @param array $methods
+	 * @return TagService|\PHPUnit_Framework_MockObject_MockObject
+	 */
+	protected function getTagService(array $methods = []) {
+		return $this->getMockBuilder(TagService::class)
+			->setConstructorArgs([
+				$this->userSession,
+				$this->activityManager,
+				$this->tagger,
+				$this->root,
+			])
+			->setMethods($methods)
+			->getMock();
+
 	}
 
 	protected function tearDown() {
@@ -93,6 +115,9 @@ class TagServiceTest extends \Test\TestCase {
 		$tag1 = 'tag1';
 		$tag2 = 'tag2';
 
+		$this->tagService->expects($this->never())
+			->method('addActivity');
+
 		$subdir = $this->root->newFolder('subdir');
 		$testFile = $subdir->newFile('test.txt');
 		$testFile->putContent('test contents');
@@ -126,5 +151,27 @@ class TagServiceTest extends \Test\TestCase {
 
 		$subdir->delete();
 	}
+
+	public function testFavoriteActivity() {
+
+		$subdir = $this->root->newFolder('subdir');
+		$file = $subdir->newFile('test.txt');
+
+		$this->tagService->expects($this->exactly(2))
+			->method('addActivity')
+			->withConsecutive(
+				[true, $file->getId(), 'subdir/test.txt'],
+				[false, $file->getId(), 'subdir/test.txt']
+			);
+
+		// set tags
+		$this->tagService->updateFileTags('subdir/test.txt', [Tags::TAG_FAVORITE]);
+
+		// remove tag
+		$this->tagService->updateFileTags('subdir/test.txt', []);
+
+
+		$subdir->delete();
+	}
 }