diff options
| author | Joas Schilling <nickvergessen@owncloud.com> | 2015-11-13 10:32:45 +0100 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@owncloud.com> | 2015-11-13 11:35:30 +0100 |
| commit | e0a97551131636d7a3aa9bee1ea4aaa168a0a1c5 (patch) | |
| tree | ae66d93cce6caa6c709c068520edab3c616896b9 /apps/files | |
| parent | 2e0665acb0388fa86d67ae23ce659e7acc550fb7 (diff) | |
| download | nextcloud-server-e0a97551131636d7a3aa9bee1ea4aaa168a0a1c5.tar.gz nextcloud-server-e0a97551131636d7a3aa9bee1ea4aaa168a0a1c5.zip | |
Oracle can not return statements but only values
So evaluate the condition directly and return 1 or 0
Diffstat (limited to 'apps/files')
| -rw-r--r-- | apps/files/lib/activity.php | 9 | ||||
| -rw-r--r-- | apps/files/tests/activitytest.php | 8 |
2 files changed, 10 insertions, 7 deletions
diff --git a/apps/files/lib/activity.php b/apps/files/lib/activity.php index 3ed437c045a..6cf2786239a 100644 --- a/apps/files/lib/activity.php +++ b/apps/files/lib/activity.php @@ -333,6 +333,7 @@ class Activity implements IExtension { */ $parameters = $fileQueryList = []; $parameters[] = 'files'; + $parameters[] = 'files'; $fileQueryList[] = '(`type` <> ? AND `type` <> ?)'; $parameters[] = self::TYPE_SHARE_CREATED; @@ -347,10 +348,12 @@ class Activity implements IExtension { $parameters[] = $favorite . '/%'; } - $parameters[] = 'files'; - return [ - ' CASE WHEN `app` = ? THEN (' . implode(' OR ', $fileQueryList) . ') ELSE `app` <> ? END ', + ' CASE ' + . 'WHEN `app` <> ? THEN 1 ' + . 'WHEN `app` = ? AND (' . implode(' OR ', $fileQueryList) . ') THEN 1 ' + . 'ELSE 0 ' + . 'END = 1 ', $parameters, ]; } diff --git a/apps/files/tests/activitytest.php b/apps/files/tests/activitytest.php index cdb1d21bcd8..485c559d488 100644 --- a/apps/files/tests/activitytest.php +++ b/apps/files/tests/activitytest.php @@ -290,16 +290,16 @@ class ActivityTest extends TestCase { 'items' => [], 'folders' => [], ], - ' CASE WHEN `app` = ? THEN ((`type` <> ? AND `type` <> ?)) ELSE `app` <> ? END ', - ['files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED, 'files'] + ' CASE WHEN `app` <> ? THEN 1 WHEN `app` = ? AND ((`type` <> ? AND `type` <> ?)) THEN 1 ELSE 0 END = 1 ', + ['files', 'files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED] ], [ [ 'items' => ['file.txt', 'folder'], 'folders' => ['folder'], ], - ' CASE WHEN `app` = ? THEN ((`type` <> ? AND `type` <> ?) OR `file` = ? OR `file` = ? OR `file` LIKE ?) ELSE `app` <> ? END ', - ['files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED, 'file.txt', 'folder', 'folder/%', 'files'] + ' CASE WHEN `app` <> ? THEN 1 WHEN `app` = ? AND ((`type` <> ? AND `type` <> ?) OR `file` = ? OR `file` = ? OR `file` LIKE ?) THEN 1 ELSE 0 END = 1 ', + ['files', 'files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED, 'file.txt', 'folder', 'folder/%'] ], ]; } |