diff options
| author | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2017-12-27 16:31:22 +0100 |
|---|---|---|
| committer | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2017-12-27 16:31:22 +0100 |
| commit | 11125164bee4a2130f5adc4808b3f92c892a6138 (patch) | |
| tree | 7ac8ad6cc703633de27cc14535465a0a4188868f /apps/files_external/js | |
| parent | 78891ac320c1b5613d71464a3211cd87ec393e63 (diff) | |
| download | nextcloud-server-11125164bee4a2130f5adc4808b3f92c892a6138.tar.gz nextcloud-server-11125164bee4a2130f5adc4808b3f92c892a6138.zip | |
Disable selection in "External storages" file list
When the checkbox was moved to where the favourite icon was shown before
the layout of the file list was modified. The checkbox is no longer a
descendant of the ".filename" element, so it is no longer removed by the
"External storages" file list.
However, even before the checkbox was moved, explicitly removing it was
not the best approach, as file list rows could still be selected using
"Ctrl/Shift+click". This did not provide much value, as the selection
header has no actions; it simply states the number of selected elements.
The proper way to disable the selection is by setting "_allowSelection"
to false in the file list instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Diffstat (limited to 'apps/files_external/js')
| -rw-r--r-- | apps/files_external/js/mountsfilelist.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/apps/files_external/js/mountsfilelist.js b/apps/files_external/js/mountsfilelist.js index 3beee6f73b2..90b90e38745 100644 --- a/apps/files_external/js/mountsfilelist.js +++ b/apps/files_external/js/mountsfilelist.js @@ -30,6 +30,8 @@ /** @lends OCA.External.FileList.prototype */ { appName: 'External storages', + _allowSelection: false, + /** * @private */ @@ -56,7 +58,6 @@ $scopeColumn.find('span').text(scopeText); $backendColumn.text(fileData.backend); $tr.find('td.filename').after($scopeColumn).after($backendColumn); - $tr.find('td.filename input:checkbox').remove(); return $tr; }, |