Fixes #8326: deletion of directories on S3

1 files changed, 12 insertions, 17 deletions

diff --git a/apps/files_external/lib/amazons3.php b/apps/files_external/lib/amazons3.php
index 10fc626c5da..909d3f6b8ef 100644
--- a/apps/files_external/lib/amazons3.php
+++ b/apps/files_external/lib/amazons3.php
@@ -190,26 +190,17 @@ class AmazonS3 extends \OC\Files\Storage\Common {
 			return false;
 		}
 
-		$dh = $this->opendir($path);
-
-		if(is_resource($dh)) {
-			while (($file = readdir($dh)) !== false) {
-				if ($file === '.' || $file === '..') {
-					continue;
-				}
-
-				if ($this->is_dir($path . '/' . $file)) {
-					$this->rmdir($path . '/' . $file);
-				} else {
-					$this->unlink($path . '/' . $file);
-				}
-			}
-		}
+		// Since there are no real directories on S3, we need
+		// to delete all objects prefixed with the path.
+		$objects = $this->connection->listObjects([
+			'Bucket' => $this->bucket,
+			'Prefix' => $path . '/'
+		]);
 
 		try {
-			$result = $this->connection->deleteObject(array(
+			$result = $this->connection->deleteObjects(array(
 				'Bucket' => $this->bucket,
-				'Key' => $path . '/'
+				'Objects' => $objects['Contents']
 			));
 			$this->testTimeout();
 		} catch (S3Exception $e) {
@@ -310,6 +301,10 @@ class AmazonS3 extends \OC\Files\Storage\Common {
 	public function unlink($path) {
 		$path = $this->normalizePath($path);
 
+		if ( $this->is_dir($path) ) {
+			return $this->rmdir($path);
+		}
+
 		try {
 			$result = $this->connection->deleteObject(array(
 				'Bucket' => $this->bucket,