fix checkstyle for files_external app, add whitespace for readability

1 files changed, 76 insertions, 32 deletions

diff --git a/apps/files_external/templates/settings.php b/apps/files_external/templates/settings.php
index 367ce2bc03e..5b954eeb50a 100644
--- a/apps/files_external/templates/settings.php
+++ b/apps/files_external/templates/settings.php
@@ -16,18 +16,22 @@
 			<?php $_['mounts'] = array_merge($_['mounts'], array('' => array())); ?>
 			<?php foreach ($_['mounts'] as $mountPoint => $mount): ?>
 				<tr <?php echo ($mountPoint != '') ? 'class="'.$mount['class'].'"' : 'id="addMountPoint"'; ?>>
-					<td class="mountPoint"><input type="text" name="mountPoint" value="<?php echo $mountPoint; ?>" placeholder="<?php echo $l->t('Mount point'); ?>" /></td>
+					<td class="mountPoint"><input type="text" name="mountPoint"
+												  value="<?php echo $mountPoint; ?>"
+												  placeholder="<?php echo $l->t('Mount point'); ?>" /></td>
 					<?php if ($mountPoint == ''): ?>
 						<td class="backend">
 							<select id="selectBackend" data-configurations='<?php echo json_encode($_['backends']); ?>'>
-								<option value="" disabled selected style="display:none;"><?php echo $l->t('Add mount point'); ?></option>
+								<option value="" disabled selected
+										style="display:none;"><?php echo $l->t('Add mount point'); ?></option>
 								<?php foreach ($_['backends'] as $class => $backend): ?>
 									<option value="<?php echo $class; ?>"><?php echo $backend['backend']; ?></option>
 								<?php endforeach; ?>
 							</select>
 						</td>
 					<?php else: ?>
-						<td class="backend" data-class="<?php echo $mount['class']; ?>"><?php echo $mount['backend']; ?></td>
+						<td class="backend"
+							data-class="<?php echo $mount['class']; ?>"><?php echo $mount['backend']; ?></td>
 					<?php endif; ?>
 					<td class ="configuration" width="100%">
 						<?php if (isset($mount['configuration'])): ?>
@@ -35,46 +39,75 @@
 								<?php if (isset($_['backends'][$mount['class']]['configuration'][$parameter])): ?>
 									<?php $placeholder = $_['backends'][$mount['class']]['configuration'][$parameter]; ?>
 									<?php if (strpos($placeholder, '*') !== false): ?>
-										<input type="password" data-parameter="<?php echo $parameter; ?>" value="<?php echo $value; ?>" placeholder="<?php echo substr($placeholder, 1); ?>" />
-									<?php elseif(strpos($placeholder, '!') !== false): ?>
-										<label><input type="checkbox" data-parameter="<?php echo $parameter; ?>" <?php if ($value == 'true') echo ' checked="checked"'; ?>  /><?php echo substr($placeholder, 1); ?></label>
+										<input type="password"
+											   data-parameter="<?php echo $parameter; ?>"
+											   value="<?php echo $value; ?>"
+											   placeholder="<?php echo substr($placeholder, 1); ?>" />
+									<?php elseif (strpos($placeholder, '!') !== false): ?>
+										<label><input type="checkbox"
+													  data-parameter="<?php echo $parameter; ?>"
+													  <?php if ($value == 'true'): ?> checked="checked"<?php endif; ?> 
+													  /><?php echo substr($placeholder, 1); ?></label>
 									<?php elseif (strpos($placeholder, '&') !== false): ?>
-										<input type="text" class="optional" data-parameter="<?php echo $parameter; ?>" value="<?php echo $value; ?>" placeholder="<?php echo substr($placeholder, 5); ?>" />
+										<input type="text"
+											   class="optional"
+											   data-parameter="<?php echo $parameter; ?>"
+											   value="<?php echo $value; ?>"
+											   placeholder="<?php echo substr($placeholder, 5); ?>" />
 									<?php elseif (strpos($placeholder, '#') !== false): ?>
-										<input type="hidden" data-parameter="<?php echo $parameter; ?>" value="<?php echo $value; ?>" />
+										<input type="hidden"
+											   data-parameter="<?php echo $parameter; ?>"
+											   value="<?php echo $value; ?>" />
 									<?php else: ?>
-										<input type="text" data-parameter="<?php echo $parameter; ?>" value="<?php echo $value; ?>" placeholder="<?php echo $placeholder; ?>" />
+										<input type="text"
+											   data-parameter="<?php echo $parameter; ?>"
+											   value="<?php echo $value; ?>"
+											   placeholder="<?php echo $placeholder; ?>" />
 									<?php endif; ?>
 								<?php endif; ?>
 							<?php endforeach; ?>
-							<?php if (isset($_['backends'][$mount['class']]['custom'])) OCP\Util::addScript('files_external', $_['backends'][$mount['class']]['custom']); ?>
+							<?php if (isset($_['backends'][$mount['class']]['custom'])): ?>
+								<?php OCP\Util::addScript('files_external',
+														  $_['backends'][$mount['class']]['custom']); ?>
+							<?php endif; ?>
 						<?php endif; ?>
 					</td>
-					<!--<td class="options">
-						<select class="selectOptions" title="<?php echo $l->t('None set')?>" multiple="multiple" disabled>
-							<?php if (OCP\App::isEnabled('files_encryption')) echo '<option value="Encrypt">Encrypt</option>'; ?>
-							<?php if (OCP\App::isEnabled('files_versions')) echo '<option value="Version control">Version control</option>'; ?>
-							<?php if (OCP\App::isEnabled('files_sharing')) echo '<option value="Allow sharing">Allow sharing</option>'; ?>
-						</select>
-					</td>-->
 					<?php if ($_['isAdminPage']): ?>
-					<td class="applicable" align="right" data-applicable-groups='<?php if (isset($mount['applicable']['groups'])) echo json_encode($mount['applicable']['groups']); ?>' data-applicable-users='<?php if (isset($mount['applicable']['users'])) echo json_encode($mount['applicable']['users']); ?>'>
-							<select class="chzn-select" multiple style="width:20em;" data-placeholder="<?php echo $l->t('None set'); ?>">
+					<td class="applicable"
+						align="right"
+						data-applicable-groups='<?php if (isset($mount['applicable']['groups']))
+														echo json_encode($mount['applicable']['groups']); ?>'
+						data-applicable-users='<?php if (isset($mount['applicable']['users']))
+														echo json_encode($mount['applicable']['users']); ?>'>
+							<select class="chzn-select"
+									multiple style="width:20em;"
+									data-placeholder="<?php echo $l->t('None set'); ?>">
 								<option value="all"><?php echo $l->t('All Users'); ?></option>
 								<optgroup label="<?php echo $l->t('Groups'); ?>">
-									<?php foreach ($_['groups'] as $group): ?>
-										<option value="<?php echo $group; ?>(group)" <?php if (isset($mount['applicable']['groups']) && in_array($group, $mount['applicable']['groups'])) echo 'selected="selected"'; ?>><?php echo $group; ?></option>
-									<?php endforeach; ?>
+								<?php foreach ($_['groups'] as $group): ?>
+									<option value="<?php echo $group; ?>(group)"
+									<?php if (isset($mount['applicable']['groups']) && in_array($group, $mount['applicable']['groups'])): ?>
+											selected="selected"
+									<?php endif; ?>><?php echo $group; ?></option>
+								<?php endforeach; ?>
 								</optgroup>
 								<optgroup label="<?php echo $l->t('Users'); ?>">
-									<?php foreach ($_['users'] as $user): ?>
-										<option value="<?php echo $user; ?>" <?php if (isset($mount['applicable']['users']) && in_array($user, $mount['applicable']['users'])) echo 'selected="selected"'; ?>"><?php echo $user; ?></option>
-									<?php endforeach; ?>
+								<?php foreach ($_['users'] as $user): ?>
+									<option value="<?php echo $user; ?>"
+									<?php if (isset($mount['applicable']['users']) && in_array($user, $mount['applicable']['users'])): ?>
+											selected="selected"
+									<?php endif; ?>><?php echo $user; ?></option>
+								<?php endforeach; ?>
 								</optgroup>
 							</select>
 						</td>
 					<?php endif; ?>
-					<td <?php echo ($mountPoint != '') ? 'class="remove"' : 'style="visibility:hidden;"'; ?>><img alt="<?php echo $l->t('Delete'); ?>" title="<?php echo $l->t('Delete'); ?>" class="svg action" src="<?php echo image_path('core', 'actions/delete.svg'); ?>" /></td>
+					<td <?php if ($mountPoint != ''): ?>class="remove"
+						<?php else: ?>style="visibility:hidden;"
+						<?php endif ?>><img alt="<?php echo $l->t('Delete'); ?>" 
+											title="<?php echo $l->t('Delete'); ?>"
+											class="svg action"
+											src="<?php echo image_path('core', 'actions/delete.svg'); ?>" /></td>
 				</tr>
 			<?php endforeach; ?>
 			</tbody>
@@ -83,16 +116,22 @@
 
 		<?php if ($_['isAdminPage']): ?>
 			<br />
-			<input type="checkbox" name="allowUserMounting" id="allowUserMounting" value="1" <?php if ($_['allowUserMounting'] == 'yes') echo ' checked="checked"'; ?> />
+			<input type="checkbox"
+				   name="allowUserMounting"
+				   id="allowUserMounting"
+				   value="1" <?php if ($_['allowUserMounting'] == 'yes') echo ' checked="checked"'; ?> />
 			<label for="allowUserMounting"><?php echo $l->t('Enable User External Storage'); ?></label><br/>
 			<em><?php echo $l->t('Allow users to mount their own external storage'); ?></em>
 		<?php endif; ?>
 	</fieldset>
 </form>
 
-<form id="files_external" method="post" enctype="multipart/form-data" action="<?php echo OCP\Util::linkTo('files_external', 'ajax/addRootCertificate.php'); ?>">
+<form id="files_external"
+	  method="post"
+	  enctype="multipart/form-data"
+	  action="<?php echo OCP\Util::linkTo('files_external', 'ajax/addRootCertificate.php'); ?>">
 <fieldset class="personalblock">
-<?php if (!$_['isAdminPage']):  ?>
+<?php if ( ! $_['isAdminPage']):  ?>
 		<table id="sslCertificate" data-admin='<?php echo json_encode($_['isAdminPage']); ?>'>
 			<thead>
 				<tr>
@@ -104,13 +143,18 @@
 			<?php foreach ($_['certs'] as $rootCert): ?>
 			<tr id="<?php echo $rootCert ?>">
 			<td class="rootCert"><?php echo $rootCert ?></td>
-			<td <?php echo ($rootCert != '') ? 'class="remove"' : 'style="visibility:hidden;"'; ?>><img alt="<?php echo $l->t('Delete'); ?>" title="<?php echo $l->t('Delete'); ?>" class="svg action" src="<?php echo image_path('core', 'actions/delete.svg'); ?>" /></td>
+			<td <?php if ($rootCert != ''): ?>class="remove"
+				<?php else: ?>style="visibility:hidden;"
+				<?php endif; ?>><img alt="<?php echo $l->t('Delete'); ?>"
+									 title="<?php echo $l->t('Delete'); ?>"
+									 class="svg action"
+									 src="<?php echo image_path('core', 'actions/delete.svg'); ?>" /></td>
 			</tr>
 			<?php endforeach; ?>
 			</tbody>
 		</table>
-        <input type="file" id="rootcert_import" name="rootcert_import" style="width:230px;">
-        <input type="submit" name="cert_import" value="<?php echo $l->t('Import Root Certificate'); ?>" />
+		<input type="file" id="rootcert_import" name="rootcert_import" style="width:230px;">
+		<input type="submit" name="cert_import" value="<?php echo $l->t('Import Root Certificate'); ?>" />
 		<?php endif; ?>
 </fieldset>
 </form>
\ No newline at end of file