diff options
author | Roeland Jago Douma <rullzer@users.noreply.github.com> | 2020-04-17 13:45:25 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-04-17 13:45:25 +0200 |
commit | cd782737cbf55ab640105f62aeb4a0568dfcf0c8 (patch) | |
tree | 53ee2fb1cc31f3f9c7f66f6bc6fe93508f18f081 /apps/files_external | |
parent | 0856745a47da96ff4839f7391e6a1c573f560014 (diff) | |
parent | c9696edb74641e70fc97acce95c00e6cee95448a (diff) | |
download | nextcloud-server-cd782737cbf55ab640105f62aeb4a0568dfcf0c8.tar.gz nextcloud-server-cd782737cbf55ab640105f62aeb4a0568dfcf0c8.zip |
Merge pull request #20405 from nextcloud/backport/20363/stable18
[stable18] update icewind/smb to 3.2.3
Diffstat (limited to 'apps/files_external')
25 files changed, 373 insertions, 106 deletions
diff --git a/apps/files_external/3rdparty/composer.json b/apps/files_external/3rdparty/composer.json index 6c23067c4a5..483e92eb427 100644 --- a/apps/files_external/3rdparty/composer.json +++ b/apps/files_external/3rdparty/composer.json @@ -9,6 +9,6 @@ }, "require": { "icewind/streams": "0.7.1", - "icewind/smb": "3.1.1" + "icewind/smb": "^3.2.3" } } diff --git a/apps/files_external/3rdparty/composer.lock b/apps/files_external/3rdparty/composer.lock index 491b73fa1f4..83a165cc1dd 100644 --- a/apps/files_external/3rdparty/composer.lock +++ b/apps/files_external/3rdparty/composer.lock @@ -4,29 +4,29 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "5639a09feff2318b1b69e11a10a81e7d", + "content-hash": "ceb6bef26683b2d8f92ee654bd63853c", "packages": [ { "name": "icewind/smb", - "version": "v3.1.1", + "version": "v3.2.3", "source": { "type": "git", "url": "https://github.com/icewind1991/SMB.git", - "reference": "26b7b8780342d0e61313b464b880d50a2ea898e2" + "reference": "db50bb51bd0a0e55506e82cf439a9ecd232f64d4" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/icewind1991/SMB/zipball/26b7b8780342d0e61313b464b880d50a2ea898e2", - "reference": "26b7b8780342d0e61313b464b880d50a2ea898e2", + "url": "https://api.github.com/repos/icewind1991/SMB/zipball/db50bb51bd0a0e55506e82cf439a9ecd232f64d4", + "reference": "db50bb51bd0a0e55506e82cf439a9ecd232f64d4", "shasum": "" }, "require": { "icewind/streams": ">=0.2.0", - "php": ">=5.6" + "php": ">=7.1" }, "require-dev": { "friendsofphp/php-cs-fixer": "^2.13", - "phpunit/phpunit": "^5.7" + "phpunit/phpunit": "^7.0" }, "type": "library", "autoload": { @@ -46,7 +46,7 @@ } ], "description": "php wrapper for smbclient and libsmbclient-php", - "time": "2019-03-04T15:02:42+00:00" + "time": "2020-04-08T15:20:22+00:00" }, { "name": "icewind/streams", @@ -97,5 +97,6 @@ "prefer-stable": false, "prefer-lowest": false, "platform": [], - "platform-dev": [] + "platform-dev": [], + "plugin-api-version": "1.1.0" } diff --git a/apps/files_external/3rdparty/composer/autoload_classmap.php b/apps/files_external/3rdparty/composer/autoload_classmap.php index 9eb83e893bd..5e812cf4fdb 100644 --- a/apps/files_external/3rdparty/composer/autoload_classmap.php +++ b/apps/files_external/3rdparty/composer/autoload_classmap.php @@ -6,6 +6,7 @@ $vendorDir = dirname(dirname(__FILE__)); $baseDir = $vendorDir; return array( + 'Icewind\\SMB\\ACL' => $vendorDir . '/icewind/smb/src/ACL.php', 'Icewind\\SMB\\AbstractServer' => $vendorDir . '/icewind/smb/src/AbstractServer.php', 'Icewind\\SMB\\AbstractShare' => $vendorDir . '/icewind/smb/src/AbstractShare.php', 'Icewind\\SMB\\AnonymousAuth' => $vendorDir . '/icewind/smb/src/AnonymousAuth.php', @@ -15,8 +16,10 @@ return array( 'Icewind\\SMB\\Exception\\AlreadyExistsException' => $vendorDir . '/icewind/smb/src/Exception/AlreadyExistsException.php', 'Icewind\\SMB\\Exception\\AuthenticationException' => $vendorDir . '/icewind/smb/src/Exception/AuthenticationException.php', 'Icewind\\SMB\\Exception\\ConnectException' => $vendorDir . '/icewind/smb/src/Exception/ConnectException.php', + 'Icewind\\SMB\\Exception\\ConnectionAbortedException' => $vendorDir . '/icewind/smb/src/Exception/ConnectionAbortedException.php', 'Icewind\\SMB\\Exception\\ConnectionException' => $vendorDir . '/icewind/smb/src/Exception/ConnectionException.php', 'Icewind\\SMB\\Exception\\ConnectionRefusedException' => $vendorDir . '/icewind/smb/src/Exception/ConnectionRefusedException.php', + 'Icewind\\SMB\\Exception\\ConnectionResetException' => $vendorDir . '/icewind/smb/src/Exception/ConnectionResetException.php', 'Icewind\\SMB\\Exception\\DependencyException' => $vendorDir . '/icewind/smb/src/Exception/DependencyException.php', 'Icewind\\SMB\\Exception\\Exception' => $vendorDir . '/icewind/smb/src/Exception/Exception.php', 'Icewind\\SMB\\Exception\\FileInUseException' => $vendorDir . '/icewind/smb/src/Exception/FileInUseException.php', @@ -55,6 +58,16 @@ return array( 'Icewind\\SMB\\Options' => $vendorDir . '/icewind/smb/src/Options.php', 'Icewind\\SMB\\ServerFactory' => $vendorDir . '/icewind/smb/src/ServerFactory.php', 'Icewind\\SMB\\System' => $vendorDir . '/icewind/smb/src/System.php', + 'Icewind\\SMB\\Test\\AbstractShareTest' => $vendorDir . '/icewind/smb/tests/AbstractShareTest.php', + 'Icewind\\SMB\\Test\\NativeShareTest' => $vendorDir . '/icewind/smb/tests/NativeShareTest.php', + 'Icewind\\SMB\\Test\\NativeStreamTest' => $vendorDir . '/icewind/smb/tests/NativeStreamTest.php', + 'Icewind\\SMB\\Test\\NotifyHandlerTest' => $vendorDir . '/icewind/smb/tests/NotifyHandlerTest.php', + 'Icewind\\SMB\\Test\\ParserTest' => $vendorDir . '/icewind/smb/tests/ParserTest.php', + 'Icewind\\SMB\\Test\\ServerFactoryTest' => $vendorDir . '/icewind/smb/tests/ServerFactoryTest.php', + 'Icewind\\SMB\\Test\\ServerTest' => $vendorDir . '/icewind/smb/tests/ServerTest.php', + 'Icewind\\SMB\\Test\\ShareTest' => $vendorDir . '/icewind/smb/tests/ShareTest.php', + 'Icewind\\SMB\\Test\\TestCase' => $vendorDir . '/icewind/smb/tests/TestCase.php', + 'Icewind\\SMB\\Test\\TimeZoneProviderTest' => $vendorDir . '/icewind/smb/tests/TimeZoneProviderTest.php', 'Icewind\\SMB\\TimeZoneProvider' => $vendorDir . '/icewind/smb/src/TimeZoneProvider.php', 'Icewind\\SMB\\Wrapped\\Connection' => $vendorDir . '/icewind/smb/src/Wrapped/Connection.php', 'Icewind\\SMB\\Wrapped\\ErrorCodes' => $vendorDir . '/icewind/smb/src/Wrapped/ErrorCodes.php', diff --git a/apps/files_external/3rdparty/composer/autoload_real.php b/apps/files_external/3rdparty/composer/autoload_real.php index 4ac68127fea..36857d406cd 100644 --- a/apps/files_external/3rdparty/composer/autoload_real.php +++ b/apps/files_external/3rdparty/composer/autoload_real.php @@ -13,6 +13,9 @@ class ComposerAutoloaderInit98fe9b281934250b3a93f69a5ce843b3 } } + /** + * @return \Composer\Autoload\ClassLoader + */ public static function getLoader() { if (null !== self::$loader) { diff --git a/apps/files_external/3rdparty/composer/autoload_static.php b/apps/files_external/3rdparty/composer/autoload_static.php index eb2329b2b05..0bef5d984e2 100644 --- a/apps/files_external/3rdparty/composer/autoload_static.php +++ b/apps/files_external/3rdparty/composer/autoload_static.php @@ -36,6 +36,7 @@ class ComposerStaticInit98fe9b281934250b3a93f69a5ce843b3 ); public static $classMap = array ( + 'Icewind\\SMB\\ACL' => __DIR__ . '/..' . '/icewind/smb/src/ACL.php', 'Icewind\\SMB\\AbstractServer' => __DIR__ . '/..' . '/icewind/smb/src/AbstractServer.php', 'Icewind\\SMB\\AbstractShare' => __DIR__ . '/..' . '/icewind/smb/src/AbstractShare.php', 'Icewind\\SMB\\AnonymousAuth' => __DIR__ . '/..' . '/icewind/smb/src/AnonymousAuth.php', @@ -45,8 +46,10 @@ class ComposerStaticInit98fe9b281934250b3a93f69a5ce843b3 'Icewind\\SMB\\Exception\\AlreadyExistsException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/AlreadyExistsException.php', 'Icewind\\SMB\\Exception\\AuthenticationException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/AuthenticationException.php', 'Icewind\\SMB\\Exception\\ConnectException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/ConnectException.php', + 'Icewind\\SMB\\Exception\\ConnectionAbortedException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/ConnectionAbortedException.php', 'Icewind\\SMB\\Exception\\ConnectionException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/ConnectionException.php', 'Icewind\\SMB\\Exception\\ConnectionRefusedException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/ConnectionRefusedException.php', + 'Icewind\\SMB\\Exception\\ConnectionResetException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/ConnectionResetException.php', 'Icewind\\SMB\\Exception\\DependencyException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/DependencyException.php', 'Icewind\\SMB\\Exception\\Exception' => __DIR__ . '/..' . '/icewind/smb/src/Exception/Exception.php', 'Icewind\\SMB\\Exception\\FileInUseException' => __DIR__ . '/..' . '/icewind/smb/src/Exception/FileInUseException.php', @@ -85,6 +88,16 @@ class ComposerStaticInit98fe9b281934250b3a93f69a5ce843b3 'Icewind\\SMB\\Options' => __DIR__ . '/..' . '/icewind/smb/src/Options.php', 'Icewind\\SMB\\ServerFactory' => __DIR__ . '/..' . '/icewind/smb/src/ServerFactory.php', 'Icewind\\SMB\\System' => __DIR__ . '/..' . '/icewind/smb/src/System.php', + 'Icewind\\SMB\\Test\\AbstractShareTest' => __DIR__ . '/..' . '/icewind/smb/tests/AbstractShareTest.php', + 'Icewind\\SMB\\Test\\NativeShareTest' => __DIR__ . '/..' . '/icewind/smb/tests/NativeShareTest.php', + 'Icewind\\SMB\\Test\\NativeStreamTest' => __DIR__ . '/..' . '/icewind/smb/tests/NativeStreamTest.php', + 'Icewind\\SMB\\Test\\NotifyHandlerTest' => __DIR__ . '/..' . '/icewind/smb/tests/NotifyHandlerTest.php', + 'Icewind\\SMB\\Test\\ParserTest' => __DIR__ . '/..' . '/icewind/smb/tests/ParserTest.php', + 'Icewind\\SMB\\Test\\ServerFactoryTest' => __DIR__ . '/..' . '/icewind/smb/tests/ServerFactoryTest.php', + 'Icewind\\SMB\\Test\\ServerTest' => __DIR__ . '/..' . '/icewind/smb/tests/ServerTest.php', + 'Icewind\\SMB\\Test\\ShareTest' => __DIR__ . '/..' . '/icewind/smb/tests/ShareTest.php', + 'Icewind\\SMB\\Test\\TestCase' => __DIR__ . '/..' . '/icewind/smb/tests/TestCase.php', + 'Icewind\\SMB\\Test\\TimeZoneProviderTest' => __DIR__ . '/..' . '/icewind/smb/tests/TimeZoneProviderTest.php', 'Icewind\\SMB\\TimeZoneProvider' => __DIR__ . '/..' . '/icewind/smb/src/TimeZoneProvider.php', 'Icewind\\SMB\\Wrapped\\Connection' => __DIR__ . '/..' . '/icewind/smb/src/Wrapped/Connection.php', 'Icewind\\SMB\\Wrapped\\ErrorCodes' => __DIR__ . '/..' . '/icewind/smb/src/Wrapped/ErrorCodes.php', diff --git a/apps/files_external/3rdparty/composer/installed.json b/apps/files_external/3rdparty/composer/installed.json index 18ee9e5431f..e2b841f206a 100644 --- a/apps/files_external/3rdparty/composer/installed.json +++ b/apps/files_external/3rdparty/composer/installed.json @@ -1,28 +1,28 @@ [ { "name": "icewind/smb", - "version": "v3.1.1", - "version_normalized": "3.1.1.0", + "version": "v3.2.3", + "version_normalized": "3.2.3.0", "source": { "type": "git", "url": "https://github.com/icewind1991/SMB.git", - "reference": "26b7b8780342d0e61313b464b880d50a2ea898e2" + "reference": "db50bb51bd0a0e55506e82cf439a9ecd232f64d4" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/icewind1991/SMB/zipball/26b7b8780342d0e61313b464b880d50a2ea898e2", - "reference": "26b7b8780342d0e61313b464b880d50a2ea898e2", + "url": "https://api.github.com/repos/icewind1991/SMB/zipball/db50bb51bd0a0e55506e82cf439a9ecd232f64d4", + "reference": "db50bb51bd0a0e55506e82cf439a9ecd232f64d4", "shasum": "" }, "require": { "icewind/streams": ">=0.2.0", - "php": ">=5.6" + "php": ">=7.1" }, "require-dev": { "friendsofphp/php-cs-fixer": "^2.13", - "phpunit/phpunit": "^5.7" + "phpunit/phpunit": "^7.0" }, - "time": "2019-03-04T15:02:42+00:00", + "time": "2020-04-08T15:20:22+00:00", "type": "library", "installation-source": "dist", "autoload": { diff --git a/apps/files_external/3rdparty/icewind/smb/.gitignore b/apps/files_external/3rdparty/icewind/smb/.gitignore index 966ac1bcbe1..17e19f04f56 100644 --- a/apps/files_external/3rdparty/icewind/smb/.gitignore +++ b/apps/files_external/3rdparty/icewind/smb/.gitignore @@ -2,4 +2,5 @@ vendor composer.lock .php_cs.cache - +listen.php +test.php diff --git a/apps/files_external/3rdparty/icewind/smb/README.md b/apps/files_external/3rdparty/icewind/smb/README.md index 4c20b1412af..6a35e736acb 100644 --- a/apps/files_external/3rdparty/icewind/smb/README.md +++ b/apps/files_external/3rdparty/icewind/smb/README.md @@ -26,7 +26,7 @@ use Icewind\SMB\BasicAuth; require('vendor/autoload.php'); $serverFactory = new ServerFactory(); -$auth = new BasicAuth('test', 'workgroup', 'test'); +$auth = new BasicAuth('user', 'workgroup', 'password'); $server = $serverFactory->createServer('localhost', $auth); $share = $server->getShare('test'); diff --git a/apps/files_external/3rdparty/icewind/smb/composer.json b/apps/files_external/3rdparty/icewind/smb/composer.json index 78375c4df48..8ec551c7340 100644 --- a/apps/files_external/3rdparty/icewind/smb/composer.json +++ b/apps/files_external/3rdparty/icewind/smb/composer.json @@ -9,11 +9,11 @@ } ], "require" : { - "php": ">=5.6", + "php": ">=7.1", "icewind/streams": ">=0.2.0" }, "require-dev": { - "phpunit/phpunit": "^5.7", + "phpunit/phpunit": "^7.0", "friendsofphp/php-cs-fixer": "^2.13" }, "autoload" : { diff --git a/apps/files_external/3rdparty/icewind/smb/src/ACL.php b/apps/files_external/3rdparty/icewind/smb/src/ACL.php new file mode 100644 index 00000000000..bdb77257f17 --- /dev/null +++ b/apps/files_external/3rdparty/icewind/smb/src/ACL.php @@ -0,0 +1,81 @@ +<?php declare(strict_types=1); +/** + * @copyright Copyright (c) 2020 Robin Appelman <robin@icewind.nl> + * + * @license GNU AGPL version 3 or any later version + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +namespace Icewind\SMB; + +class ACL { + const TYPE_ALLOW = 0; + const TYPE_DENY = 1; + + const MASK_READ = 0x0001; + const MASK_WRITE = 0x0002; + const MASK_EXECUTE = 0x00020; + const MASK_DELETE = 0x10000; + + const FLAG_OBJECT_INHERIT = 0x1; + const FLAG_CONTAINER_INHERIT = 0x2; + + private $type; + private $flags; + private $mask; + + public function __construct(int $type, int $flags, int $mask) { + $this->type = $type; + $this->flags = $flags; + $this->mask = $mask; + } + + /** + * Check if the acl allows a specific permissions + * + * Note that this does not take inherited acls into account + * + * @param int $mask one of the ACL::MASK_* constants + * @return bool + */ + public function allows(int $mask): bool { + return $this->type === self::TYPE_ALLOW && ($this->mask & $mask) === $mask; + } + + /** + * Check if the acl allows a specific permissions + * + * Note that this does not take inherited acls into account + * + * @param int $mask one of the ACL::MASK_* constants + * @return bool + */ + public function denies(int $mask): bool { + return $this->type === self::TYPE_DENY && ($this->mask & $mask) === $mask; + } + + public function getType(): int { + return $this->type; + } + + public function getFlags(): int { + return $this->flags; + } + + public function getMask(): int { + return $this->mask; + } +} diff --git a/apps/files_external/3rdparty/icewind/smb/src/Exception/ConnectionAbortedException.php b/apps/files_external/3rdparty/icewind/smb/src/Exception/ConnectionAbortedException.php new file mode 100644 index 00000000000..59363ca7ba9 --- /dev/null +++ b/apps/files_external/3rdparty/icewind/smb/src/Exception/ConnectionAbortedException.php @@ -0,0 +1,11 @@ +<?php +/** + * Copyright (c) 2020 Robin Appelman <icewind@owncloud.com> + * This file is licensed under the Licensed under the MIT license: + * http://opensource.org/licenses/MIT + */ + +namespace Icewind\SMB\Exception; + +class ConnectionAbortedException extends ConnectException { +} diff --git a/apps/files_external/3rdparty/icewind/smb/src/Exception/ConnectionResetException.php b/apps/files_external/3rdparty/icewind/smb/src/Exception/ConnectionResetException.php new file mode 100644 index 00000000000..d5ac10d32dc --- /dev/null +++ b/apps/files_external/3rdparty/icewind/smb/src/Exception/ConnectionResetException.php @@ -0,0 +1,11 @@ +<?php +/** + * Copyright (c) 2020 Robin Appelman <icewind@owncloud.com> + * This file is licensed under the Licensed under the MIT license: + * http://opensource.org/licenses/MIT + */ + +namespace Icewind\SMB\Exception; + +class ConnectionResetException extends ConnectException { +} diff --git a/apps/files_external/3rdparty/icewind/smb/src/IFileInfo.php b/apps/files_external/3rdparty/icewind/smb/src/IFileInfo.php index ae8acd3a3db..3411d498d78 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/IFileInfo.php +++ b/apps/files_external/3rdparty/icewind/smb/src/IFileInfo.php @@ -65,4 +65,9 @@ interface IFileInfo { * @return bool */ public function isArchived(); + + /** + * @return ACL[] + */ + public function getAcls(): array; } diff --git a/apps/files_external/3rdparty/icewind/smb/src/ISystem.php b/apps/files_external/3rdparty/icewind/smb/src/ISystem.php index 7740c98d97e..09994610716 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/ISystem.php +++ b/apps/files_external/3rdparty/icewind/smb/src/ISystem.php @@ -49,6 +49,13 @@ interface ISystem { public function getNetPath(); /** + * Get the full path to the `smbcacls` binary of false if the binary is not available + * + * @return string|bool + */ + public function getSmbcAclsPath(); + + /** * Get the full path to the `stdbuf` binary of false if the binary is not available * * @return string|bool diff --git a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php index 904318907f2..24344e6f0df 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeFileInfo.php @@ -7,11 +7,10 @@ namespace Icewind\SMB\Native; +use Icewind\SMB\ACL; use Icewind\SMB\IFileInfo; class NativeFileInfo implements IFileInfo { - const MODE_FILE = 0100000; - /** * @var string */ @@ -30,10 +29,7 @@ class NativeFileInfo implements IFileInfo { /** * @var array|null */ - protected $statCache = null; - - /** @var callable|null */ - protected $statCallback = null; + protected $attributeCache = null; /** * @var int @@ -44,20 +40,11 @@ class NativeFileInfo implements IFileInfo { * @param NativeShare $share * @param string $path * @param string $name - * @param array|callable $stat */ - public function __construct($share, $path, $name, $stat) { + public function __construct($share, $path, $name) { $this->share = $share; $this->path = $path; $this->name = $name; - - if (is_array($stat)) { - $this->statCache = $stat; - } elseif (is_callable($stat)) { - $this->statCallback = $stat; - } else { - throw new \InvalidArgumentException('$stat needs to be an array or callback'); - } } /** @@ -78,10 +65,20 @@ class NativeFileInfo implements IFileInfo { * @return array */ protected function stat() { - if (is_null($this->statCache)) { - $this->statCache = call_user_func($this->statCallback); + if (is_null($this->attributeCache)) { + $rawAttributes = explode(',', $this->share->getAttribute($this->path, 'system.dos_attr.*')); + $this->attributeCache = []; + foreach ($rawAttributes as $rawAttribute) { + [$name, $value] = explode(':', $rawAttribute); + $name = strtolower($name); + if ($name == 'mode') { + $this->attributeCache[$name] = (int)hexdec(substr($value, 2)); + } else { + $this->attributeCache[$name] = (int)$value; + } + } } - return $this->statCache; + return $this->attributeCache; } /** @@ -97,27 +94,22 @@ class NativeFileInfo implements IFileInfo { */ public function getMTime() { $stat = $this->stat(); - return $stat['mtime']; + return $stat['change_time']; } /** - * @return bool + * @return int */ - public function isDirectory() { - $stat = $this->stat(); - return !($stat['mode'] & self::MODE_FILE); + protected function getMode() { + return $this->stat()['mode']; } /** - * @return int + * @return bool */ - protected function getMode() { - if (!$this->modeCache) { - $attribute = $this->share->getAttribute($this->path, 'system.dos_attr.mode'); - // parse hex string - $this->modeCache = (int)hexdec(substr($attribute, 2)); - } - return $this->modeCache; + public function isDirectory() { + $mode = $this->getMode(); + return (bool)($mode & IFileInfo::MODE_DIRECTORY); } /** @@ -151,4 +143,22 @@ class NativeFileInfo implements IFileInfo { $mode = $this->getMode(); return (bool)($mode & IFileInfo::MODE_ARCHIVE); } + + /** + * @return ACL[] + */ + public function getAcls(): array { + $acls = []; + $attribute = $this->share->getAttribute($this->path, 'system.nt_sec_desc.acl.*+'); + + foreach (explode(',', $attribute) as $acl) { + [$user, $permissions] = explode(':', $acl, 2); + [$type, $flags, $mask] = explode('/', $permissions); + $mask = hexdec($mask); + + $acls[$user] = new ACL($type, $flags, $mask); + } + + return $acls; + } } diff --git a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php index 1a33f4b0d36..e829be28bf0 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php @@ -94,9 +94,7 @@ class NativeShare extends AbstractShare { $name = $file['name']; if ($name !== '.' and $name !== '..') { $fullPath = $path . '/' . $name; - $files [] = new NativeFileInfo($this, $fullPath, $name, function () use ($fullPath) { - return $this->getStat($fullPath); - }); + $files [] = new NativeFileInfo($this, $fullPath, $name); } } @@ -109,7 +107,12 @@ class NativeShare extends AbstractShare { * @return \Icewind\SMB\IFileInfo */ public function stat($path) { - return new NativeFileInfo($this, $path, self::mb_basename($path), $this->getStat($path)); + $info = new NativeFileInfo($this, $path, self::mb_basename($path)); + + // trigger attribute loading + $info->getSize(); + + return $info; } /** @@ -129,10 +132,6 @@ class NativeShare extends AbstractShare { return ''; } - private function getStat($path) { - return $this->getState()->stat($this->buildUrl($path)); - } - /** * Create a folder on the share * @@ -198,12 +197,14 @@ class NativeShare extends AbstractShare { */ public function put($source, $target) { $sourceHandle = fopen($source, 'rb'); - $targetHandle = $this->getState()->create($this->buildUrl($target)); + $targetUrl = $this->buildUrl($target); + + $targetHandle = $this->getState()->create($targetUrl); while ($data = fread($sourceHandle, NativeReadStream::CHUNK_SIZE)) { - $this->getState()->write($targetHandle, $data); + $this->getState()->write($targetHandle, $data, $targetUrl); } - $this->getState()->close($targetHandle); + $this->getState()->close($targetHandle, $targetUrl); return true; } @@ -223,6 +224,12 @@ class NativeShare extends AbstractShare { if (!$target) { throw new InvalidPathException('Invalid target path: Filename cannot be empty'); } + + $sourceHandle = $this->getState()->open($this->buildUrl($source), 'r'); + if (!$sourceHandle) { + throw new InvalidResourceException('Failed opening remote file "' . $source . '" for reading'); + } + $targetHandle = @fopen($target, 'wb'); if (!$targetHandle) { $error = error_get_last(); @@ -231,19 +238,14 @@ class NativeShare extends AbstractShare { } else { $reason = 'Unknown error'; } + $this->getState()->close($sourceHandle, $this->buildUrl($source)); throw new InvalidResourceException('Failed opening local file "' . $target . '" for writing: ' . $reason); } - $sourceHandle = $this->getState()->open($this->buildUrl($source), 'r'); - if (!$sourceHandle) { - fclose($targetHandle); - throw new InvalidResourceException('Failed opening remote file "' . $source . '" for reading'); - } - while ($data = $this->getState()->read($sourceHandle, NativeReadStream::CHUNK_SIZE)) { fwrite($targetHandle, $data); } - $this->getState()->close($sourceHandle); + $this->getState()->close($sourceHandle, $this->buildUrl($source)); return true; } @@ -289,7 +291,7 @@ class NativeShare extends AbstractShare { */ public function append($source) { $url = $this->buildUrl($source); - $handle = $this->getState()->open($url, "a"); + $handle = $this->getState()->open($url, "a+"); return NativeWriteStream::wrap($this->getState(), $handle, "a", $url); } diff --git a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php index 5ab129cbfd3..3bfb1c3da24 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php @@ -9,12 +9,14 @@ namespace Icewind\SMB\Native; use Icewind\SMB\Exception\AlreadyExistsException; use Icewind\SMB\Exception\ConnectionRefusedException; +use Icewind\SMB\Exception\ConnectionResetException; use Icewind\SMB\Exception\Exception; use Icewind\SMB\Exception\FileInUseException; use Icewind\SMB\Exception\ForbiddenException; use Icewind\SMB\Exception\HostDownException; use Icewind\SMB\Exception\InvalidArgumentException; use Icewind\SMB\Exception\InvalidTypeException; +use Icewind\SMB\Exception\ConnectionAbortedException; use Icewind\SMB\Exception\NoRouteToHostException; use Icewind\SMB\Exception\NotEmptyException; use Icewind\SMB\Exception\NotFoundException; @@ -48,6 +50,8 @@ class NativeState { 22 => InvalidArgumentException::class, 28 => OutOfSpaceException::class, 39 => NotEmptyException::class, + 103 => ConnectionAbortedException::class, + 104 => ConnectionResetException::class, 110 => TimedOutException::class, 111 => ConnectionRefusedException::class, 112 => HostDownException::class, @@ -236,13 +240,14 @@ class NativeState { /** * @param resource $file * @param string $data + * @param string $path * @param int $length * @return int */ - public function write($file, $data, $length = null) { + public function write($file, $data, $path, $length = null) { $result = @smbclient_write($this->state, $file, $data, $length); - $this->testResult($result, $file); + $this->testResult($result, $path); return $result; } @@ -271,10 +276,10 @@ class NativeState { return $result; } - public function close($file) { + public function close($file, $path) { $result = @smbclient_close($this->state, $file); - $this->testResult($result, $file); + $this->testResult($result, $path); return $result; } diff --git a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeStream.php b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeStream.php index dd92edcbf5e..c75afaa5f1d 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeStream.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeStream.php @@ -61,7 +61,11 @@ class NativeStream implements File { } public function stream_close() { - return $this->state->close($this->handle); + try { + return $this->state->close($this->handle, $this->url); + } catch (\Exception $e) { + return false; + } } public function stream_eof() { @@ -110,7 +114,7 @@ class NativeStream implements File { } public function stream_write($data) { - return $this->state->write($this->handle, $data); + return $this->state->write($this->handle, $data, $this->url); } public function stream_truncate($size) { diff --git a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeWriteStream.php b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeWriteStream.php index 39eca8175a9..4e90e5a655d 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Native/NativeWriteStream.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Native/NativeWriteStream.php @@ -61,7 +61,7 @@ class NativeWriteStream extends NativeStream { private function flushWrite() { rewind($this->writeBuffer); - $this->state->write($this->handle, stream_get_contents($this->writeBuffer)); + $this->state->write($this->handle, stream_get_contents($this->writeBuffer), $this->url); $this->writeBuffer = fopen('php://memory', 'r+'); $this->bufferSize = 0; } @@ -79,8 +79,13 @@ class NativeWriteStream extends NativeStream { } public function stream_close() { - $this->flushWrite(); - return parent::stream_close(); + try { + $this->flushWrite(); + $flushResult = true; + } catch (\Exception $e) { + $flushResult = false; + } + return parent::stream_close() && $flushResult; } public function stream_tell() { diff --git a/apps/files_external/3rdparty/icewind/smb/src/System.php b/apps/files_external/3rdparty/icewind/smb/src/System.php index 3428dd87cd6..0e41ee032d6 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/System.php +++ b/apps/files_external/3rdparty/icewind/smb/src/System.php @@ -41,6 +41,10 @@ class System implements ISystem { return $this->getBinaryPath('net'); } + public function getSmbcAclsPath() { + return $this->getBinaryPath('smbcacls'); + } + public function getStdBufPath() { return $this->getBinaryPath('stdbuf'); } diff --git a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Connection.php b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Connection.php index 830f6fb17b0..347b63db110 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Connection.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Connection.php @@ -117,8 +117,9 @@ class Connection extends RawConnection { } public function close($terminate = true) { - if (is_resource($this->getInputStream())) { - $this->write('close' . PHP_EOL); + if (get_resource_type($this->getInputStream()) === 'stream') { + // ignore any errors while trying to send the close command, the process might already be dead + @$this->write('close' . PHP_EOL); } parent::close($terminate); } diff --git a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/FileInfo.php b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/FileInfo.php index 094e665a935..a310a6bc913 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/FileInfo.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/FileInfo.php @@ -7,6 +7,7 @@ namespace Icewind\SMB\Wrapped; +use Icewind\SMB\ACL; use Icewind\SMB\IFileInfo; class FileInfo implements IFileInfo { @@ -36,18 +37,25 @@ class FileInfo implements IFileInfo { protected $mode; /** + * @var callable + */ + protected $aclCallback; + + /** * @param string $path * @param string $name * @param int $size * @param int $time * @param int $mode + * @param callable $aclCallback */ - public function __construct($path, $name, $size, $time, $mode) { + public function __construct($path, $name, $size, $time, $mode, callable $aclCallback) { $this->path = $path; $this->name = $name; $this->size = $size; $this->time = $time; $this->mode = $mode; + $this->aclCallback = $aclCallback; } /** @@ -112,4 +120,11 @@ class FileInfo implements IFileInfo { public function isArchived() { return (bool)($this->mode & IFileInfo::MODE_ARCHIVE); } + + /** + * @return ACL[] + */ + public function getAcls(): array { + return ($this->aclCallback)(); + } } diff --git a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Parser.php b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Parser.php index 9eee686c0ba..a28432e4319 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Parser.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Parser.php @@ -33,7 +33,6 @@ class Parser { */ private $host; - // todo replace with static once <5.6 support is dropped // see error.h const EXCEPTION_MAP = [ ErrorCodes::LogonFailure => AuthenticationException::class, @@ -146,12 +145,12 @@ class Parser { } return [ 'mtime' => strtotime($data['write_time']), - 'mode' => hexdec(substr($data['attributes'], strpos($data['attributes'], '('), -1)), + 'mode' => hexdec(substr($data['attributes'], strpos($data['attributes'], '(') + 1, -1)), 'size' => isset($data['stream']) ? (int)(explode(' ', $data['stream'])[1]) : 0 ]; } - public function parseDir($output, $basePath) { + public function parseDir($output, $basePath, callable $aclCallback) { //last line is used space array_pop($output); $regex = '/^\s*(.*?)\s\s\s\s+(?:([NDHARS]*)\s+)?([0-9]+)\s+(.*)$/'; @@ -163,7 +162,10 @@ class Parser { if ($name !== '.' and $name !== '..') { $mode = $this->parseMode($mode); $time = strtotime($time . ' ' . $this->timeZone); - $content[] = new FileInfo($basePath . '/' . $name, $name, $size, $time, $mode); + $path = $basePath . '/' . $name; + $content[] = new FileInfo($path, $name, $size, $time, $mode, function () use ($aclCallback, $path) { + return $aclCallback($path); + }); } } } diff --git a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/RawConnection.php b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/RawConnection.php index f29cf60eb66..3a114af5e4f 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/RawConnection.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/RawConnection.php @@ -173,18 +173,6 @@ class RawConnection { return; } if ($terminate) { - // if for case that posix_ functions are not available - if (function_exists('posix_kill')) { - $status = proc_get_status($this->process); - $ppid = $status['pid']; - $pids = preg_split('/\s+/', `ps -o pid --no-heading --ppid $ppid`); - foreach ($pids as $pid) { - if (is_numeric($pid)) { - //9 is the SIGKILL signal - posix_kill($pid, 9); - } - } - } proc_terminate($this->process); } proc_close($this->process); diff --git a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Share.php b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Share.php index 5a79c49fecf..e0df1f60326 100644 --- a/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Share.php +++ b/apps/files_external/3rdparty/icewind/smb/src/Wrapped/Share.php @@ -8,6 +8,7 @@ namespace Icewind\SMB\Wrapped; use Icewind\SMB\AbstractShare; +use Icewind\SMB\ACL; use Icewind\SMB\Exception\ConnectionException; use Icewind\SMB\Exception\DependencyException; use Icewind\SMB\Exception\FileInUseException; @@ -55,6 +56,8 @@ class Share extends AbstractShare { FileInfo::MODE_SYSTEM => 's' ]; + const EXEC_CMD = 'exec'; + /** * @param IServer $server * @param string $name @@ -78,7 +81,8 @@ class Share extends AbstractShare { protected function getConnection() { $command = sprintf( - '%s%s -t %s %s %s %s', + '%s %s%s -t %s %s %s %s', + self::EXEC_CMD, $this->system->getStdBufPath() ? $this->system->getStdBufPath() . ' -o0 ' : '', $this->system->getSmbclientPath(), $this->server->getOptions()->getTimeout(), @@ -150,7 +154,9 @@ class Share extends AbstractShare { $this->execute('cd /'); - return $this->parser->parseDir($output, $path); + return $this->parser->parseDir($output, $path, function ($path) { + return $this->getAcls($path); + }); } /** @@ -183,7 +189,9 @@ class Share extends AbstractShare { $this->parseOutput($output, $path); } $stat = $this->parser->parseStat($output); - return new FileInfo($path, basename($path), $stat['size'], $stat['mtime'], $stat['mode']); + return new FileInfo($path, basename($path), $stat['size'], $stat['mtime'], $stat['mode'], function () use ($path) { + return $this->getAcls($path); + }); } /** @@ -418,13 +426,13 @@ class Share extends AbstractShare { * @param string[] $lines * @param string $path * - * @throws NotFoundException + * @return bool * @throws \Icewind\SMB\Exception\AlreadyExistsException * @throws \Icewind\SMB\Exception\AccessDeniedException * @throws \Icewind\SMB\Exception\NotEmptyException * @throws \Icewind\SMB\Exception\InvalidTypeException * @throws \Icewind\SMB\Exception\Exception - * @return bool + * @throws NotFoundException */ protected function parseOutput($lines, $path = '') { if (count($lines) === 0) { @@ -467,6 +475,83 @@ class Share extends AbstractShare { return '"' . $path . '"'; } + protected function getAcls($path) { + $commandPath = $this->system->getSmbcAclsPath(); + if (!$commandPath) { + return []; + } + + $command = sprintf( + '%s %s %s %s/%s %s', + $commandPath, + $this->getAuthFileArgument(), + $this->server->getAuth()->getExtraCommandLineArguments(), + escapeshellarg('//' . $this->server->getHost()), + escapeshellarg($this->name), + escapeshellarg($path) + ); + $connection = new RawConnection($command); + $connection->writeAuthentication($this->server->getAuth()->getUsername(), $this->server->getAuth()->getPassword()); + $connection->connect(); + if (!$connection->isValid()) { + throw new ConnectionException($connection->readLine()); + } + + $rawAcls = $connection->readAll(); + + $acls = []; + foreach ($rawAcls as $acl) { + [$type, $acl] = explode(':', $acl, 2); + if ($type !== 'ACL') { + continue; + } + [$user, $permissions] = explode(':', $acl, 2); + [$type, $flags, $mask] = explode('/', $permissions); + + $type = $type === 'ALLOWED' ? ACL::TYPE_ALLOW : ACL::TYPE_DENY; + + $flagsInt = 0; + foreach (explode('|', $flags) as $flagString) { + if ($flagString === 'OI') { + $flagsInt += ACL::FLAG_OBJECT_INHERIT; + } elseif ($flagString === 'CI') { + $flagsInt += ACL::FLAG_CONTAINER_INHERIT; + } + } + + if (substr($mask, 0, 2) === '0x') { + $maskInt = hexdec($mask); + } else { + $maskInt = 0; + foreach (explode('|', $mask) as $maskString) { + if ($maskString === 'R') { + $maskInt += ACL::MASK_READ; + } elseif ($maskString === 'W') { + $maskInt += ACL::MASK_WRITE; + } elseif ($maskString === 'X') { + $maskInt += ACL::MASK_EXECUTE; + } elseif ($maskString === 'D') { + $maskInt += ACL::MASK_DELETE; + } elseif ($maskString === 'READ') { + $maskInt += ACL::MASK_READ + ACL::MASK_EXECUTE; + } elseif ($maskString === 'CHANGE') { + $maskInt += ACL::MASK_READ + ACL::MASK_EXECUTE + ACL::MASK_WRITE + ACL::MASK_DELETE; + } elseif ($maskString === 'FULL') { + $maskInt += ACL::MASK_READ + ACL::MASK_EXECUTE + ACL::MASK_WRITE + ACL::MASK_DELETE; + } + } + } + + if (isset($acls[$user])) { + $existing = $acls[$user]; + $maskInt += $existing->getMask(); + } + $acls[$user] = new ACL($type, $flagsInt, $maskInt); + } + + return $acls; + } + public function __destruct() { unset($this->connection); } |