summaryrefslogtreecommitdiffstats
path: root/apps/files_sharing/js/sharetabview.js
diff options
context:
space:
mode:
authorVincent Petry <pvince81@owncloud.com>2015-08-14 15:54:27 +0200
committerVincent Petry <pvince81@owncloud.com>2015-08-14 16:51:04 +0200
commite2549fa660630c1345dcdc84be9114ad2e54c0aa (patch)
tree0529f045d6f03f793bae98aac58894fd663a0913 /apps/files_sharing/js/sharetabview.js
parent4e327d058c66b98b8ff357589f339e57400c7a63 (diff)
downloadnextcloud-server-e2549fa660630c1345dcdc84be9114ad2e54c0aa.tar.gz
nextcloud-server-e2549fa660630c1345dcdc84be9114ad2e54c0aa.zip
Improve right sidebar tabs behavior
Tab heads are not rendered if only one tab. The tab contents is updated on-demand. This means that if a tab is not visible it is not rendered at first. If the tab was already rendered through switching, its model will not get updated until the next time it becomes visible. This will prevent needless rerendering of invisible tab contents, especially considering that some tabs might need extra ajax requests.
Diffstat (limited to 'apps/files_sharing/js/sharetabview.js')
-rw-r--r--apps/files_sharing/js/sharetabview.js9
1 files changed, 7 insertions, 2 deletions
diff --git a/apps/files_sharing/js/sharetabview.js b/apps/files_sharing/js/sharetabview.js
index 5f4a21a4a57..ee572b747ea 100644
--- a/apps/files_sharing/js/sharetabview.js
+++ b/apps/files_sharing/js/sharetabview.js
@@ -10,7 +10,7 @@
(function() {
var TEMPLATE =
- '<div>Owner: {{owner}}';
+ '<div><ul>{{#if owner}}<li>Owner: {{owner}}</li>{{/if}}</ul></div>';
/**
* @memberof OCA.Sharing
@@ -37,8 +37,13 @@
}
if (this.model) {
+ console.log(this.model);
+ var owner = this.model.get('shareOwner');
+ if (owner === OC.currentUser) {
+ owner = null;
+ }
this.$el.append(this._template({
- owner: this.model.get('shareOwner') || OC.currentUser
+ owner: owner
}));
} else {