Remove allmost all deprecation from the files_version app

The remaining deprecations are related to Utils::hooks and I will take a
look at how EventDispatcher works before working on them.

Aside from the deprecations, this patch also does a few minor
improvements around type hinting.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

1 files changed, 5 insertions, 11 deletions

diff --git a/apps/files_versions/lib/Controller/PreviewController.php b/apps/files_versions/lib/Controller/PreviewController.php
index 75093165af9..0e625dc2139 100644
--- a/apps/files_versions/lib/Controller/PreviewController.php
+++ b/apps/files_versions/lib/Controller/PreviewController.php
@@ -29,7 +29,6 @@ use OCP\AppFramework\Controller;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\FileDisplayResponse;
-use OCP\Files\IMimeTypeDetector;
 use OCP\Files\IRootFolder;
 use OCP\Files\NotFoundException;
 use OCP\IPreview;
@@ -44,9 +43,6 @@ class PreviewController extends Controller {
 	/** @var IUserSession */
 	private $userSession;
 
-	/** @var IMimeTypeDetector */
-	private $mimeTypeDetector;
-
 	/** @var IVersionManager */
 	private $versionManager;
 
@@ -54,11 +50,10 @@ class PreviewController extends Controller {
 	private $previewManager;
 
 	public function __construct(
-		$appName,
+		string $appName,
 		IRequest $request,
 		IRootFolder $rootFolder,
 		IUserSession $userSession,
-		IMimeTypeDetector $mimeTypeDetector,
 		IVersionManager $versionManager,
 		IPreview $previewManager
 	) {
@@ -66,7 +61,6 @@ class PreviewController extends Controller {
 
 		$this->rootFolder = $rootFolder;
 		$this->userSession = $userSession;
-		$this->mimeTypeDetector = $mimeTypeDetector;
 		$this->versionManager = $versionManager;
 		$this->previewManager = $previewManager;
 	}
@@ -82,10 +76,10 @@ class PreviewController extends Controller {
 	 * @return DataResponse|FileDisplayResponse
 	 */
 	public function getPreview(
-		$file = '',
-		$x = 44,
-		$y = 44,
-		$version = ''
+		string $file = '',
+		int $x = 44,
+		int $y = 44,
+		string $version = ''
 	) {
 		if ($file === '' || $version === '' || $x === 0 || $y === 0) {
 			return new DataResponse([], Http::STATUS_BAD_REQUEST);