diff options
author | Christoph Wurst <christoph@winzerhof-wurst.at> | 2020-10-08 19:52:29 +0200 |
---|---|---|
committer | Morris Jobke <hey@morrisjobke.de> | 2020-10-12 22:17:06 +0200 |
commit | 02fa3253fe82673e14b03e78b4e30a61d8982c19 (patch) | |
tree | 362101da75170abc9ab8b6e9aa898a213ef60009 /apps/files_versions | |
parent | deb499d34e7e4760db22d250b4cb1449e981d98c (diff) | |
download | nextcloud-server-02fa3253fe82673e14b03e78b4e30a61d8982c19.tar.gz nextcloud-server-02fa3253fe82673e14b03e78b4e30a61d8982c19.zip |
Fix undefined index and consequential damages in versions code
If the user has no space and there are no versions, there won't be an
`all` index in the versions entry. Hence this triggers a warning and
becomes `null`, afterwards `count`, `foreach` and friends will happily
throw even more warnings and errors because they don't want to play with
`null`. Thus adding a fallback to an empty array.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Diffstat (limited to 'apps/files_versions')
-rw-r--r-- | apps/files_versions/lib/Storage.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/files_versions/lib/Storage.php b/apps/files_versions/lib/Storage.php index 3f4ccf7f0a2..f9dbe449e0d 100644 --- a/apps/files_versions/lib/Storage.php +++ b/apps/files_versions/lib/Storage.php @@ -776,7 +776,7 @@ class Storage { // if still not enough free space we rearrange the versions from all files if ($availableSpace <= 0) { $result = Storage::getAllVersions($uid); - $allVersions = $result['all']; + $allVersions = $result['all'] ?? []; foreach ($result['by_file'] as $versions) { list($toDeleteNew, $size) = self::getExpireList($time, $versions, $availableSpace <= 0); |