diff options
| author | MichaIng <micha@dietpi.com> | 2023-01-20 21:59:30 +0100 |
|---|---|---|
| committer | Simon L. (Rebase PR Action) <szaimen@e.mail.de> | 2023-01-23 08:55:35 +0000 |
| commit | 03390ee791405aa399e00cc1b0220ae9e3c8d85e (patch) | |
| tree | 743fb9c0e13027824ddf51199c32b151a04f38c0 /apps/settings/lib | |
| parent | 20190534ee70cba9644552fb2fb5833e17d16832 (diff) | |
| download | nextcloud-server-03390ee791405aa399e00cc1b0220ae9e3c8d85e.tar.gz nextcloud-server-03390ee791405aa399e00cc1b0220ae9e3c8d85e.zip | |
Fix interned strings buffer check if 0 free bytes
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.
This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.
Signed-off-by: MichaIng <micha@dietpi.com>
Diffstat (limited to 'apps/settings/lib')
| -rw-r--r-- | apps/settings/lib/Controller/CheckSetupController.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index eaaacc3fd22..a5c158d2602 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -524,11 +524,11 @@ Raw output } if ( - empty($status['interned_strings_usage']['free_memory']) || + // Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size + ($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4) && ( - ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) && - // Do not recommend to raise the interned strings buffer size above a quarter of the total OPcache size - ($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') < $this->iniGetWrapper->getNumeric('opcache.memory_consumption') / 4) + empty($status['interned_strings_usage']['free_memory']) || + ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) ) ) { $recommendations[] = $this->l10n->t('The OPcache interned strings buffer is nearly full. To assure that repeating strings can be effectively cached, it is recommended to apply <code>opcache.interned_strings_buffer</code> to your PHP configuration with a value higher than <code>%s</code>.', [($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?: 'currently')]); |