diff options
author | Ferdinand Thiessen <opensource@fthiessen.de> | 2023-12-22 00:00:04 +0100 |
---|---|---|
committer | John Molakvoæ <skjnldsv@protonmail.com> | 2024-01-15 18:21:53 +0100 |
commit | fcdc53a2bafc500eb663eb62148965aba2d8dcbe (patch) | |
tree | 203f79d22bebfd4bdd9f08f4c7e5c64982edc386 /apps/settings/lib | |
parent | b8aa466b0ebe6dc415669bc81a902f732a8b1713 (diff) | |
download | nextcloud-server-fcdc53a2bafc500eb663eb62148965aba2d8dcbe.tar.gz nextcloud-server-fcdc53a2bafc500eb663eb62148965aba2d8dcbe.zip |
enh(settings): Add SetupCheck to ensure webserver correctly serves `.mjs` files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Diffstat (limited to 'apps/settings/lib')
-rw-r--r-- | apps/settings/lib/AppInfo/Application.php | 2 | ||||
-rw-r--r-- | apps/settings/lib/SetupChecks/JavaScriptModules.php | 77 |
2 files changed, 79 insertions, 0 deletions
diff --git a/apps/settings/lib/AppInfo/Application.php b/apps/settings/lib/AppInfo/Application.php index 12660f42ecc..06f69bbf401 100644 --- a/apps/settings/lib/AppInfo/Application.php +++ b/apps/settings/lib/AppInfo/Application.php @@ -58,6 +58,7 @@ use OCA\Settings\SetupChecks\EmailTestSuccessful; use OCA\Settings\SetupChecks\FileLocking; use OCA\Settings\SetupChecks\ForwardedForHeaders; use OCA\Settings\SetupChecks\InternetConnectivity; +use OCA\Settings\SetupChecks\JavaScriptModules; use OCA\Settings\SetupChecks\LegacySSEKeyFormat; use OCA\Settings\SetupChecks\MaintenanceWindowStart; use OCA\Settings\SetupChecks\MemcacheConfigured; @@ -172,6 +173,7 @@ class Application extends App implements IBootstrap { $context->registerSetupCheck(FileLocking::class); $context->registerSetupCheck(ForwardedForHeaders::class); $context->registerSetupCheck(InternetConnectivity::class); + $context->registerSetupCheck(JavaScriptModules::class); $context->registerSetupCheck(LegacySSEKeyFormat::class); $context->registerSetupCheck(MaintenanceWindowStart::class); $context->registerSetupCheck(MemcacheConfigured::class); diff --git a/apps/settings/lib/SetupChecks/JavaScriptModules.php b/apps/settings/lib/SetupChecks/JavaScriptModules.php new file mode 100644 index 00000000000..d2d69eb45e0 --- /dev/null +++ b/apps/settings/lib/SetupChecks/JavaScriptModules.php @@ -0,0 +1,77 @@ +<?php + +declare(strict_types=1); + +/** + * @copyright Copyright (c) 2023 Ferdinand Thiessen <opensource@fthiessen.de> + * + * @author Ferdinand Thiessen <opensource@fthiessen.de> + * + * @license AGPL-3.0-or-later + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, either version 3 of the + * License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ +namespace OCA\Settings\SetupChecks; + +use OCP\Http\Client\IClientService; +use OCP\IConfig; +use OCP\IL10N; +use OCP\IURLGenerator; +use OCP\SetupCheck\ISetupCheck; +use OCP\SetupCheck\SetupResult; +use Psr\Log\LoggerInterface; + +/** + * Checks if the webserver serves '.mjs' files using the correct MIME type + */ +class JavaScriptModules implements ISetupCheck { + public function __construct( + private IL10N $l10n, + private IConfig $config, + private IURLGenerator $urlGenerator, + private IClientService $clientService, + private LoggerInterface $logger, + ) { + } + + public function getCategory(): string { + return 'network'; + } + + public function getName(): string { + return $this->l10n->t('Supports JavaScript modules'); + } + + public function run(): SetupResult { + $testFile = $this->urlGenerator->linkTo('settings', 'js/esm-test.mjs'); + $testURLs = array_merge( + [$this->urlGenerator->getAbsoluteURL($testFile)], + array_map(fn (string $host): string => $host . $testFile, $this->config->getSystemValue('trusted_domains', [])) + ); + + foreach ($testURLs as $testURL) { + try { + $client = $this->clientService->newClient(); + $response = $client->head($testURL, ['connect_timeout' => 10]); + if (preg_match('/(text|application)\/javascript/i', $response->getHeader('Content-Type'))) { + return SetupResult::success(); + } + } catch (\Throwable $e) { + $this->logger->debug('Can not connect to local server for checking JavaScript modules support', ['exception' => $e, 'url' => $testURL]); + } + } + return SetupResult::error($this->l10n->t('Your webserver does not serve `.mjs` files using the JavaScript MIME type. This will break some apps by preventing browsers from executing the JavaScript files. You should configure your webserver to serve `.mjs` files with either the `text/javascript` or `application/javascript` MIME type.')); + } +} |