aboutsummaryrefslogtreecommitdiffstats
path: root/apps/settings
diff options
context:
space:
mode:
authorFerdinand Thiessen <opensource@fthiessen.de>2023-10-23 17:16:43 +0200
committerGitHub <noreply@github.com>2023-10-23 17:16:43 +0200
commitd43c66e96a43f322b18adedb68fdd0eb8430d4c0 (patch)
tree90d262a6e4d7bdf37dbf9905cf85e572cbe76789 /apps/settings
parent834c9a209ebef7b8d5795b53a018577fe4e534ca (diff)
parent1fbe58b0fb6214b043e772885b420cfb5fe143bc (diff)
downloadnextcloud-server-d43c66e96a43f322b18adedb68fdd0eb8430d4c0.tar.gz
nextcloud-server-d43c66e96a43f322b18adedb68fdd0eb8430d4c0.zip
Merge pull request #41034 from nextcloud/fix/37092/users--html-validation
fix(settings): users page html validation
Diffstat (limited to 'apps/settings')
-rw-r--r--apps/settings/src/components/Users/UserRow.vue8
-rw-r--r--apps/settings/src/views/Users.vue1
2 files changed, 4 insertions, 5 deletions
diff --git a/apps/settings/src/components/Users/UserRow.vue b/apps/settings/src/components/Users/UserRow.vue
index d62780d2b61..a013077a582 100644
--- a/apps/settings/src/components/Users/UserRow.vue
+++ b/apps/settings/src/components/Users/UserRow.vue
@@ -150,7 +150,7 @@
:for="'subadmins' + uniqueId">
{{ t('settings', 'Set user as admin for') }}
</label>
- <NcSelect :id="'subadmins' + uniqueId"
+ <NcSelect :input-id="'subadmins' + uniqueId"
:close-on-select="false"
:disabled="isLoadingField"
:loading="loading.subadmins"
@@ -190,8 +190,8 @@
@option:selected="setUserQuota" />
</template>
<template v-else-if="!isObfuscated">
- <label :for="'quota-progress' + uniqueId">{{ userQuota }} ({{ usedSpace }})</label>
- <NcProgressBar :id="'quota-progress' + uniqueId"
+ <span :id="'quota-progress' + uniqueId">{{ userQuota }} ({{ usedSpace }})</span>
+ <NcProgressBar :aria-labelledby="'quota-progress' + uniqueId"
class="row__progress"
:class="{
'row__progress--warn': usedQuota > 80,
@@ -406,7 +406,7 @@ export default {
},
uniqueId() {
- return this.user.id + this.rand
+ return encodeURIComponent(this.user.id + this.rand)
},
userGroupsLabels() {
diff --git a/apps/settings/src/views/Users.vue b/apps/settings/src/views/Users.vue
index 13a7d46d256..f6c61998a73 100644
--- a/apps/settings/src/views/Users.vue
+++ b/apps/settings/src/views/Users.vue
@@ -26,7 +26,6 @@
<NcAppNavigation>
<NcAppNavigationNew button-id="new-user-button"
:text="t('settings','New user')"
- button-class="icon-add"
@click="showNewUserMenu"
@keyup.enter="showNewUserMenu"
@keyup.space="showNewUserMenu">