diff options
| author | MichaIng <micha@dietpi.com> | 2022-01-07 19:43:07 +0100 |
|---|---|---|
| committer | Simon L. (Rebase PR Action) <szaimen@e.mail.de> | 2022-01-11 10:26:57 +0000 |
| commit | 79cdb565dc541de644c21aecda1d8bb552652042 (patch) | |
| tree | 805be26af40461a98033d19c3a2a102167a92215 /apps/settings | |
| parent | 6c3e9822e6cc485a37ebdc992414c39ee91f4e46 (diff) | |
| download | nextcloud-server-79cdb565dc541de644c21aecda1d8bb552652042.tar.gz nextcloud-server-79cdb565dc541de644c21aecda1d8bb552652042.zip | |
Avoid zero division in setup checks
Fixes: https://github.com/nextcloud/server/issues/30532
Signed-off-by: MichaIng <micha@dietpi.com>
Diffstat (limited to 'apps/settings')
| -rw-r--r-- | apps/settings/lib/Controller/CheckSetupController.php | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index 78874fd02b0..ac734e5eb78 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -492,15 +492,24 @@ Raw output $status = opcache_get_status(false); // Recommend to raise value, if more than 90% of max value is reached - if ($status['opcache_statistics']['num_cached_keys'] / $status['opcache_statistics']['max_cached_keys'] > 0.9) { + if ( + empty($status['opcache_statistics']['max_cached_keys']) || + ($status['opcache_statistics']['num_cached_keys'] / $status['opcache_statistics']['max_cached_keys'] > 0.9) + ) { $recommendations[] = 'The maximum number of OPcache keys is nearly exceeded. To assure that all scripts can be hold in cache, it is recommended to apply <code>opcache.max_accelerated_files</code> to your PHP configuration with a value higher than <code>' . ($this->iniGetWrapper->getNumeric('opcache.max_accelerated_files') ?: 'currently') . '</code>.'; } - if ($status['memory_usage']['used_memory'] / $status['memory_usage']['free_memory'] > 9) { + if ( + empty($status['memory_usage']['free_memory']) || + ($status['memory_usage']['used_memory'] / $status['memory_usage']['free_memory'] > 9) + ) { $recommendations[] = 'The OPcache buffer is nearly full. To assure that all scripts can be hold in cache, it is recommended to apply <code>opcache.memory_consumption</code> to your PHP configuration with a value higher than <code>' . ($this->iniGetWrapper->getNumeric('opcache.memory_consumption') ?: 'currently') . '</code>.'; } - if ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) { + if ( + empty($status['interned_strings_usage']['free_memory']) || + ($status['interned_strings_usage']['used_memory'] / $status['interned_strings_usage']['free_memory'] > 9) + ) { $recommendations[] = 'The OPcache interned strings buffer is nearly full. To assure that repeating strings can be effectively cached, it is recommended to apply <code>opcache.interned_strings_buffer</code> to your PHP configuration with a value higher than <code>' . ($this->iniGetWrapper->getNumeric('opcache.interned_strings_buffer') ?: 'currently') . '</code>.'; } } |