Fix tests

3 files changed, 24 insertions, 13 deletions

diff --git a/apps/theming/lib/Controller/ThemingController.php b/apps/theming/lib/Controller/ThemingController.php
index f09948f2817..55391619f3c 100644
--- a/apps/theming/lib/Controller/ThemingController.php
+++ b/apps/theming/lib/Controller/ThemingController.php
@@ -33,6 +33,7 @@ use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\DataDownloadResponse;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\StreamResponse;
+use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\Files\IRootFolder;
 use OCP\IConfig;
 use OCP\IL10N;
@@ -49,6 +50,10 @@ use OCA\Theming\Util;
 class ThemingController extends Controller {
 	/** @var Template */
 	private $template;
+	/** @var Util */
+	private $util;
+	/** @var ITimeFactory */
+	private $timeFactory;
 	/** @var IL10N */
 	private $l;
 	/** @var IConfig */
@@ -63,6 +68,8 @@ class ThemingController extends Controller {
 	 * @param IRequest $request
 	 * @param IConfig $config
 	 * @param Template $template
+	 * @param Util $util
+	 * @param ITimeFactory $timeFactory
 	 * @param IL10N $l
 	 * @param IRootFolder $rootFolder
 	 */
@@ -71,12 +78,16 @@ class ThemingController extends Controller {
 		IRequest $request,
 		IConfig $config,
 		Template $template,
+		Util $util,
+		ITimeFactory $timeFactory,
 		IL10N $l,
 		IRootFolder $rootFolder
 	) {
 		parent::__construct($appName, $request);
 
 		$this->template = $template;
+		$this->util = $util;
+		$this->timeFactory = $timeFactory;
 		$this->l = $l;
 		$this->config = $config;
 		$this->rootFolder = $rootFolder;
@@ -178,7 +189,7 @@ class ThemingController extends Controller {
 
 		$response = new Http\StreamResponse($pathToLogo);
 		$response->cacheFor(3600);
-		$response->addHeader('Expires', date(\DateTime::RFC2822));
+		$response->addHeader('Expires', date(\DateTime::RFC2822, $this->timeFactory->getTime()));
 		$response->addHeader('Content-Disposition', 'attachment');
 		$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, 'logoMime', ''));
 		return $response;
@@ -198,7 +209,7 @@ class ThemingController extends Controller {
 
 		$response = new StreamResponse($pathToLogo);
 		$response->cacheFor(3600);
-		$response->addHeader('Expires', date(\DateTime::RFC2822));
+		$response->addHeader('Expires', date(\DateTime::RFC2822, $this->timeFactory->getTime()));
 		$response->addHeader('Content-Disposition', 'attachment');
 		$response->addHeader('Content-Type', $this->config->getAppValue($this->appName, 'backgroundMime', ''));
 		return $response;
@@ -214,7 +225,7 @@ class ThemingController extends Controller {
 		$cacheBusterValue = $this->config->getAppValue('theming', 'cachebuster', '0');
 		$responseCss = '';
 		$color = $this->config->getAppValue($this->appName, 'color');
-		$elementColor = Util::elementColor($color);
+		$elementColor = $this->util->elementColor($color);
 		if($color !== '') {
 			$responseCss .= sprintf(
 				'#body-user #header,#body-settings #header,#body-public #header,#body-login,.searchbox input[type="search"]:focus,.searchbox input[type="search"]:active,.searchbox input[type="search"]:valid {background-color: %s}' . "\n",
@@ -229,7 +240,7 @@ class ThemingController extends Controller {
 				$elementColor
 			);
 			$responseCss .= 'input[type="radio"].radio:checked:not(.radio--white):not(:disabled) + label:before {' .
-				'background-image: url(\'data:image/svg+xml;base64,'.Util::generateRadioButton($elementColor).'\');' .
+				'background-image: url(\'data:image/svg+xml;base64,'.$this->util->generateRadioButton($elementColor).'\');' .
 				"}\n";
 			$responseCss .= '
 				#firstrunwizard .firstrunwizard-header {
@@ -265,7 +276,7 @@ class ThemingController extends Controller {
 				'background-image: url(\'./loginbackground?v='.$cacheBusterValue.'\');' .
 			'}' . "\n";
 		}
-		if(Util::invertTextColor($color)) {
+		if($this->util->invertTextColor($color)) {
 			$responseCss .= '#header .header-appname, #expandDisplayName { color: #000000; }' . "\n";
 			$responseCss .= '#header .icon-caret { background-image: url(\'' . \OC::$WEBROOT . '/core/img/actions/caret-dark.svg\'); }' . "\n";
 			$responseCss .= '.searchbox input[type="search"] { background: transparent url(\'' . \OC::$WEBROOT . '/core/img/actions/search.svg\') no-repeat 6px center; color: #000; }' . "\n";
@@ -273,7 +284,7 @@ class ThemingController extends Controller {
 		}
 
 		$response = new DataDownloadResponse($responseCss, 'style', 'text/css');
-		$response->addHeader('Expires', date(\DateTime::RFC2822));
+		$response->addHeader('Expires', date(\DateTime::RFC2822, $this->timeFactory->getTime()));
 		$response->cacheFor(3600);
 		return $response;
 	}
diff --git a/apps/theming/lib/Template.php b/apps/theming/lib/Template.php
index 8cd2befc1d1..25730aad95b 100644
--- a/apps/theming/lib/Template.php
+++ b/apps/theming/lib/Template.php
@@ -40,7 +40,7 @@ use OCP\IURLGenerator;
 class Template extends \OC_Defaults {
 	/** @var IConfig */
 	private $config;
-	/** @var  IL10N */
+	/** @var IL10N */
 	private $l;
 	/** @var IURLGenerator */
 	private $urlGenerator;
diff --git a/apps/theming/lib/Util.php b/apps/theming/lib/Util.php
index f0ce30ac5ba..71ed0958e42 100644
--- a/apps/theming/lib/Util.php
+++ b/apps/theming/lib/Util.php
@@ -29,8 +29,8 @@ class Util {
 	 * @param string $color rgb color value
 	 * @return bool
 	 */
-	public static function invertTextColor($color) {
-		$l = self::calculateLuminance($color);
+	public function invertTextColor($color) {
+		$l = $this->calculateLuminance($color);
 		if($l>0.5) {
 			return true;
 		} else {
@@ -44,8 +44,8 @@ class Util {
 	 * @param $color
 	 * @return string
 	 */
-	public static function elementColor($color) {
-		$l = self::calculateLuminance($color);
+	public function elementColor($color) {
+		$l = $this->calculateLuminance($color);
 		if($l>0.8) {
 			return '#555555';
 		} else {
@@ -57,7 +57,7 @@ class Util {
 	 * @param string $color rgb color value
 	 * @return float
 	 */
-	public static function calculateLuminance($color) {
+	public function calculateLuminance($color) {
 		$hex = preg_replace("/[^0-9A-Fa-f]/", '', $color);
 		if (strlen($hex) === 3) {
 			$hex = $hex{0} . $hex{0} . $hex{1} . $hex{1} . $hex{2} . $hex{2};
@@ -75,7 +75,7 @@ class Util {
 	 * @param $color
 	 * @return string base64 encoded radio button svg
 	 */
-	public static function generateRadioButton($color) {
+	public function generateRadioButton($color) {
 		$radioButtonIcon = '<svg xmlns="http://www.w3.org/2000/svg" height="16" width="16">' .
 			'<path d="M8 1a7 7 0 0 0-7 7 7 7 0 0 0 7 7 7 7 0 0 0 7-7 7 7 0 0 0-7-7zm0 1a6 6 0 0 1 6 6 6 6 0 0 1-6 6 6 6 0 0 1-6-6 6 6 0 0 1 6-6zm0 2a4 4 0 1 0 0 8 4 4 0 0 0 0-8z" fill="'.$color.'"/></svg>';
 		return base64_encode($radioButtonIcon);