diff options
| author | Julius Haertl <jus@bitgrid.net> | 2016-08-30 11:51:48 +0200 |
|---|---|---|
| committer | Julius Haertl <jus@bitgrid.net> | 2016-11-18 10:23:24 +0100 |
| commit | 9e28a3ba120356b03063e44445a9401c3aa205f3 (patch) | |
| tree | e9d8cbf229fb0fc77a95a8165a82b40e5b5624da /apps/theming/tests/IconBuilderTest.php | |
| parent | 237034818dd3425116ef3db04dabbc95a5d10125 (diff) | |
| download | nextcloud-server-9e28a3ba120356b03063e44445a9401c3aa205f3.tar.gz nextcloud-server-9e28a3ba120356b03063e44445a9401c3aa205f3.zip | |
Theming: Code cleanup and cache buster for mime icons
Signed-off-by: Julius Haertl <jus@bitgrid.net>
Diffstat (limited to 'apps/theming/tests/IconBuilderTest.php')
| -rw-r--r-- | apps/theming/tests/IconBuilderTest.php | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/apps/theming/tests/IconBuilderTest.php b/apps/theming/tests/IconBuilderTest.php index ffabb31df79..03054367210 100644 --- a/apps/theming/tests/IconBuilderTest.php +++ b/apps/theming/tests/IconBuilderTest.php @@ -78,7 +78,6 @@ class IconBuilderTest extends TestCase { * @param $file */ public function testRenderAppIcon($app, $color, $file) { - $this->themingDefaults->expects($this->once()) ->method('getMailHeaderColor') ->willReturn($color); @@ -92,8 +91,8 @@ class IconBuilderTest extends TestCase { $this->assertEquals($icon, $expectedIcon); $icon->destroy(); $expectedIcon->destroy(); - //$this->assertLessThan(0.0005, $expectedIcon->compareImages($icon, Imagick::METRIC_MEANABSOLUTEERROR)[1]); - + // FIXME: We may need some comparison of the generated and the test images + // cloud be something like $expectedIcon->compareImages($icon, Imagick::METRIC_MEANABSOLUTEERROR)[1]) } /** @@ -103,7 +102,6 @@ class IconBuilderTest extends TestCase { * @param $file */ public function testGetTouchIcon($app, $color, $file) { - $this->themingDefaults->expects($this->once()) ->method('getMailHeaderColor') ->willReturn($color); @@ -118,8 +116,8 @@ class IconBuilderTest extends TestCase { $this->assertEquals($icon, $expectedIcon); $icon->destroy(); $expectedIcon->destroy(); - //$this->assertLessThan(0.0005, $expectedIcon->compareImages($icon, Imagick::METRIC_MEANABSOLUTEERROR)[1]); - + // FIXME: We may need some comparison of the generated and the test images + // cloud be something like $expectedIcon->compareImages($icon, Imagick::METRIC_MEANABSOLUTEERROR)[1]) } /** @@ -129,7 +127,6 @@ class IconBuilderTest extends TestCase { * @param $file */ public function testGetFavicon($app, $color, $file) { - $this->themingDefaults->expects($this->once()) ->method('getMailHeaderColor') ->willReturn($color); @@ -143,8 +140,8 @@ class IconBuilderTest extends TestCase { $this->assertEquals(32, $icon->getImageHeight()); $icon->destroy(); $expectedIcon->destroy(); - //$this->assertLessThan(0.0005, $expectedIcon->compareImages($icon, Imagick::METRIC_MEANABSOLUTEERROR)[1]); - + // FIXME: We may need some comparison of the generated and the test images + // cloud be something like $expectedIcon->compareImages($icon, Imagick::METRIC_MEANABSOLUTEERROR)[1]) } } |