summaryrefslogtreecommitdiffstats
path: root/apps/workflowengine
diff options
context:
space:
mode:
authorArthur Schiwon <blizzz@arthur-schiwon.de>2020-11-23 21:17:37 +0100
committerArthur Schiwon <blizzz@arthur-schiwon.de>2020-11-23 21:20:27 +0100
commit21a53de45124e0a6de273e9c7073fe3dde36da1b (patch)
treedc9673ffec6638ca4b9978d4cbed3124afb521d6 /apps/workflowengine
parentdc5f17f561823851d79b4f7aa6e8bc94050adc3b (diff)
downloadnextcloud-server-21a53de45124e0a6de273e9c7073fe3dde36da1b.tar.gz
nextcloud-server-21a53de45124e0a6de273e9c7073fe3dde36da1b.zip
avoid empty null default with value that will be inserted anyways
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Diffstat (limited to 'apps/workflowengine')
-rw-r--r--apps/workflowengine/lib/Migration/PopulateNewlyIntroducedDatabaseFields.php12
-rw-r--r--apps/workflowengine/lib/Migration/Version2000Date20190808074233.php3
2 files changed, 2 insertions, 13 deletions
diff --git a/apps/workflowengine/lib/Migration/PopulateNewlyIntroducedDatabaseFields.php b/apps/workflowengine/lib/Migration/PopulateNewlyIntroducedDatabaseFields.php
index 6f344c2ee2d..50b38f81993 100644
--- a/apps/workflowengine/lib/Migration/PopulateNewlyIntroducedDatabaseFields.php
+++ b/apps/workflowengine/lib/Migration/PopulateNewlyIntroducedDatabaseFields.php
@@ -26,7 +26,6 @@ declare(strict_types=1);
namespace OCA\WorkflowEngine\Migration;
use Doctrine\DBAL\Driver\Statement;
-use OCA\WorkflowEngine\Entity\File;
use OCP\IDBConnection;
use OCP\Migration\IOutput;
use OCP\Migration\IRepairStep;
@@ -51,17 +50,6 @@ class PopulateNewlyIntroducedDatabaseFields implements IRepairStep {
$this->populateScopeTable($result);
$result->closeCursor();
-
- $this->populateEntityCol();
- }
-
- protected function populateEntityCol() {
- $qb = $this->dbc->getQueryBuilder();
-
- $qb->update('flow_operations')
- ->set('entity', $qb->createNamedParameter(File::class))
- ->where($qb->expr()->emptyString('entity'))
- ->execute();
}
protected function populateScopeTable(Statement $ids): void {
diff --git a/apps/workflowengine/lib/Migration/Version2000Date20190808074233.php b/apps/workflowengine/lib/Migration/Version2000Date20190808074233.php
index fae4fda5bc3..58458e84c86 100644
--- a/apps/workflowengine/lib/Migration/Version2000Date20190808074233.php
+++ b/apps/workflowengine/lib/Migration/Version2000Date20190808074233.php
@@ -7,6 +7,7 @@ namespace OCA\WorkflowEngine\Migration;
use Closure;
use Doctrine\DBAL\Schema\Table;
use Doctrine\DBAL\Types\Types;
+use OCA\WorkflowEngine\Entity\File;
use OCP\DB\ISchemaWrapper;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;
@@ -116,7 +117,7 @@ class Version2000Date20190808074233 extends SimpleMigrationStep {
$table->addColumn('entity', Types::STRING, [
'notnull' => true,
'length' => 256,
- 'default' => '',
+ 'default' => File::class,
]);
}
if (!$table->hasColumn('events')) {