diff options
| author | yemkareems <yemkareems@gmail.com> | 2024-06-14 10:14:44 +0530 |
|---|---|---|
| committer | yemkareems <yemkareems@gmail.com> | 2024-06-20 10:54:45 +0530 |
| commit | eae23867f2faa2f0683eac549d2dd287d7d78215 (patch) | |
| tree | ae0706c97f101aed7c93067bae0068f5b4bce23e /apps | |
| parent | 953358fdc89aaffcd54bec90a3c02d989ebe50cd (diff) | |
| download | nextcloud-server-eae23867f2faa2f0683eac549d2dd287d7d78215.tar.gz nextcloud-server-eae23867f2faa2f0683eac549d2dd287d7d78215.zip | |
fix: renameParams named as renamedNodes and code changed accordingly as suggested in review comments
Signed-off-by: yemkareems <yemkareems@gmail.com>
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/admin_audit/lib/Actions/Files.php | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/apps/admin_audit/lib/Actions/Files.php b/apps/admin_audit/lib/Actions/Files.php index 3ed0c6bdfb6..ee40a4e1476 100644 --- a/apps/admin_audit/lib/Actions/Files.php +++ b/apps/admin_audit/lib/Actions/Files.php @@ -27,7 +27,7 @@ use Psr\Log\LoggerInterface; */ class Files extends Action { - private array|null $renameParams = null; + private array $renamedNodes = []; /** * Logs file read actions * @@ -60,17 +60,13 @@ class Files extends Action { public function beforeRename(BeforeNodeRenamedEvent $event): void { try { $source = $event->getSource(); - $params = [ - 'oldid' => $source->getId(), - 'oldpath' => mb_substr($source->getInternalPath(), 5), - ]; + $this->renamedNodes[$source->getId()] = $source; } catch (InvalidPathException|NotFoundException $e) { \OCP\Server::get(LoggerInterface::class)->error( "Exception thrown in file rename: ".$e->getMessage(), ['app' => 'admin_audit', 'exception' => $e] ); return; } - $this->renameParams = $params; } /** @@ -81,10 +77,10 @@ class Files extends Action { public function afterRename(NodeRenamedEvent $event): void { try { $target = $event->getTarget(); - $renameParams = $this->renameParams; + $originalSource = $this->renamedNodes[$target->getId()]; $params = [ 'newid' => $target->getId(), - 'oldpath' => $renameParams['oldpath'], + 'oldpath' => mb_substr($originalSource->getInternalPath(), 5), 'newpath' => mb_substr($target->getInternalPath(), 5), ]; } catch (InvalidPathException|NotFoundException $e) { |