diff options
author | fenn-cs <fenn25.fn@gmail.com> | 2024-06-24 14:50:27 +0100 |
---|---|---|
committer | fenn-cs <fenn25.fn@gmail.com> | 2024-07-03 09:06:47 +0100 |
commit | 483d857de031c8915c931fd45c6a58e01e504128 (patch) | |
tree | 5b73a06b0d33f67334ee3721f3639b7c2bdf0095 /apps | |
parent | c998f5ebba6c05c49d723272deb7aa80603dd21c (diff) | |
download | nextcloud-server-483d857de031c8915c931fd45c6a58e01e504128.tar.gz nextcloud-server-483d857de031c8915c931fd45c6a58e01e504128.zip |
refactor(SharingInput): Remove unused addShare
The new sharing flow since NC27 requires that users open the sharing details tab and
customize their share before creating it.
In https://github.com/nextcloud/server/pull/39472 the work of `addShare` was handed down to
`openSharingDetails` that opens the sharing details tab for the user to customize and manually
creat their share.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Diffstat (limited to 'apps')
-rw-r--r-- | apps/files_sharing/src/components/SharingInput.vue | 75 | ||||
-rw-r--r-- | apps/files_sharing/src/views/SharingDetailsTab.vue | 6 |
2 files changed, 0 insertions, 81 deletions
diff --git a/apps/files_sharing/src/components/SharingInput.vue b/apps/files_sharing/src/components/SharingInput.vue index 90cd8143b91..cb8acbec4c2 100644 --- a/apps/files_sharing/src/components/SharingInput.vue +++ b/apps/files_sharing/src/components/SharingInput.vue @@ -445,81 +445,6 @@ export default { ...this.shareTypeToIcon(result.value.shareType), } }, - - /** - * Process the new share request - * - * @param {object} value the multiselect option - */ - async addShare(value) { - // Clear the displayed selection - this.value = null - - if (value.lookup) { - await this.getSuggestions(this.query, true) - - this.$nextTick(() => { - // open the dropdown again - this.$refs.select.$children[0].open = true - }) - return true - } - - // handle externalResults from OCA.Sharing.ShareSearch - if (value.handler) { - const share = await value.handler(this) - this.$emit('add:share', new Share(share)) - return true - } - - this.loading = true - console.debug('Adding a new share from the input for', value) - try { - let password = null - - if (this.config.enforcePasswordForPublicLink - && value.shareType === this.SHARE_TYPES.SHARE_TYPE_EMAIL) { - password = await GeneratePassword() - } - - const path = (this.fileInfo.path + '/' + this.fileInfo.name).replace('//', '/') - const share = await this.createShare({ - path, - shareType: value.shareType, - shareWith: value.shareWith, - password, - permissions: this.fileInfo.sharePermissions & getCapabilities().files_sharing.default_permissions, - attributes: JSON.stringify(this.fileInfo.shareAttributes), - }) - - // If we had a password, we need to show it to the user as it was generated - if (password) { - share.newPassword = password - // Wait for the newly added share - const component = await new Promise(resolve => { - this.$emit('add:share', share, resolve) - }) - - // open the menu on the - // freshly created share component - component.open = true - } else { - // Else we just add it normally - this.$emit('add:share', share) - } - - await this.getRecommendations() - } catch (error) { - this.$nextTick(() => { - // open the dropdown again on error - this.$refs.select.$children[0].open = true - }) - this.query = value.shareWith - console.error('Error while adding new share', error) - } finally { - this.loading = false - } - }, }, } </script> diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue index 0fbd70f607d..8254e84b4a3 100644 --- a/apps/files_sharing/src/views/SharingDetailsTab.vue +++ b/apps/files_sharing/src/views/SharingDetailsTab.vue @@ -279,8 +279,6 @@ import ShareTypes from '../mixins/ShareTypes.js' import SharesMixin from '../mixins/SharesMixin.js' import logger from '../services/logger.ts' -import { subscribe } from '@nextcloud/event-bus' - import { ATOMIC_PERMISSIONS, BUNDLED_PERMISSIONS, @@ -737,7 +735,6 @@ export default { mounted() { this.$refs.quickPermissions?.querySelector('input:checked')?.focus() - subscribe('files_sharing:external:add-share', this.handleExistingShareFromExternalSource) }, methods: { @@ -1010,9 +1007,6 @@ export default { return null // Or a default icon component if needed } }, - handleExistingShareFromExternalSource(share) { - logger.info('Existing share from external source/app', { share }) - }, }, } </script> |