aboutsummaryrefslogtreecommitdiffstats
path: root/apps
diff options
context:
space:
mode:
authorMichaIng <micha@dietpi.com>2022-02-18 16:36:43 +0100
committerSimon L. (Rebase PR Action) <szaimen@e.mail.de>2022-03-03 23:00:07 +0000
commit5ac91f1cb8fc8a2ddca1336c976a39385dd8c4cd (patch)
treea7f9f13a3608d9b91995d49be157ae590c584a7d /apps
parent787f4f02b361eec1eddf08709905ed4b5d250a48 (diff)
downloadnextcloud-server-5ac91f1cb8fc8a2ddca1336c976a39385dd8c4cd.tar.gz
nextcloud-server-5ac91f1cb8fc8a2ddca1336c976a39385dd8c4cd.zip
Add Nextcloud docs link to OPcache recommends
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list. Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend. Signed-off-by: MichaIng <micha@dietpi.com>
Diffstat (limited to 'apps')
-rw-r--r--apps/settings/lib/Controller/CheckSetupController.php2
-rw-r--r--apps/settings/tests/Controller/CheckSetupControllerTest.php3
2 files changed, 1 insertions, 4 deletions
diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php
index 11900fad45b..55207b3e74b 100644
--- a/apps/settings/lib/Controller/CheckSetupController.php
+++ b/apps/settings/lib/Controller/CheckSetupController.php
@@ -469,7 +469,7 @@ Raw output
protected function getOpcacheSetupRecommendations(): array {
// If the module is not loaded, return directly to skip inapplicable checks
if (!extension_loaded('Zend OPcache')) {
- return ['The PHP OPcache module is not loaded. <a target="_blank" rel="noreferrer noopener" class="external" href="' . $this->urlGenerator->linkToDocs('admin-php-opcache') . '">For better performance it is recommended</a> to load it into your PHP installation.'];
+ return ['The PHP OPcache module is not loaded. For better performance it is recommended to load it into your PHP installation.'];
}
$recommendations = [];
diff --git a/apps/settings/tests/Controller/CheckSetupControllerTest.php b/apps/settings/tests/Controller/CheckSetupControllerTest.php
index 20cf2b01069..4349994570b 100644
--- a/apps/settings/tests/Controller/CheckSetupControllerTest.php
+++ b/apps/settings/tests/Controller/CheckSetupControllerTest.php
@@ -582,9 +582,6 @@ class CheckSetupControllerTest extends TestCase {
if ($key === 'admin-code-integrity') {
return 'http://docs.example.org/server/go.php?to=admin-code-integrity';
}
- if ($key === 'admin-php-opcache') {
- return 'http://docs.example.org/server/go.php?to=admin-php-opcache';
- }
if ($key === 'admin-db-conversion') {
return 'http://docs.example.org/server/go.php?to=admin-db-conversion';
}