diff options
| author | Julien Veyssier <julien-nc@posteo.net> | 2024-09-25 17:05:09 +0200 |
|---|---|---|
| committer | Julien Veyssier <julien-nc@posteo.net> | 2024-09-25 17:41:24 +0200 |
| commit | efcc3e59655b08800f85ef71369db4b70248daaf (patch) | |
| tree | 7a977e0adaa6f2c5aaeca320472e10ead3a57aa9 /apps | |
| parent | 966a0a908d07293c24fe66d94afdee39eefbe29e (diff) | |
| download | nextcloud-server-efcc3e59655b08800f85ef71369db4b70248daaf.tar.gz nextcloud-server-efcc3e59655b08800f85ef71369db4b70248daaf.zip | |
fix(weatherstatus): adjustments from review comments
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/weather_status/src/App.vue | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/apps/weather_status/src/App.vue b/apps/weather_status/src/App.vue index 2a9b197cb80..f1ef28427f4 100644 --- a/apps/weather_status/src/App.vue +++ b/apps/weather_status/src/App.vue @@ -11,14 +11,19 @@ :menu-name="currentWeatherMessage"> <template #icon> <NcLoadingIcon v-if="loading" /> - <img v-else :src="weatherIconUrl" class="weather-image" alt="t('weather_status', 'Weather icon')"> + <img v-else + :src="weatherIconUrl" + alt="" + class="weather-image"> </template> <NcActionText v-if="gotWeather" :aria-hidden="true"> <template #icon> <NcLoadingIcon v-if="loading" /> <div v-else class="weather-action-image-container"> - <img :src="futureWeatherIconUrl" class="weather-image" alt="t('weather_status', 'Future weather icon')"> + <img :src="futureWeatherIconUrl" + alt="" + class="weather-image"> </div> </template> {{ forecastMessage }} @@ -47,8 +52,7 @@ {{ addRemoveFavoriteText }} </NcActionButton> <NcActionSeparator v-if="address && !errorMessage" /> - <NcActionButton - :close-after-click="true" + <NcActionButton :close-after-click="true" :aria-hidden="true" @click="onBrowserLocationClick"> <template #icon> @@ -76,7 +80,7 @@ <NcIconSvgWrapper name="Star" :svg="starSvg" :size="20" - class="favorite-color" /> + :class="{'favorite-color': address === favorite}" /> </template> {{ favorite }} </NcActionButton> @@ -567,7 +571,7 @@ export default { justify-content: center; } .weather-image { - width: 28px; + width: calc(var(--default-clickable-area) - 2 * var(--default-grid-baseline)); } // Set color to primary element for current / active favorite address |