summaryrefslogtreecommitdiffstats
path: root/apps
diff options
context:
space:
mode:
authorBjoern Schiessle <schiessle@owncloud.com>2014-11-25 10:17:31 +0100
committerBjoern Schiessle <schiessle@owncloud.com>2014-11-25 13:37:11 +0100
commit1d3350348797deeead5b02028c4ade7c874a7021 (patch)
tree7190f98b02e3a02f39a4e59cb0ebc5a95c0a40bb /apps
parent917bef39b7f1c0ca495ef102b7878ed5b15830c6 (diff)
downloadnextcloud-server-1d3350348797deeead5b02028c4ade7c874a7021.tar.gz
nextcloud-server-1d3350348797deeead5b02028c4ade7c874a7021.zip
we no longer need to keep the session open for encryption
Diffstat (limited to 'apps')
-rw-r--r--apps/files/ajax/upload.php8
-rw-r--r--apps/files_sharing/lib/controllers/sharecontroller.php9
2 files changed, 3 insertions, 14 deletions
diff --git a/apps/files/ajax/upload.php b/apps/files/ajax/upload.php
index b960e02ced7..aeb0008a7b9 100644
--- a/apps/files/ajax/upload.php
+++ b/apps/files/ajax/upload.php
@@ -1,5 +1,7 @@
<?php
+\OC::$server->getSession()->close();
+
// Firefox and Konqueror tries to download application/json for me. --Arthur
OCP\JSON::setContentTypeHeader('text/plain');
@@ -64,13 +66,7 @@ if (empty($_POST['dirToken'])) {
}
}
-
OCP\JSON::callCheck();
-if (!\OCP\App::isEnabled('files_encryption')) {
- // encryption app need to create keys later, so can't close too early
- \OC::$server->getSession()->close();
-}
-
// get array with current storage stats (e.g. max file size)
$storageStats = \OCA\Files\Helper::buildFileStorageStatistics($dir);
diff --git a/apps/files_sharing/lib/controllers/sharecontroller.php b/apps/files_sharing/lib/controllers/sharecontroller.php
index 71b5ab7f8c8..5f653e5c227 100644
--- a/apps/files_sharing/lib/controllers/sharecontroller.php
+++ b/apps/files_sharing/lib/controllers/sharecontroller.php
@@ -205,7 +205,6 @@ class ShareController extends Controller {
/**
* @PublicPage
* @NoCSRFRequired
- * @UseSession
*
* @param string $token
* @param string $files
@@ -215,12 +214,6 @@ class ShareController extends Controller {
public function downloadShare($token, $files = null, $path = '') {
\OC_User::setIncognitoMode(true);
- // FIXME: Use DI once there is a suitable class
- if (!\OCP\App::isEnabled('files_encryption')) {
- // encryption app requires the session to store the keys in
- \OC::$server->getSession()->close();
- }
-
$linkItem = OCP\Share::getShareByToken($token, false);
// Share is password protected - check whether the user is permitted to access the share
@@ -246,7 +239,7 @@ class ShareController extends Controller {
}
// FIXME: The exit is required here because otherwise the AppFramework is trying to add headers as well
- // after dispatching the request which results in a "Cannot modify header information" notice.
+ // after dispatching the request which results in a "Cannot modify header information" notice.
OC_Files::get($originalSharePath, $files_list, $_SERVER['REQUEST_METHOD'] == 'HEAD');
exit();
} else {