summaryrefslogtreecommitdiffstats
path: root/apps
diff options
context:
space:
mode:
authorLukas Reschke <lukas@owncloud.com>2016-03-05 21:58:58 +0100
committerLukas Reschke <lukas@owncloud.com>2016-03-05 21:58:58 +0100
commit4caa9e18b016ce79c22311e828226cd25b45da07 (patch)
tree25d7bc77c4bbfd240942328c5211259b9f04053f /apps
parenta98f5c03dc4e60dcd511c4b50639878e531c5119 (diff)
downloadnextcloud-server-4caa9e18b016ce79c22311e828226cd25b45da07.tar.gz
nextcloud-server-4caa9e18b016ce79c22311e828226cd25b45da07.zip
Show version to update to properly
Properly shows the version that will be updated to.
Diffstat (limited to 'apps')
-rw-r--r--apps/updatenotification/controller/admincontroller.php5
-rw-r--r--apps/updatenotification/tests/controller/AdminControllerTest.php4
2 files changed, 6 insertions, 3 deletions
diff --git a/apps/updatenotification/controller/admincontroller.php b/apps/updatenotification/controller/admincontroller.php
index cb0c6409d7e..5dbcc685809 100644
--- a/apps/updatenotification/controller/admincontroller.php
+++ b/apps/updatenotification/controller/admincontroller.php
@@ -99,12 +99,13 @@ class AdminController extends Controller {
if(($key = array_search($currentChannel, $channels)) !== false) {
unset($channels[$key]);
}
-
+ $updateState = $this->updateChecker->getUpdateState();
$params = [
- 'isNewVersionAvailable' => ($this->updateChecker->getUpdateState() === []) ? false : true,
+ 'isNewVersionAvailable' => ($updateState === []) ? false : true,
'lastChecked' => $lastUpdateCheck,
'currentChannel' => $currentChannel,
'channels' => $channels,
+ 'newVersionString' => ($updateState === []) ? '' : $updateState['updateVersion'],
];
return new TemplateResponse($this->appName, 'admin', $params, '');
diff --git a/apps/updatenotification/tests/controller/AdminControllerTest.php b/apps/updatenotification/tests/controller/AdminControllerTest.php
index 50adcd2028b..d8fc2dd335c 100644
--- a/apps/updatenotification/tests/controller/AdminControllerTest.php
+++ b/apps/updatenotification/tests/controller/AdminControllerTest.php
@@ -107,13 +107,14 @@ class AdminControllerTest extends TestCase {
$this->updateChecker
->expects($this->once())
->method('getUpdateState')
- ->willReturn(['foo' => 'bar']);
+ ->willReturn(['updateVersion' => '8.1.2']);
$params = [
'isNewVersionAvailable' => true,
'lastChecked' => 'LastCheckedReturnValue',
'currentChannel' => \OCP\Util::getChannel(),
'channels' => $channels,
+ 'newVersionString' => '8.1.2',
];
$expected = new TemplateResponse('updatenotification', 'admin', $params, '');
@@ -154,6 +155,7 @@ class AdminControllerTest extends TestCase {
'lastChecked' => 'LastCheckedReturnValue',
'currentChannel' => \OCP\Util::getChannel(),
'channels' => $channels,
+ 'newVersionString' => '',
];
$expected = new TemplateResponse('updatenotification', 'admin', $params, '');