Use more IConfig and add unit tests

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

2 files changed, 120 insertions, 21 deletions

diff --git a/apps/user_ldap/lib/Helper.php b/apps/user_ldap/lib/Helper.php
index 933aee382df..b48b4001f9d 100644
--- a/apps/user_ldap/lib/Helper.php
+++ b/apps/user_ldap/lib/Helper.php
@@ -69,19 +69,16 @@ class Helper {
 	public function getServerConfigurationPrefixes($activeConfigurations = false) {
 		$referenceConfigkey = 'ldap_configuration_active';
 
-		$config = \OC::$server->getConfig();
+		$keys = $this->getServersConfig($referenceConfigkey);
 
-		$keys = $config->getAppKeys('user_ldap');
 		$prefixes = [];
 		foreach ($keys as $key) {
-			if (preg_match('/ldap_configuration_active$/S', $key) === 1) {
-				if ($activeConfigurations && $config->getAppValue('user_ldap', $key, '0') !== '1') {
-					continue;
-				}
-
-				$len = strlen($key) - strlen($referenceConfigkey);
-				$prefixes[] = substr($key, 0, $len);
+			if ($activeConfigurations && $this->config->getAppValue('user_ldap', $key, '0') !== '1') {
+				continue;
 			}
+
+			$len = strlen($key) - strlen($referenceConfigkey);
+			$prefixes[] = substr($key, 0, $len);
 		}
 
 		return $prefixes;
@@ -96,20 +93,27 @@ class Helper {
 	public function getServerConfigurationHosts() {
 		$referenceConfigkey = 'ldap_host';
 
-		$query = '
-			SELECT DISTINCT `configkey`, `configvalue`
-			FROM `*PREFIX*appconfig`
-			WHERE `appid` = \'user_ldap\'
-				AND `configkey` LIKE ?
-		';
-		$query = \OCP\DB::prepare($query);
-		$configHosts = $query->execute(array('%'.$referenceConfigkey))->fetchAll();
+		$keys = $this->getServersConfig($referenceConfigkey);
+
 		$result = array();
+		foreach($keys as $key) {
+			$len = strlen($key) - strlen($referenceConfigkey);
+			$prefix = substr($key, 0, $len);
+			$result[$prefix] = $this->config->getAppValue('user_ldap', $key);
+		}
 
-		foreach($configHosts as $configHost) {
-			$len = strlen($configHost['configkey']) - strlen($referenceConfigkey);
-			$prefix = substr($configHost['configkey'], 0, $len);
-			$result[$prefix] = $configHost['configvalue'];
+		return $result;
+	}
+
+	private function getServersConfig($value) {
+		$regex = '/' . $value . '$/S';
+
+		$keys = $this->config->getAppKeys('user_ldap');
+		$result = [];
+		foreach ($keys as $key) {
+			if (preg_match($regex, $key) === 1) {
+				$result[] = $key;
+			}
 		}
 
 		return $result;
diff --git a/apps/user_ldap/tests/HelperTest.php b/apps/user_ldap/tests/HelperTest.php
new file mode 100644
index 00000000000..ca0bbcc4e81
--- /dev/null
+++ b/apps/user_ldap/tests/HelperTest.php
@@ -0,0 +1,95 @@
+<?php
+
+namespace OCA\User_LDAP\Tests;
+
+
+use OCA\User_LDAP\Helper;
+use OCP\IConfig;
+
+class HelperTest extends \Test\TestCase {
+
+	/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */
+	private $config;
+
+	/** @var Helper */
+	private $helper;
+
+	public function setUp() {
+		parent::setUp();
+
+		$this->config = $this->createMock(IConfig::class);
+		$this->helper = new Helper($this->config);
+	}
+
+	public function testGetServerConfigurationPrefixes() {
+		$this->config->method('getAppKeys')
+			->with($this->equalTo('user_ldap'))
+			->willReturn([
+				'foo',
+				'ldap_configuration_active',
+				's1ldap_configuration_active',
+			]);
+
+		$result = $this->helper->getServerConfigurationPrefixes(false);
+
+		$this->assertEquals(['', 's1'], $result);
+	}
+
+	public function testGetServerConfigurationPrefixesActive() {
+		$this->config->method('getAppKeys')
+			->with($this->equalTo('user_ldap'))
+			->willReturn([
+				'foo',
+				'ldap_configuration_active',
+				's1ldap_configuration_active',
+			]);
+
+		$this->config->method('getAppValue')
+			->will($this->returnCallback(function($app, $key, $default) {
+				if ($app !== 'user_ldap') {
+					$this->fail('wrong app');
+				}
+				if ($key === 's1ldap_configuration_active') {
+					return '1';
+				}
+				return $default;
+			}));
+
+		$result = $this->helper->getServerConfigurationPrefixes(true);
+
+		$this->assertEquals(['s1'], $result);
+	}
+
+	public function testGetServerConfigurationHost() {
+		$this->config->method('getAppKeys')
+			->with($this->equalTo('user_ldap'))
+			->willReturn([
+				'foo',
+				'ldap_host',
+				's1ldap_host',
+				's02ldap_host',
+			]);
+
+		$this->config->method('getAppValue')
+			->will($this->returnCallback(function($app, $key, $default) {
+				if ($app !== 'user_ldap') {
+					$this->fail('wrong app');
+				}
+				if ($key === 'ldap_host') {
+					return 'example.com';
+				}
+				if ($key === 's1ldap_host') {
+					return 'foo.bar.com';
+				}
+				return $default;
+			}));
+
+		$result = $this->helper->getServerConfigurationHosts();
+
+		$this->assertEquals([
+			'' => 'example.com',
+			's1' => 'foo.bar.com',
+			's02' => '',
+		], $result);
+	}
+}