diff options
| author | Roeland Jago Douma <roeland@famdouma.nl> | 2019-10-21 21:51:17 +0200 |
|---|---|---|
| committer | Roeland Jago Douma <roeland@famdouma.nl> | 2019-10-22 12:25:39 +0200 |
| commit | d878130fb292d8e38d0cd86089bf6aa1524e034a (patch) | |
| tree | b53256c2dbddae6d34926c44ceb68f44c3e46745 /apps | |
| parent | 923735021b35d08aadf00cb30e3e9eda42f50a50 (diff) | |
| download | nextcloud-server-d878130fb292d8e38d0cd86089bf6aa1524e034a.tar.gz nextcloud-server-d878130fb292d8e38d0cd86089bf6aa1524e034a.zip | |
Only human readbale backup chars
Fixes #14811
Only use humand readable chars (so no I and 1 etc)
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php | 2 | ||||
| -rw-r--r-- | apps/twofactor_backupcodes/tests/Unit/Service/BackupCodeStorageTest.php | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php b/apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php index 88117c37ec0..7842dd610be 100644 --- a/apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php +++ b/apps/twofactor_backupcodes/lib/Service/BackupCodeStorage.php @@ -72,7 +72,7 @@ class BackupCodeStorage { $uid = $user->getUID(); foreach (range(1, min([$number, 20])) as $i) { - $code = $this->random->generate(self::$CODE_LENGTH, ISecureRandom::CHAR_UPPER . ISecureRandom::CHAR_DIGITS); + $code = $this->random->generate(self::$CODE_LENGTH, ISecureRandom::CHAR_HUMAN_READABLE); $dbCode = new BackupCode(); $dbCode->setUserId($uid); diff --git a/apps/twofactor_backupcodes/tests/Unit/Service/BackupCodeStorageTest.php b/apps/twofactor_backupcodes/tests/Unit/Service/BackupCodeStorageTest.php index d962961c251..7c662d3ef83 100644 --- a/apps/twofactor_backupcodes/tests/Unit/Service/BackupCodeStorageTest.php +++ b/apps/twofactor_backupcodes/tests/Unit/Service/BackupCodeStorageTest.php @@ -67,7 +67,7 @@ class BackupCodeStorageTest extends TestCase { $user->method('getUID')->willReturn('fritz'); $this->random->expects($this->exactly($number)) ->method('generate') - ->with(16, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789') + ->with(16, ISecureRandom::CHAR_HUMAN_READABLE) ->will($this->returnValue('CODEABCDEF')); $this->hasher->expects($this->exactly($number)) ->method('hash') |