Merge pull request #6328 from nextcloud/split-sharees-api-logic

Splits off the logic from sharees endpoint thus making it available from within Nc/via PHP.

2 files changed, 88 insertions, 2123 deletions

diff --git a/apps/files_sharing/lib/Controller/ShareesAPIController.php b/apps/files_sharing/lib/Controller/ShareesAPIController.php
index 94a4854dbde..dcecf2c8e08 100644
--- a/apps/files_sharing/lib/Controller/ShareesAPIController.php
+++ b/apps/files_sharing/lib/Controller/ShareesAPIController.php
@@ -6,6 +6,7 @@
  * @author Joas Schilling <coding@schilljs.com>
  * @author Roeland Jago Douma <roeland@famdouma.nl>
  * @author Thomas Müller <thomas.mueller@tmit.eu>
+ * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
  *
  * @license AGPL-3.0
  *
@@ -27,52 +28,23 @@ namespace OCA\Files_Sharing\Controller;
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCS\OCSBadRequestException;
 use OCP\AppFramework\OCSController;
-use OCP\Contacts\IManager;
-use OCP\Federation\ICloudIdManager;
-use OCP\Http\Client\IClientService;
-use OCP\IGroup;
-use OCP\IGroupManager;
-use OCP\ILogger;
+use OCP\Collaboration\Collaborators\ISearch;
 use OCP\IRequest;
-use OCP\IUser;
-use OCP\IUserManager;
 use OCP\IConfig;
-use OCP\IUserSession;
 use OCP\IURLGenerator;
 use OCP\Share;
+use OCP\Share\IManager;
 
 class ShareesAPIController extends OCSController {
-
-	/** @var IGroupManager */
-	protected $groupManager;
-
-	/** @var IUserManager */
-	protected $userManager;
-
-	/** @var IManager */
-	protected $contactsManager;
-
 	/** @var IConfig */
 	protected $config;
 
-	/** @var IUserSession */
-	protected $userSession;
-
 	/** @var IURLGenerator */
 	protected $urlGenerator;
 
-	/** @var ILogger */
-	protected $logger;
-
-	/** @var \OCP\Share\IManager */
+	/** @var IManager */
 	protected $shareManager;
 
-	/** @var IClientService */
-	protected $clientService;
-
-	/** @var ICloudIdManager  */
-	protected $cloudIdManager;
-
 	/** @var bool */
 	protected $shareWithGroupOnly = false;
 
@@ -103,326 +75,31 @@ class ShareesAPIController extends OCSController {
 	];
 
 	protected $reachedEndFor = [];
+	/** @var ISearch */
+	private $collaboratorSearch;
 
 	/**
 	 * @param string $appName
 	 * @param IRequest $request
-	 * @param IGroupManager $groupManager
-	 * @param IUserManager $userManager
-	 * @param IManager $contactsManager
 	 * @param IConfig $config
-	 * @param IUserSession $userSession
 	 * @param IURLGenerator $urlGenerator
-	 * @param ILogger $logger
-	 * @param \OCP\Share\IManager $shareManager
-	 * @param IClientService $clientService
-	 * @param ICloudIdManager $cloudIdManager
+	 * @param IManager $shareManager
+	 * @param ISearch $collaboratorSearch
 	 */
-	public function __construct($appName,
-								IRequest $request,
-								IGroupManager $groupManager,
-								IUserManager $userManager,
-								IManager $contactsManager,
-								IConfig $config,
-								IUserSession $userSession,
-								IURLGenerator $urlGenerator,
-								ILogger $logger,
-								\OCP\Share\IManager $shareManager,
-								IClientService $clientService,
-								ICloudIdManager $cloudIdManager
+	public function __construct(
+		$appName,
+		IRequest $request,
+		IConfig $config,
+		IURLGenerator $urlGenerator,
+		IManager $shareManager,
+		ISearch $collaboratorSearch
 	) {
 		parent::__construct($appName, $request);
 
-		$this->groupManager = $groupManager;
-		$this->userManager = $userManager;
-		$this->contactsManager = $contactsManager;
 		$this->config = $config;
-		$this->userSession = $userSession;
 		$this->urlGenerator = $urlGenerator;
-		$this->logger = $logger;
 		$this->shareManager = $shareManager;
-		$this->clientService = $clientService;
-		$this->cloudIdManager = $cloudIdManager;
-	}
-
-	/**
-	 * @param string $search
-	 */
-	protected function getUsers($search) {
-		$this->result['users'] = $this->result['exact']['users'] = $users = [];
-
-		$userGroups = [];
-		if ($this->shareWithGroupOnly) {
-			// Search in all the groups this user is part of
-			$userGroups = $this->groupManager->getUserGroupIds($this->userSession->getUser());
-			foreach ($userGroups as $userGroup) {
-				$usersTmp = $this->groupManager->displayNamesInGroup($userGroup, $search, $this->limit, $this->offset);
-				foreach ($usersTmp as $uid => $userDisplayName) {
-					$users[$uid] = $userDisplayName;
-				}
-			}
-		} else {
-			// Search in all users
-			$usersTmp = $this->userManager->searchDisplayName($search, $this->limit, $this->offset);
-
-			foreach ($usersTmp as $user) {
-				$users[$user->getUID()] = $user->getDisplayName();
-			}
-		}
-
-		if (!$this->shareeEnumeration || sizeof($users) < $this->limit) {
-			$this->reachedEndFor[] = 'users';
-		}
-
-		$foundUserById = false;
-		$lowerSearch = strtolower($search);
-		foreach ($users as $uid => $userDisplayName) {
-			if (strtolower($uid) === $lowerSearch || strtolower($userDisplayName) === $lowerSearch) {
-				if (strtolower($uid) === $lowerSearch) {
-					$foundUserById = true;
-				}
-				$this->result['exact']['users'][] = [
-					'label' => $userDisplayName,
-					'value' => [
-						'shareType' => Share::SHARE_TYPE_USER,
-						'shareWith' => $uid,
-					],
-				];
-			} else {
-				$this->result['users'][] = [
-					'label' => $userDisplayName,
-					'value' => [
-						'shareType' => Share::SHARE_TYPE_USER,
-						'shareWith' => $uid,
-					],
-				];
-			}
-		}
-
-		if ($this->offset === 0 && !$foundUserById) {
-			// On page one we try if the search result has a direct hit on the
-			// user id and if so, we add that to the exact match list
-			$user = $this->userManager->get($search);
-			if ($user instanceof IUser) {
-				$addUser = true;
-
-				if ($this->shareWithGroupOnly) {
-					// Only add, if we have a common group
-					$commonGroups = array_intersect($userGroups, $this->groupManager->getUserGroupIds($user));
-					$addUser = !empty($commonGroups);
-				}
-
-				if ($addUser) {
-					array_push($this->result['exact']['users'], [
-						'label' => $user->getDisplayName(),
-						'value' => [
-							'shareType' => Share::SHARE_TYPE_USER,
-							'shareWith' => $user->getUID(),
-						],
-					]);
-				}
-			}
-		}
-
-		if (!$this->shareeEnumeration) {
-			$this->result['users'] = [];
-		}
-	}
-
-	/**
-	 * @param string $search
-	 */
-	protected function getGroups($search) {
-		$this->result['groups'] = $this->result['exact']['groups'] = [];
-
-		$groups = $this->groupManager->search($search, $this->limit, $this->offset);
-		$groupIds = array_map(function (IGroup $group) { return $group->getGID(); }, $groups);
-
-		if (!$this->shareeEnumeration || sizeof($groups) < $this->limit) {
-			$this->reachedEndFor[] = 'groups';
-		}
-
-		$userGroups =  [];
-		if (!empty($groups) && $this->shareWithGroupOnly) {
-			// Intersect all the groups that match with the groups this user is a member of
-			$userGroups = $this->groupManager->getUserGroups($this->userSession->getUser());
-			$userGroups = array_map(function (IGroup $group) { return $group->getGID(); }, $userGroups);
-			$groupIds = array_intersect($groupIds, $userGroups);
-		}
-
-		$lowerSearch = strtolower($search);
-		foreach ($groups as $group) {
-			// FIXME: use a more efficient approach
-			$gid = $group->getGID();
-			if (!in_array($gid, $groupIds)) {
-				continue;
-			}
-			if (strtolower($gid) === $lowerSearch || strtolower($group->getDisplayName()) === $lowerSearch) {
-				$this->result['exact']['groups'][] = [
-					'label' => $group->getDisplayName(),
-					'value' => [
-						'shareType' => Share::SHARE_TYPE_GROUP,
-						'shareWith' => $gid,
-					],
-				];
-			} else {
-				$this->result['groups'][] = [
-					'label' => $group->getDisplayName(),
-					'value' => [
-						'shareType' => Share::SHARE_TYPE_GROUP,
-						'shareWith' => $gid,
-					],
-				];
-			}
-		}
-
-		if ($this->offset === 0 && empty($this->result['exact']['groups'])) {
-			// On page one we try if the search result has a direct hit on the
-			// user id and if so, we add that to the exact match list
-			$group = $this->groupManager->get($search);
-			if ($group instanceof IGroup && (!$this->shareWithGroupOnly || in_array($group->getGID(), $userGroups))) {
-				array_push($this->result['exact']['groups'], [
-					'label' => $group->getDisplayName(),
-					'value' => [
-						'shareType' => Share::SHARE_TYPE_GROUP,
-						'shareWith' => $group->getGID(),
-					],
-				]);
-			}
-		}
-
-		if (!$this->shareeEnumeration) {
-			$this->result['groups'] = [];
-		}
-	}
-
-
-	/**
-	 * @param string $search
-	 * @suppress PhanUndeclaredClassMethod
-	 */
-	protected function getCircles($search) {
-		$this->result['circles'] = $this->result['exact']['circles'] = [];
-
-		$result = \OCA\Circles\Api\Sharees::search($search, $this->limit, $this->offset);
-		if (array_key_exists('circles', $result['exact'])) {
-			$this->result['exact']['circles'] = $result['exact']['circles'];
-		}
-		if (array_key_exists('circles', $result)) {
-			$this->result['circles'] = $result['circles'];
-		}
-	}
-
-
-	/**
-	 * @param string $search
-	 * @return array
-	 */
-	protected function getRemote($search) {
-		$result = ['results' => [], 'exact' => []];
-
-		// Search in contacts
-		//@todo Pagination missing
-		$addressBookContacts = $this->contactsManager->search($search, ['CLOUD', 'FN']);
-		$result['exactIdMatch'] = false;
-		foreach ($addressBookContacts as $contact) {
-			if (isset($contact['isLocalSystemBook'])) {
-				continue;
-			}
-			if (isset($contact['CLOUD'])) {
-				$cloudIds = $contact['CLOUD'];
-				if (!is_array($cloudIds)) {
-					$cloudIds = [$cloudIds];
-				}
-				$lowerSearch = strtolower($search);
-				foreach ($cloudIds as $cloudId) {
-					try {
-						list(, $serverUrl) = $this->splitUserRemote($cloudId);
-					} catch (\InvalidArgumentException $e) {
-						continue;
-					}
-
-					if (strtolower($contact['FN']) === $lowerSearch || strtolower($cloudId) === $lowerSearch) {
-						if (strtolower($cloudId) === $lowerSearch) {
-							$result['exactIdMatch'] = true;
-						}
-						$result['exact'][] = [
-							'label' => $contact['FN'] . " ($cloudId)",
-							'value' => [
-								'shareType' => Share::SHARE_TYPE_REMOTE,
-								'shareWith' => $cloudId,
-								'server' => $serverUrl,
-							],
-						];
-					} else {
-						$result['results'][] = [
-							'label' => $contact['FN'] . " ($cloudId)",
-							'value' => [
-								'shareType' => Share::SHARE_TYPE_REMOTE,
-								'shareWith' => $cloudId,
-								'server' => $serverUrl,
-							],
-						];
-					}
-				}
-			}
-		}
-
-		if (!$this->shareeEnumeration) {
-			$result['results'] = [];
-		}
-
-		if (!$result['exactIdMatch'] && $this->cloudIdManager->isValidCloudId($search) && $this->offset === 0) {
-			$result['exact'][] = [
-				'label' => $search,
-				'value' => [
-					'shareType' => Share::SHARE_TYPE_REMOTE,
-					'shareWith' => $search,
-				],
-			];
-		}
-
-		$this->reachedEndFor[] = 'remotes';
-
-		return $result;
-	}
-
-	/**
-	 * split user and remote from federated cloud id
-	 *
-	 * @param string $address federated share address
-	 * @return array [user, remoteURL]
-	 * @throws \InvalidArgumentException
-	 */
-	public function splitUserRemote($address) {
-		try {
-			$cloudId = $this->cloudIdManager->resolveCloudId($address);
-			return [$cloudId->getUser(), $cloudId->getRemote()];
-		} catch (\InvalidArgumentException $e) {
-			throw new \InvalidArgumentException('Invalid Federated Cloud ID', 0, $e);
-		}
-	}
-
-	/**
-	 * Strips away a potential file names and trailing slashes:
-	 * - http://localhost
-	 * - http://localhost/
-	 * - http://localhost/index.php
-	 * - http://localhost/index.php/s/{shareToken}
-	 *
-	 * all return: http://localhost
-	 *
-	 * @param string $remote
-	 * @return string
-	 */
-	protected function fixRemoteURL($remote) {
-		$remote = str_replace('\\', '/', $remote);
-		if ($fileNamePosition = strpos($remote, '/index.php')) {
-			$remote = substr($remote, 0, $fileNamePosition);
-		}
-		$remote = rtrim($remote, '/');
-
-		return $remote;
+		$this->collaboratorSearch = $collaboratorSearch;
 	}
 
 	/**
@@ -461,7 +138,9 @@ class ShareesAPIController extends OCSController {
 			Share::SHARE_TYPE_USER,
 		];
 
-		if ($itemType === 'file' || $itemType === 'folder') {
+		if ($itemType === null) {
+			throw new OCSBadRequestException('Missing itemType');
+		} elseif ($itemType === 'file' || $itemType === 'folder') {
 			if ($this->shareManager->allowGroupSharing()) {
 				$shareTypes[] = Share::SHARE_TYPE_GROUP;
 			}
@@ -478,6 +157,7 @@ class ShareesAPIController extends OCSController {
 			$shareTypes[] = Share::SHARE_TYPE_EMAIL;
 		}
 
+		// FIXME: DI
 		if (\OC::$server->getAppManager()->isEnabledForUser('circles') && class_exists('\OCA\Circles\ShareByCircleProvider')) {
 			$shareTypes[] = Share::SHARE_TYPE_CIRCLE;
 		}
@@ -495,94 +175,16 @@ class ShareesAPIController extends OCSController {
 		$this->limit = (int) $perPage;
 		$this->offset = $perPage * ($page - 1);
 
-		return $this->searchSharees($search, $itemType, $shareTypes, $page, $perPage, $lookup);
-	}
-
-	/**
-	 * Method to get out the static call for better testing
-	 *
-	 * @param string $itemType
-	 * @return bool
-	 */
-	protected function isRemoteSharingAllowed($itemType) {
-		try {
-			$backend = \OC\Share\Share::getBackend($itemType);
-			return $backend->isShareTypeAllowed(Share::SHARE_TYPE_REMOTE);
-		} catch (\Exception $e) {
-			return false;
-		}
-	}
-
-	/**
-	 * Testable search function that does not need globals
-	 *
-	 * @param string $search
-	 * @param string $itemType
-	 * @param array $shareTypes
-	 * @param int $page
-	 * @param int $perPage
-	 * @param bool $lookup
-	 * @return DataResponse
-	 * @throws OCSBadRequestException
-	 */
-	protected function searchSharees($search, $itemType, array $shareTypes, $page, $perPage, $lookup) {
-		// Verify arguments
-		if ($itemType === null) {
-			throw new OCSBadRequestException('Missing itemType');
-		}
-
-		// Get users
-		if (in_array(Share::SHARE_TYPE_USER, $shareTypes)) {
-			$this->getUsers($search);
-		}
-
-		// Get groups
-		if (in_array(Share::SHARE_TYPE_GROUP, $shareTypes)) {
-			$this->getGroups($search);
-		}
-
-		// Get circles
-		if (in_array(Share::SHARE_TYPE_CIRCLE, $shareTypes)) {
-			$this->getCircles($search);
-		}
-
-
-		// Get remote
-		$remoteResults = ['results' => [], 'exact' => [], 'exactIdMatch' => false];
-		if (in_array(Share::SHARE_TYPE_REMOTE, $shareTypes)) {
-			$remoteResults = $this->getRemote($search);
-		}
-
-		// Get emails
-		$mailResults = ['results' => [], 'exact' => [], 'exactIdMatch' => false];
-		if (in_array(Share::SHARE_TYPE_EMAIL, $shareTypes)) {
-			$mailResults = $this->getEmail($search);
-		}
-
-		// Get from lookup server
-		if ($lookup) {
-			$this->getLookup($search);
-		}
+		list($result, $hasMoreResults) = $this->collaboratorSearch->search($search, $shareTypes, $lookup, $this->limit, $this->offset);
 
-		// if we have a exact match, either for the federated cloud id or for the
-		// email address we only return the exact match. It is highly unlikely
-		// that the exact same email address and federated cloud id exists
-		if ($mailResults['exactIdMatch'] && !$remoteResults['exactIdMatch']) {
-			$this->result['emails'] = $mailResults['results'];
-			$this->result['exact']['emails'] = $mailResults['exact'];
-		} else if (!$mailResults['exactIdMatch'] && $remoteResults['exactIdMatch']) {
-			$this->result['remotes'] = $remoteResults['results'];
-			$this->result['exact']['remotes'] = $remoteResults['exact'];
-		} else {
-			$this->result['remotes'] = $remoteResults['results'];
-			$this->result['exact']['remotes'] = $remoteResults['exact'];
-			$this->result['emails'] = $mailResults['results'];
-			$this->result['exact']['emails'] = $mailResults['exact'];
+		// extra treatment for 'exact' subarray, with a single merge expected keys might be lost
+		if(isset($result['exact'])) {
+			$result['exact'] = array_merge($this->result['exact'], $result['exact']);
 		}
-
+		$this->result = array_merge($this->result, $result);
 		$response = new DataResponse($this->result);
 
-		if (sizeof($this->reachedEndFor) < 3) {
+		if ($hasMoreResults) {
 			$response->addHeader('Link', $this->getPaginationLink($page, [
 				'search' => $search,
 				'itemType' => $itemType,
@@ -595,166 +197,22 @@ class ShareesAPIController extends OCSController {
 	}
 
 	/**
-	 * @param string $search
-	 * @return array
-	 */
-	protected function getEmail($search) {
-		$result = ['results' => [], 'exact' => [], 'exactIdMatch' => false];
-
-		// Search in contacts
-		//@todo Pagination missing
-		$addressBookContacts = $this->contactsManager->search($search, ['EMAIL', 'FN']);
-		$lowerSearch = strtolower($search);
-		foreach ($addressBookContacts as $contact) {
-			if (isset($contact['EMAIL'])) {
-				$emailAddresses = $contact['EMAIL'];
-				if (!is_array($emailAddresses)) {
-					$emailAddresses = [$emailAddresses];
-				}
-				foreach ($emailAddresses as $emailAddress) {
-					$exactEmailMatch = strtolower($emailAddress) === $lowerSearch;
-
-					if (isset($contact['isLocalSystemBook'])) {
-						if ($exactEmailMatch) {
-							try {
-								$cloud = $this->cloudIdManager->resolveCloudId($contact['CLOUD'][0]);
-							} catch (\InvalidArgumentException $e) {
-								continue;
-							}
-
-							if (!$this->hasUserInResult($cloud->getUser())) {
-								$this->result['exact']['users'][] = [
-									'label' => $contact['FN'] . " ($emailAddress)",
-									'value' => [
-										'shareType' => Share::SHARE_TYPE_USER,
-										'shareWith' => $cloud->getUser(),
-									],
-								];
-							}
-							return ['results' => [], 'exact' => [], 'exactIdMatch' => true];
-						}
-
-						if ($this->shareeEnumeration) {
-							try {
-								$cloud = $this->cloudIdManager->resolveCloudId($contact['CLOUD'][0]);
-							} catch (\InvalidArgumentException $e) {
-								continue;
-							}
-
-							if (!$this->hasUserInResult($cloud->getUser())) {
-								$this->result['users'][] = [
-									'label' => $contact['FN'] . " ($emailAddress)",
-									'value' => [
-										'shareType' => Share::SHARE_TYPE_USER,
-										'shareWith' => $cloud->getUser(),
-									],
-								];
-							}
-						}
-						continue;
-					}
-
-					if ($exactEmailMatch || strtolower($contact['FN']) === $lowerSearch) {
-						if ($exactEmailMatch) {
-							$result['exactIdMatch'] = true;
-						}
-						$result['exact'][] = [
-							'label' => $contact['FN'] . " ($emailAddress)",
-							'value' => [
-								'shareType' => Share::SHARE_TYPE_EMAIL,
-								'shareWith' => $emailAddress,
-							],
-						];
-					} else {
-						$result['results'][] = [
-							'label' => $contact['FN'] . " ($emailAddress)",
-							'value' => [
-								'shareType' => Share::SHARE_TYPE_EMAIL,
-								'shareWith' => $emailAddress,
-							],
-						];
-					}
-				}
-			}
-		}
-
-		if (!$this->shareeEnumeration) {
-			$result['results'] = [];
-		}
-
-		if (!$result['exactIdMatch'] && filter_var($search, FILTER_VALIDATE_EMAIL)) {
-			$result['exact'][] = [
-				'label' => $search,
-				'value' => [
-					'shareType' => Share::SHARE_TYPE_EMAIL,
-					'shareWith' => $search,
-				],
-			];
-		}
-
-		$this->reachedEndFor[] = 'emails';
-
-		return $result;
-	}
-
-	protected function getLookup($search) {
-		$isEnabled = $this->config->getAppValue('files_sharing', 'lookupServerEnabled', 'no');
-		$lookupServerUrl = $this->config->getSystemValue('lookup_server', 'https://lookup.nextcloud.com');
-		$lookupServerUrl = rtrim($lookupServerUrl, '/');
-		$result = [];
-
-		if($isEnabled === 'yes') {
-			try {
-				$client = $this->clientService->newClient();
-				$response = $client->get(
-					$lookupServerUrl . '/users?search=' . urlencode($search),
-					[
-						'timeout' => 10,
-						'connect_timeout' => 3,
-					]
-				);
-
-				$body = json_decode($response->getBody(), true);
-
-				$result = [];
-				foreach ($body as $lookup) {
-					$result[] = [
-						'label' => $lookup['federationId'],
-						'value' => [
-							'shareType' => Share::SHARE_TYPE_REMOTE,
-							'shareWith' => $lookup['federationId'],
-						],
-						'extra' => $lookup,
-					];
-				}
-			} catch (\Exception $e) {}
-		}
-
-		$this->result['lookup'] = $result;
-	}
-
-	/**
-	 * Check if a given user is already part of the result
+	 * Method to get out the static call for better testing
 	 *
-	 * @param string $userId
+	 * @param string $itemType
 	 * @return bool
 	 */
-	protected function hasUserInResult($userId) {
-		foreach ($this->result['exact']['users'] as $result) {
-			if ($result['value']['shareWith'] === $userId) {
-				return true;
-			}
-		}
-
-		foreach ($this->result['users'] as $result) {
-			if ($result['value']['shareWith'] === $userId) {
-				return true;
-			}
+	protected function isRemoteSharingAllowed($itemType) {
+		try {
+			// FIXME: static foo makes unit testing unnecessarily difficult
+			$backend = \OC\Share\Share::getBackend($itemType);
+			return $backend->isShareTypeAllowed(Share::SHARE_TYPE_REMOTE);
+		} catch (\Exception $e) {
+			return false;
 		}
-
-		return false;
 	}
 
+
 	/**
 	 * Generates a bunch of pagination links for the current page
 	 *
diff --git a/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php b/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
index e027d0751cb..2b919f4849d 100644
--- a/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
+++ b/apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
@@ -25,14 +25,16 @@
 
 namespace OCA\Files_Sharing\Tests\Controller;
 
-use OC\Federation\CloudIdManager;
 use OCA\Files_Sharing\Controller\ShareesAPIController;
 use OCA\Files_Sharing\Tests\TestCase;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\OCS\OCSBadRequestException;
-use OCP\Federation\ICloudIdManager;
-use OCP\Http\Client\IClientService;
+use OCP\Collaboration\Collaborators\ISearch;
+use OCP\IConfig;
+use OCP\IRequest;
+use OCP\IURLGenerator;
 use OCP\Share;
+use OCP\Share\IManager;
 
 /**
  * Class ShareesTest
@@ -45,1251 +47,39 @@ class ShareesAPIControllerTest extends TestCase {
 	/** @var ShareesAPIController */
 	protected $sharees;
 
-	/** @var \OCP\IUserManager|\PHPUnit_Framework_MockObject_MockObject */
-	protected $userManager;
-
-	/** @var \OCP\IGroupManager|\PHPUnit_Framework_MockObject_MockObject */
-	protected $groupManager;
-
-	/** @var \OCP\Contacts\IManager|\PHPUnit_Framework_MockObject_MockObject */
-	protected $contactsManager;
-
-	/** @var \OCP\IUserSession|\PHPUnit_Framework_MockObject_MockObject */
-	protected $session;
-
-	/** @var \OCP\IRequest|\PHPUnit_Framework_MockObject_MockObject */
+	/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject */
 	protected $request;
 
-	/** @var \OCP\Share\IManager|\PHPUnit_Framework_MockObject_MockObject */
+	/** @var IManager|\PHPUnit_Framework_MockObject_MockObject */
 	protected $shareManager;
 
-	/** @var IClientService|\PHPUnit_Framework_MockObject_MockObject */
-	private $clientService;
-
-	/** @var  ICloudIdManager */
-	private $cloudIdManager;
+	/** @var  ISearch|\PHPUnit_Framework_MockObject_MockObject */
+	protected $collaboratorSearch;
 
 	protected function setUp() {
 		parent::setUp();
 
-		$this->userManager = $this->getMockBuilder('OCP\IUserManager')
-			->disableOriginalConstructor()
-			->getMock();
+		$this->request = $this->createMock(IRequest::class);
+		$this->shareManager = $this->createMock(IManager::class);
 
-		$this->groupManager = $this->getMockBuilder('OCP\IGroupManager')
-			->disableOriginalConstructor()
-			->getMock();
+		/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $configMock */
+		$configMock = $this->createMock(IConfig::class);
 
-		$this->contactsManager = $this->getMockBuilder('OCP\Contacts\IManager')
-			->disableOriginalConstructor()
-			->getMock();
+		/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGeneratorMock */
+		$urlGeneratorMock = $this->createMock(IURLGenerator::class);
 
-		$this->session = $this->getMockBuilder('OCP\IUserSession')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->request = $this->getMockBuilder('OCP\IRequest')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->shareManager = $this->getMockBuilder('OCP\Share\IManager')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$this->clientService = $this->createMock(IClientService::class);
-
-		$this->cloudIdManager = new CloudIdManager();
+		$this->collaboratorSearch = $this->createMock(ISearch::class);
 
 		$this->sharees = new ShareesAPIController(
 			'files_sharing',
 			$this->request,
-			$this->groupManager,
-			$this->userManager,
-			$this->contactsManager,
-			$this->getMockBuilder('OCP\IConfig')->disableOriginalConstructor()->getMock(),
-			$this->session,
-			$this->getMockBuilder('OCP\IURLGenerator')->disableOriginalConstructor()->getMock(),
-			$this->getMockBuilder('OCP\ILogger')->disableOriginalConstructor()->getMock(),
+			$configMock,
+			$urlGeneratorMock,
 			$this->shareManager,
-			$this->clientService,
-			$this->cloudIdManager
+			$this->collaboratorSearch
 		);
 	}
 
-	/**
-	 * @param string $uid
-	 * @param string $displayName
-	 * @return \OCP\IUser|\PHPUnit_Framework_MockObject_MockObject
-	 */
-	protected function getUserMock($uid, $displayName) {
-		$user = $this->getMockBuilder('OCP\IUser')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$user->expects($this->any())
-			->method('getUID')
-			->willReturn($uid);
-
-		$user->expects($this->any())
-			->method('getDisplayName')
-			->willReturn($displayName);
-
-		return $user;
-	}
-
-	/**
-	 * @param string $gid
-	 * @return \OCP\IGroup|\PHPUnit_Framework_MockObject_MockObject
-	 */
-	protected function getGroupMock($gid, $displayName = null) {
-		$group = $this->getMockBuilder('OCP\IGroup')
-			->disableOriginalConstructor()
-			->getMock();
-
-		$group->expects($this->any())
-			->method('getGID')
-			->willReturn($gid);
-
-		if (is_null($displayName)) {
-			// note: this is how the Group class behaves
-			$displayName = $gid;
-		}
-
-		$group->expects($this->any())
-			->method('getDisplayName')
-			->willReturn($displayName);
-
-		return $group;
-	}
-
-	public function dataGetUsers() {
-		return [
-			['test', false, true, [], [], [], [], true, false],
-			['test', false, false, [], [], [], [], true, false],
-			['test', true, true, [], [], [], [], true, false],
-			['test', true, false, [], [], [], [], true, false],
-			[
-				'test', false, true, [], [],
-				[
-					['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
-				], [], true, $this->getUserMock('test', 'Test')
-			],
-			[
-				'test', false, false, [], [],
-				[
-					['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
-				], [], true, $this->getUserMock('test', 'Test')
-			],
-			[
-				'test', true, true, [], [],
-				[], [], true, $this->getUserMock('test', 'Test')
-			],
-			[
-				'test', true, false, [], [],
-				[], [], true, $this->getUserMock('test', 'Test')
-			],
-			[
-				'test', true, true, ['test-group'], [['test-group', 'test', 2, 0, []]],
-				[
-					['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
-				], [], true, $this->getUserMock('test', 'Test')
-			],
-			[
-				'test', true, false, ['test-group'], [['test-group', 'test', 2, 0, []]],
-				[
-					['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
-				], [], true, $this->getUserMock('test', 'Test')
-			],
-			[
-				'test',
-				false,
-				true,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-				],
-				true,
-				false,
-			],
-			[
-				'test',
-				false,
-				false,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-				],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				false,
-				true,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-					['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
-				],
-				false,
-				false,
-			],
-			[
-				'test',
-				false,
-				false,
-				[],
-				[
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				false,
-				true,
-				[],
-				[
-					$this->getUserMock('test0', 'Test'),
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[
-					['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test0']],
-				],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-					['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
-				],
-				false,
-				false,
-			],
-			[
-				'test',
-				false,
-				false,
-				[],
-				[
-					$this->getUserMock('test0', 'Test'),
-					$this->getUserMock('test1', 'Test One'),
-					$this->getUserMock('test2', 'Test Two'),
-				],
-				[
-					['label' => 'Test', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test0']],
-				],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				true,
-				true,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, ['test1' => 'Test One']],
-					['xyz', 'test', 2, 0, []],
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-				],
-				true,
-				false,
-			],
-			[
-				'test',
-				true,
-				false,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, ['test1' => 'Test One']],
-					['xyz', 'test', 2, 0, []],
-				],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				true,
-				true,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-				],
-				[],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-					['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
-				],
-				false,
-				false,
-			],
-			[
-				'test',
-				true,
-				false,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test1' => 'Test One',
-						'test2' => 'Test Two',
-					]],
-				],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test',
-				true,
-				true,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test' => 'Test One',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test2' => 'Test Two',
-					]],
-				],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
-				],
-				[
-					['label' => 'Test Two', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
-				],
-				false,
-				false,
-			],
-			[
-				'test',
-				true,
-				false,
-				['abc', 'xyz'],
-				[
-					['abc', 'test', 2, 0, [
-						'test' => 'Test One',
-					]],
-					['xyz', 'test', 2, 0, [
-						'test2' => 'Test Two',
-					]],
-				],
-				[
-					['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test']],
-				],
-				[],
-				true,
-				false,
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetUsers
-	 *
-	 * @param string $searchTerm
-	 * @param bool $shareWithGroupOnly
-	 * @param bool $shareeEnumeration
-	 * @param array $groupResponse
-	 * @param array $userResponse
-	 * @param array $exactExpected
-	 * @param array $expected
-	 * @param bool $reachedEnd
-	 * @param mixed $singleUser
-	 */
-	public function testGetUsers($searchTerm, $shareWithGroupOnly, $shareeEnumeration, $groupResponse, $userResponse, $exactExpected, $expected, $reachedEnd, $singleUser) {
-		$this->invokePrivate($this->sharees, 'limit', [2]);
-		$this->invokePrivate($this->sharees, 'offset', [0]);
-		$this->invokePrivate($this->sharees, 'shareWithGroupOnly', [$shareWithGroupOnly]);
-		$this->invokePrivate($this->sharees, 'shareeEnumeration', [$shareeEnumeration]);
-
-		$user = $this->getUserMock('admin', 'Administrator');
-		$this->session->expects($this->any())
-			->method('getUser')
-			->willReturn($user);
-
-		if (!$shareWithGroupOnly) {
-			$this->userManager->expects($this->once())
-				->method('searchDisplayName')
-				->with($searchTerm, $this->invokePrivate($this->sharees, 'limit'), $this->invokePrivate($this->sharees, 'offset'))
-				->willReturn($userResponse);
-		} else {
-			if ($singleUser !== false) {
-				$this->groupManager->expects($this->exactly(2))
-					->method('getUserGroupIds')
-					->withConsecutive(
-						$user,
-						$singleUser
-					)
-					->willReturn($groupResponse);
-			} else {
-				$this->groupManager->expects($this->once())
-					->method('getUserGroupIds')
-					->with($user)
-					->willReturn($groupResponse);
-			}
-
-			$this->groupManager->expects($this->exactly(sizeof($groupResponse)))
-				->method('displayNamesInGroup')
-				->with($this->anything(), $searchTerm, $this->invokePrivate($this->sharees, 'limit'), $this->invokePrivate($this->sharees, 'offset'))
-				->willReturnMap($userResponse);
-		}
-
-		if ($singleUser !== false) {
-			$this->userManager->expects($this->once())
-				->method('get')
-				->with($searchTerm)
-				->willReturn($singleUser);
-		}
-
-		$this->invokePrivate($this->sharees, 'getUsers', [$searchTerm]);
-		$result = $this->invokePrivate($this->sharees, 'result');
-
-		$this->assertEquals($exactExpected, $result['exact']['users']);
-		$this->assertEquals($expected, $result['users']);
-		$this->assertCount((int) $reachedEnd, $this->invokePrivate($this->sharees, 'reachedEndFor'));
-	}
-
-	public function dataGetGroups() {
-		return [
-			['test', false, true, [], [], [], [], true, false],
-			['test', false, false, [], [], [], [], true, false],
-			// group without display name
-			[
-				'test', false, true,
-				[$this->getGroupMock('test1')],
-				[],
-				[],
-				[['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				true,
-				false,
-			],
-			// group with display name, search by id
-			[
-				'test', false, true,
-				[$this->getGroupMock('test1', 'Test One')],
-				[],
-				[],
-				[['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				true,
-				false,
-			],
-			// group with display name, search by display name
-			[
-				'one', false, true,
-				[$this->getGroupMock('test1', 'Test One')],
-				[],
-				[],
-				[['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				true,
-				false,
-			],
-			// group with display name, search by display name, exact expected
-			[
-				'Test One', false, true,
-				[$this->getGroupMock('test1', 'Test One')],
-				[],
-				[['label' => 'Test One', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				[],
-				true,
-				false,
-			],
-			[
-				'test', false, false,
-				[$this->getGroupMock('test1')],
-				[],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test', false, true,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[],
-				[['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']]],
-				[['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				false,
-				false,
-			],
-			[
-				'test', false, false,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[],
-				[['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']]],
-				[],
-				true,
-				false,
-			],
-			[
-				'test', false, true,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[],
-				[],
-				[
-					['label' => 'test0', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test0']],
-					['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']],
-				],
-				false,
-				null,
-			],
-			[
-				'test', false, false,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[],
-				[],
-				[],
-				true,
-				null,
-			],
-			[
-				'test', false, true,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[],
-				[
-					['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']],
-				],
-				[
-					['label' => 'test0', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test0']],
-					['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']],
-				],
-				false,
-				$this->getGroupMock('test'),
-			],
-			[
-				'test', false, false,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[],
-				[
-					['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']],
-				],
-				[],
-				true,
-				$this->getGroupMock('test'),
-			],
-			['test', true, true, [], [], [], [], true, false],
-			['test', true, false, [], [], [], [], true, false],
-			[
-				'test', true, true,
-				[
-					$this->getGroupMock('test1'),
-					$this->getGroupMock('test2'),
-				],
-				[$this->getGroupMock('test1')],
-				[],
-				[['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				false,
-				false,
-			],
-			[
-				'test', true, false,
-				[
-					$this->getGroupMock('test1'),
-					$this->getGroupMock('test2'),
-				],
-				[$this->getGroupMock('test1')],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test', true, true,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test')],
-				[['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']]],
-				[],
-				false,
-				false,
-			],
-			[
-				'test', true, false,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test')],
-				[['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']]],
-				[],
-				true,
-				false,
-			],
-			[
-				'test', true, true,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test1')],
-				[],
-				[['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				false,
-				false,
-			],
-			[
-				'test', true, false,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test1')],
-				[],
-				[],
-				true,
-				false,
-			],
-			[
-				'test', true, true,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test'), $this->getGroupMock('test0'), $this->getGroupMock('test1')],
-				[['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']]],
-				[['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']]],
-				false,
-				false,
-			],
-			[
-				'test', true, false,
-				[
-					$this->getGroupMock('test'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test'), $this->getGroupMock('test0'), $this->getGroupMock('test1')],
-				[['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']]],
-				[],
-				true,
-				false,
-			],
-			[
-				'test', true, true,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test'), $this->getGroupMock('test0'), $this->getGroupMock('test1')],
-				[],
-				[
-					['label' => 'test0', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test0']],
-					['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']],
-				],
-				false,
-				null,
-			],
-			[
-				'test', true, false,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test'), $this->getGroupMock('test0'), $this->getGroupMock('test1')],
-				[],
-				[],
-				true,
-				null,
-			],
-			[
-				'test', true, true,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test'), $this->getGroupMock('test0'), $this->getGroupMock('test1')],
-				[
-					['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']],
-				],
-				[
-					['label' => 'test0', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test0']],
-					['label' => 'test1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test1']],
-				],
-				false,
-				$this->getGroupMock('test'),
-			],
-			[
-				'test', true, false,
-				[
-					$this->getGroupMock('test0'),
-					$this->getGroupMock('test1'),
-				],
-				[$this->getGroupMock('test'), $this->getGroupMock('test0'), $this->getGroupMock('test1')],
-				[
-					['label' => 'test', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'test']],
-				],
-				[],
-				true,
-				$this->getGroupMock('test'),
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetGroups
-	 *
-	 * @param string $searchTerm
-	 * @param bool $shareWithGroupOnly
-	 * @param bool $shareeEnumeration
-	 * @param array $groupResponse
-	 * @param array $userGroupsResponse
-	 * @param array $exactExpected
-	 * @param array $expected
-	 * @param bool $reachedEnd
-	 * @param mixed $singleGroup
-	 */
-	public function testGetGroups($searchTerm, $shareWithGroupOnly, $shareeEnumeration, $groupResponse, $userGroupsResponse, $exactExpected, $expected, $reachedEnd, $singleGroup) {
-		$this->invokePrivate($this->sharees, 'limit', [2]);
-		$this->invokePrivate($this->sharees, 'offset', [0]);
-		$this->invokePrivate($this->sharees, 'shareWithGroupOnly', [$shareWithGroupOnly]);
-		$this->invokePrivate($this->sharees, 'shareeEnumeration', [$shareeEnumeration]);
-
-		$this->groupManager->expects($this->once())
-			->method('search')
-			->with($searchTerm, $this->invokePrivate($this->sharees, 'limit'), $this->invokePrivate($this->sharees, 'offset'))
-			->willReturn($groupResponse);
-
-		if ($singleGroup !== false) {
-			$this->groupManager->expects($this->once())
-				->method('get')
-				->with($searchTerm)
-				->willReturn($singleGroup);
-		}
-
-		if ($shareWithGroupOnly) {
-			$user = $this->getUserMock('admin', 'Administrator');
-			$this->session->expects($this->any())
-				->method('getUser')
-				->willReturn($user);
-
-			$numGetUserGroupsCalls = empty($groupResponse) ? 0 : 1;
-			$this->groupManager->expects($this->exactly($numGetUserGroupsCalls))
-				->method('getUserGroups')
-				->with($user)
-				->willReturn($userGroupsResponse);
-		}
-
-		$this->invokePrivate($this->sharees, 'getGroups', [$searchTerm]);
-		$result = $this->invokePrivate($this->sharees, 'result');
-
-		$this->assertEquals($exactExpected, $result['exact']['groups']);
-		$this->assertEquals($expected, $result['groups']);
-		$this->assertCount((int) $reachedEnd, $this->invokePrivate($this->sharees, 'reachedEndFor'));
-	}
-
-	/**
-	 * @dataProvider dataGetRemote
-	 *
-	 * @param string $searchTerm
-	 * @param array $contacts
-	 * @param bool $shareeEnumeration
-	 * @param array $expected
-	 * @param bool $reachedEnd
-	 */
-	public function testGetRemote($searchTerm, $contacts, $shareeEnumeration, $expected, $reachedEnd) {
-		$this->invokePrivate($this->sharees, 'shareeEnumeration', [$shareeEnumeration]);
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->with($searchTerm, ['CLOUD', 'FN'])
-			->willReturn($contacts);
-
-		$result = $this->invokePrivate($this->sharees, 'getRemote', [$searchTerm]);
-
-		$this->assertEquals($expected, $result);
-		$this->assertCount((int) $reachedEnd, $this->invokePrivate($this->sharees, 'reachedEndFor'));
-	}
-
-	public function dataGetRemote() {
-		return [
-			['test', [], true, ['results' => [], 'exact' => [], 'exactIdMatch' => false], true],
-			['test', [], false, ['results' => [], 'exact' => [], 'exactIdMatch' => false], true],
-			[
-				'test@remote',
-				[],
-				true,
-				['results' => [], 'exact' => [['label' => 'test@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'test@remote']]], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test@remote',
-				[],
-				false,
-				['results' => [], 'exact' => [['label' => 'test@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'test@remote']]], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['results' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exact' => [], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test@remote',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['results' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exact' => [['label' => 'test@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'test@remote']]], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test@remote',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [['label' => 'test@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'test@remote']]], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'username@localhost',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['results' => [], 'exact' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exactIdMatch' => true],
-				true,
-			],
-			[
-				'username@localhost',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'username@localhost', 'server' => 'localhost']]], 'exactIdMatch' => true],
-				true,
-			],
-			// contact with space
-			[
-				'user name@localhost',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User Name @ Localhost',
-						'CLOUD' => [
-							'user name@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [['label' => 'User Name @ Localhost (user name@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'user name@localhost', 'server' => 'localhost']]], 'exactIdMatch' => true],
-				true,
-			],
-			// remote with space, no contact
-			[
-				'user space@remote',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'CLOUD' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'CLOUD' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [['label' => 'user space@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'user space@remote']]], 'exactIdMatch' => false],
-				true,
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataGetEmail
-	 *
-	 * @param string $searchTerm
-	 * @param array $contacts
-	 * @param bool $shareeEnumeration
-	 * @param array $expected
-	 * @param bool $reachedEnd
-	 */
-	public function testGetEmail($searchTerm, $contacts, $shareeEnumeration, $expected, $reachedEnd) {
-		$this->invokePrivate($this->sharees, 'shareeEnumeration', [$shareeEnumeration]);
-		$this->contactsManager->expects($this->any())
-			->method('search')
-			->with($searchTerm, ['EMAIL', 'FN'])
-			->willReturn($contacts);
-
-		$result = $this->invokePrivate($this->sharees, 'getEmail', [$searchTerm]);
-
-		$this->assertEquals($expected, $result);
-		$this->assertCount((int) $reachedEnd, $this->invokePrivate($this->sharees, 'reachedEndFor'));
-	}
-
-	public function dataGetEmail() {
-		return [
-			['test', [], true, ['results' => [], 'exact' => [], 'exactIdMatch' => false], true],
-			['test', [], false, ['results' => [], 'exact' => [], 'exactIdMatch' => false], true],
-			[
-				'test@remote.com',
-				[],
-				true,
-				['results' => [], 'exact' => [['label' => 'test@remote.com', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'test@remote.com']]], 'exactIdMatch' => false],
-				true,
-			],
-			[ // no valid email address
-				'test@remote',
-				[],
-				true,
-				['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test@remote.com',
-				[],
-				false,
-				['results' => [], 'exact' => [['label' => 'test@remote.com', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'test@remote.com']]], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['results' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'username@localhost']]], 'exact' => [], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test@remote.com',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['results' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'username@localhost']]], 'exact' => [['label' => 'test@remote.com', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'test@remote.com']]], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'test@remote.com',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [['label' => 'test@remote.com', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'test@remote.com']]], 'exactIdMatch' => false],
-				true,
-			],
-			[
-				'username@localhost',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				true,
-				['results' => [], 'exact' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'username@localhost']]], 'exactIdMatch' => true],
-				true,
-			],
-			[
-				'username@localhost',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [['label' => 'User @ Localhost (username@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'username@localhost']]], 'exactIdMatch' => true],
-				true,
-			],
-			// contact with space
-			[
-				'user name@localhost',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User Name @ Localhost',
-						'EMAIL' => [
-							'user name@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [['label' => 'User Name @ Localhost (user name@localhost)', 'value' => ['shareType' => Share::SHARE_TYPE_EMAIL, 'shareWith' => 'user name@localhost']]], 'exactIdMatch' => true],
-				true,
-			],
-			// remote with space, no contact
-			[
-				'user space@remote.com',
-				[
-					[
-						'FN' => 'User3 @ Localhost',
-					],
-					[
-						'FN' => 'User2 @ Localhost',
-						'EMAIL' => [
-						],
-					],
-					[
-						'FN' => 'User @ Localhost',
-						'EMAIL' => [
-							'username@localhost',
-						],
-					],
-				],
-				false,
-				['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				true,
-			],
-			// Local user found by email
-			[
-				'test@example.com',
-				[
-					[
-						'FN' => 'User',
-						'EMAIL' => ['test@example.com'],
-						'CLOUD' => ['test@localhost'],
-						'isLocalSystemBook' => true,
-					]
-				],
-				false,
-				['results' => [], 'exact' => [], 'exactIdMatch' => true],
-				false,
-			]
-		];
-	}
-
 	public function dataSearch() {
 		$noRemote = [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_EMAIL];
 		$allTypes = [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_REMOTE, Share::SHARE_TYPE_EMAIL];
@@ -1424,14 +214,13 @@ class ShareesAPIControllerTest extends TestCase {
 	 */
 	public function testSearch($getData, $apiSetting, $enumSetting, $remoteSharingEnabled, $emailSharingEnabled, $shareTypes, $shareWithGroupOnly, $shareeEnumeration, $allowGroupSharing) {
 		$search = isset($getData['search']) ? $getData['search'] : '';
-		$itemType = isset($getData['itemType']) ? $getData['itemType'] : null;
+		$itemType = isset($getData['itemType']) ? $getData['itemType'] : 'irrelevant';
 		$page = isset($getData['page']) ? $getData['page'] : 1;
 		$perPage = isset($getData['perPage']) ? $getData['perPage'] : 200;
 		$shareType = isset($getData['shareType']) ? $getData['shareType'] : null;
 
-		$config = $this->getMockBuilder('OCP\IConfig')
-			->disableOriginalConstructor()
-			->getMock();
+		/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
+		$config = $this->createMock(IConfig::class);
 		$config->expects($this->exactly(2))
 			->method('getAppValue')
 			->with('core', $this->anything(), $this->anything())
@@ -1444,41 +233,29 @@ class ShareesAPIControllerTest extends TestCase {
 			->method('allowGroupSharing')
 			->willReturn($allowGroupSharing);
 
+		/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject $request */
+		$request = $this->createMock(IRequest::class);
+		/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGenerator */
+		$urlGenerator = $this->createMock(IURLGenerator::class);
+
 		/** @var \PHPUnit_Framework_MockObject_MockObject|\OCA\Files_Sharing\Controller\ShareesAPIController $sharees */
 		$sharees = $this->getMockBuilder('\OCA\Files_Sharing\Controller\ShareesAPIController')
 			->setConstructorArgs([
 				'files_sharing',
-				$this->getMockBuilder('OCP\IRequest')->disableOriginalConstructor()->getMock(),
-				$this->groupManager,
-				$this->userManager,
-				$this->contactsManager,
+				$request,
 				$config,
-				$this->session,
-				$this->getMockBuilder('OCP\IURLGenerator')->disableOriginalConstructor()->getMock(),
-				$this->getMockBuilder('OCP\ILogger')->disableOriginalConstructor()->getMock(),
+				$urlGenerator,
 				$this->shareManager,
-				$this->clientService,
-				$this->cloudIdManager
+				$this->collaboratorSearch
 			])
-			->setMethods(array('searchSharees', 'isRemoteSharingAllowed', 'shareProviderExists'))
+			->setMethods(['isRemoteSharingAllowed', 'shareProviderExists'])
 			->getMock();
-		$sharees->expects($this->once())
-			->method('searchSharees')
-			->willReturnCallback(function
-					($isearch, $iitemType, $ishareTypes, $ipage, $iperPage)
-				use ($search, $itemType, $shareTypes, $page, $perPage) {
 
-				// We are doing strict comparisons here, so we can differ 0/'' and null on shareType/itemType
-				$this->assertSame($search, $isearch);
-				$this->assertSame($itemType, $iitemType);
-				$this->assertSame(count($shareTypes), count($ishareTypes));
-				foreach($shareTypes as $expected) {
-					$this->assertTrue(in_array($expected, $ishareTypes));
-				}
-				$this->assertSame($page, $ipage);
-				$this->assertSame($perPage, $iperPage);
-				return new Http\DataResponse();
-			});
+		$this->collaboratorSearch->expects($this->once())
+			->method('search')
+			->with($search, $shareTypes, $this->anything(), $perPage, $perPage * ($page -1))
+			->willReturn([[], false]);
+
 		$sharees->expects($this->any())
 			->method('isRemoteSharingAllowed')
 			->with($itemType)
@@ -1531,35 +308,34 @@ class ShareesAPIControllerTest extends TestCase {
 		$page = isset($getData['page']) ? $getData['page'] : 1;
 		$perPage = isset($getData['perPage']) ? $getData['perPage'] : 200;
 
-		$config = $this->getMockBuilder('OCP\IConfig')
-			->disableOriginalConstructor()
-			->getMock();
+		/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
+		$config = $this->createMock(IConfig::class);
 		$config->expects($this->never())
 			->method('getAppValue');
 
+		/** @var IRequest|\PHPUnit_Framework_MockObject_MockObject $request */
+		$request = $this->createMock(IRequest::class);
+		/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject $urlGenerator */
+		$urlGenerator = $this->createMock(IURLGenerator::class);
+
 		/** @var \PHPUnit_Framework_MockObject_MockObject|\OCA\Files_Sharing\Controller\ShareesAPIController $sharees */
 		$sharees = $this->getMockBuilder('\OCA\Files_Sharing\Controller\ShareesAPIController')
 			->setConstructorArgs([
 				'files_sharing',
-				$this->getMockBuilder('OCP\IRequest')->disableOriginalConstructor()->getMock(),
-				$this->groupManager,
-				$this->userManager,
-				$this->contactsManager,
+				$request,
 				$config,
-				$this->session,
-				$this->getMockBuilder('OCP\IURLGenerator')->disableOriginalConstructor()->getMock(),
-				$this->getMockBuilder('OCP\ILogger')->disableOriginalConstructor()->getMock(),
+				$urlGenerator,
 				$this->shareManager,
-				$this->clientService,
-				$this->cloudIdManager
+				$this->collaboratorSearch
 			])
-			->setMethods(array('searchSharees', 'isRemoteSharingAllowed'))
+			->setMethods(['isRemoteSharingAllowed'])
 			->getMock();
 		$sharees->expects($this->never())
-			->method('searchSharees');
-		$sharees->expects($this->never())
 			->method('isRemoteSharingAllowed');
 
+		$this->collaboratorSearch->expects($this->never())
+			->method('search');
+
 		try {
 			$sharees->search('', null, $page, $perPage, null);
 			$this->fail();
@@ -1587,188 +363,12 @@ class ShareesAPIControllerTest extends TestCase {
 		$this->assertSame($expected, $this->invokePrivate($this->sharees, 'isRemoteSharingAllowed', [$itemType]));
 	}
 
-	public function dataSearchSharees() {
-		return [
-			['test', 'folder', [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_REMOTE], 1, 2, false, [], [], ['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'circles' => [], 'emails' => []],
-					'users' => [],
-					'groups' => [],
-					'remotes' => [],
-					'emails' => [],
-					'circles' => [],
-					'lookup' => [],
-				], false],
-			['test', 'folder', [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_REMOTE], 1, 2, false, [], [], ['results' => [], 'exact' => [], 'exactIdMatch' => false],
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'circles' => [], 'emails' => []],
-					'users' => [],
-					'groups' => [],
-					'remotes' => [],
-					'emails' => [],
-					'circles' => [],
-					'lookup' => [],
-				], false],
-			[
-				'test', 'folder', [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_GROUP, Share::SHARE_TYPE_REMOTE], 1, 2, false, [
-					['label' => 'test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-				], [
-					['label' => 'testgroup1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'testgroup1']],
-				], [
-					'results' => [['label' => 'testz@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'testz@remote']]], 'exact' => [], 'exactIdMatch' => false,
-				],
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'circles' => [], 'emails' => []],
-					'users' => [
-						['label' => 'test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-					],
-					'groups' => [
-						['label' => 'testgroup1', 'value' => ['shareType' => Share::SHARE_TYPE_GROUP, 'shareWith' => 'testgroup1']],
-					],
-					'remotes' => [
-						['label' => 'testz@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'testz@remote']],
-					],
-					'emails' => [],
-					'circles' => [],
-					'lookup' => [],
-				], true,
-			],
-			// No groups requested
-			[
-				'test', 'folder', [Share::SHARE_TYPE_USER, Share::SHARE_TYPE_REMOTE], 1, 2, false, [
-					['label' => 'test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-				], null, [
-					'results' => [['label' => 'testz@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'testz@remote']]], 'exact' => [], 'exactIdMatch' => false
-				],
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'circles' => [], 'emails' => []],
-					'users' => [
-						['label' => 'test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-					],
-					'groups' => [],
-					'remotes' => [
-						['label' => 'testz@remote', 'value' => ['shareType' => Share::SHARE_TYPE_REMOTE, 'shareWith' => 'testz@remote']],
-					],
-					'emails' => [],
-					'circles' => [],
-					'lookup' => [],
-				], false,
-			],
-			// Share type restricted to user - Only one user
-			[
-				'test', 'folder', [Share::SHARE_TYPE_USER], 1, 2, false, [
-					['label' => 'test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-				], null, null,
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'circles' => [], 'emails' => []],
-					'users' => [
-						['label' => 'test One', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-					],
-					'groups' => [],
-					'remotes' => [],
-					'emails' => [],
-					'circles' => [],
-					'lookup' => [],
-				], false,
-			],
-			// Share type restricted to user - Multipage result
-			[
-				'test', 'folder', [Share::SHARE_TYPE_USER], 1, 2, false, [
-					['label' => 'test 1', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-					['label' => 'test 2', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
-				], null, null,
-				[
-					'exact' => ['users' => [], 'groups' => [], 'remotes' => [], 'circles' => [], 'emails' => []],
-					'users' => [
-						['label' => 'test 1', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test1']],
-						['label' => 'test 2', 'value' => ['shareType' => Share::SHARE_TYPE_USER, 'shareWith' => 'test2']],
-					],
-					'groups' => [],
-					'remotes' => [],
-					'emails' => [],
-					'circles' => [],
-					'lookup' => [],
-				], true,
-			],
-		];
-	}
-
-	/**
-	 * @dataProvider dataSearchSharees
-	 *
-	 * @param string $searchTerm
-	 * @param string $itemType
-	 * @param array $shareTypes
-	 * @param int $page
-	 * @param int $perPage
-	 * @param bool $shareWithGroupOnly
-	 * @param array $mockedUserResult
-	 * @param array $mockedGroupsResult
-	 * @param array $mockedRemotesResult
-	 * @param array $expected
-	 * @param bool $nextLink
-	 */
-	public function testSearchSharees($searchTerm, $itemType, array $shareTypes, $page, $perPage, $shareWithGroupOnly,
-									  $mockedUserResult, $mockedGroupsResult, $mockedRemotesResult, $expected, $nextLink) {
-		/** @var \PHPUnit_Framework_MockObject_MockObject|\OCA\Files_Sharing\Controller\ShareesAPIController $sharees */
-		$sharees = $this->getMockBuilder('\OCA\Files_Sharing\Controller\ShareesAPIController')
-			->setConstructorArgs([
-				'files_sharing',
-				$this->getMockBuilder('OCP\IRequest')->disableOriginalConstructor()->getMock(),
-				$this->groupManager,
-				$this->userManager,
-				$this->contactsManager,
-				$this->getMockBuilder('OCP\IConfig')->disableOriginalConstructor()->getMock(),
-				$this->session,
-				$this->getMockBuilder('OCP\IURLGenerator')->disableOriginalConstructor()->getMock(),
-				$this->getMockBuilder('OCP\ILogger')->disableOriginalConstructor()->getMock(),
-				$this->shareManager,
-				$this->clientService,
-				$this->cloudIdManager
-			])
-			->setMethods(array('getShareesForShareIds', 'getUsers', 'getGroups', 'getRemote'))
-			->getMock();
-		$sharees->expects(($mockedUserResult === null) ? $this->never() : $this->once())
-			->method('getUsers')
-			->with($searchTerm)
-			->willReturnCallback(function() use ($sharees, $mockedUserResult) {
-				$result = $this->invokePrivate($sharees, 'result');
-				$result['users'] = $mockedUserResult;
-				$this->invokePrivate($sharees, 'result', [$result]);
-			});
-		$sharees->expects(($mockedGroupsResult === null) ? $this->never() : $this->once())
-			->method('getGroups')
-			->with($searchTerm)
-			->willReturnCallback(function() use ($sharees, $mockedGroupsResult) {
-				$result = $this->invokePrivate($sharees, 'result');
-				$result['groups'] = $mockedGroupsResult;
-				$this->invokePrivate($sharees, 'result', [$result]);
-			});
-
-		$sharees->expects(($mockedRemotesResult === null) ? $this->never() : $this->once())
-			->method('getRemote')
-			->with($searchTerm)
-			->willReturn($mockedRemotesResult);
-
-		$ocs = $this->invokePrivate($sharees, 'searchSharees', [$searchTerm, $itemType, $shareTypes, $page, $perPage, $shareWithGroupOnly]);
-		$this->assertInstanceOf('\OCP\AppFramework\Http\DataResponse', $ocs);
-		$this->assertEquals($expected, $ocs->getData());
-
-		// Check if next link is set
-		if ($nextLink) {
-			$headers = $ocs->getHeaders();
-			$this->assertArrayHasKey('Link', $headers);
-			$this->assertStringStartsWith('<', $headers['Link']);
-			$this->assertStringEndsWith('>; rel="next"', $headers['Link']);
-		}
-	}
-
 	/**
 	 * @expectedException \OCP\AppFramework\OCS\OCSBadRequestException
 	 * @expectedExceptionMessage Missing itemType
 	 */
-	public function testSearchShareesNoItemType() {
-		$this->invokePrivate($this->sharees, 'searchSharees', ['', null, [], [], 0, 0, false]);
+	public function testSearchNoItemType() {
+		$this->sharees->search('', null, 1, 10, [], false);
 	}
 
 	public function dataGetPaginationLink() {
@@ -1814,97 +414,4 @@ class ShareesAPIControllerTest extends TestCase {
 
 		$this->assertEquals($expected, $this->invokePrivate($this->sharees, 'isV2'));
 	}
-
-	/**
-	 * @dataProvider dataTestSplitUserRemote
-	 *
-	 * @param string $remote
-	 * @param string $expectedUser
-	 * @param string $expectedUrl
-	 */
-	public function testSplitUserRemote($remote, $expectedUser, $expectedUrl) {
-		list($remoteUser, $remoteUrl) = $this->sharees->splitUserRemote($remote);
-		$this->assertSame($expectedUser, $remoteUser);
-		$this->assertSame($expectedUrl, $remoteUrl);
-	}
-
-	public function dataTestSplitUserRemote() {
-		$userPrefix = ['user@name', 'username'];
-		$protocols = ['', 'http://', 'https://'];
-		$remotes = [
-			'localhost',
-			'local.host',
-			'dev.local.host',
-			'dev.local.host/path',
-			'dev.local.host/at@inpath',
-			'127.0.0.1',
-			'::1',
-			'::192.0.2.128',
-			'::192.0.2.128/at@inpath',
-		];
-
-		$testCases = [];
-		foreach ($userPrefix as $user) {
-			foreach ($remotes as $remote) {
-				foreach ($protocols as $protocol) {
-					$baseUrl = $user . '@' . $protocol . $remote;
-
-					$testCases[] = [$baseUrl, $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/', $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/index.php', $user, $protocol . $remote];
-					$testCases[] = [$baseUrl . '/index.php/s/token', $user, $protocol . $remote];
-				}
-			}
-		}
-		return $testCases;
-	}
-
-	public function dataTestSplitUserRemoteError() {
-		return array(
-			// Invalid path
-			array('user@'),
-
-			// Invalid user
-			array('@server'),
-			array('us/er@server'),
-			array('us:er@server'),
-
-			// Invalid splitting
-			array('user'),
-			array(''),
-			array('us/erserver'),
-			array('us:erserver'),
-		);
-	}
-
-	/**
-	 * @dataProvider dataTestSplitUserRemoteError
-	 *
-	 * @param string $id
-	 * @expectedException \Exception
-	 */
-	public function testSplitUserRemoteError($id) {
-		$this->sharees->splitUserRemote($id);
-	}
-
-	/**
-	 * @dataProvider dataTestFixRemoteUrl
-	 *
-	 * @param string $url
-	 * @param string $expected
-	 */
-	public function testFixRemoteUrl($url, $expected) {
-		$this->assertSame($expected,
-			$this->invokePrivate($this->sharees, 'fixRemoteURL', [$url])
-		);
-	}
-
-	public function dataTestFixRemoteUrl() {
-		return [
-			['http://localhost', 'http://localhost'],
-			['http://localhost/', 'http://localhost'],
-			['http://localhost/index.php', 'http://localhost'],
-			['http://localhost/index.php/s/AShareToken', 'http://localhost'],
-		];
-	}
 }