diff options
| author | Roeland Jago Douma <rullzer@users.noreply.github.com> | 2021-04-26 17:23:12 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-26 17:23:12 +0200 |
| commit | 10df6b93c196bba146fc2c44d3cc04b2caf83a3d (patch) | |
| tree | 69ca1dbda1f13058e83f23fd493cb81cf531c167 /apps | |
| parent | 303d689001a124fe193d39c2c61734cd383fb8a0 (diff) | |
| parent | 70f12e7332e341c259a4ca94502f743c9c021570 (diff) | |
| download | nextcloud-server-10df6b93c196bba146fc2c44d3cc04b2caf83a3d.tar.gz nextcloud-server-10df6b93c196bba146fc2c44d3cc04b2caf83a3d.zip | |
Merge pull request #26763 from nextcloud/enh/federation/improve_permissions
Improve federated permission handling
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php b/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php index 63877f3307c..e21ce633dd2 100644 --- a/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php +++ b/apps/federatedfilesharing/lib/OCM/CloudFederationProviderFiles.php @@ -31,6 +31,7 @@ namespace OCA\FederatedFileSharing\OCM; use OC\AppFramework\Http; use OC\Files\Filesystem; +use OC\HintException; use OCA\FederatedFileSharing\AddressHandler; use OCA\FederatedFileSharing\FederatedShareProvider; use OCA\Files_Sharing\Activity\Providers\RemoteShares; @@ -678,24 +679,7 @@ class CloudFederationProviderFiles implements ICloudFederationProvider { * @throws BadRequestException */ protected function updateResharePermissions($id, array $notification) { - if (!isset($notification['sharedSecret'])) { - throw new BadRequestException(['sharedSecret']); - } - $token = $notification['sharedSecret']; - - if (!isset($notification['permission'])) { - throw new BadRequestException(['permission']); - } - $ocmPermissions = $notification['permission']; - - $share = $this->federatedShareProvider->getShareById($id); - - $ncPermission = $this->ocmPermissions2ncPermissions($ocmPermissions); - - $this->verifyShare($share, $token); - $this->updatePermissionsInDatabase($share, $ncPermission); - - return []; + throw new HintException('Updating reshares not allowed'); } /** |