summaryrefslogtreecommitdiffstats
path: root/apps
diff options
context:
space:
mode:
authorBjoern Schiessle <bjoern@schiessle.org>2017-05-12 14:55:30 +0200
committerLukas Reschke <lukas@statuscode.ch>2017-05-18 20:49:07 +0200
commitbb19b3709706b49cdae65c77d28ab89ad3679951 (patch)
treea6343e37ef44d8d405db3252c53121841572679b /apps
parentbaa8490f44b18ef10c46a117f2143b80f18455bb (diff)
downloadnextcloud-server-bb19b3709706b49cdae65c77d28ab89ad3679951.tar.gz
nextcloud-server-bb19b3709706b49cdae65c77d28ab89ad3679951.zip
hide client secret by default
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Diffstat (limited to 'apps')
-rw-r--r--apps/oauth2/css/setting-admin.css5
-rw-r--r--apps/oauth2/js/setting-admin.js16
-rw-r--r--apps/oauth2/templates/admin.php7
3 files changed, 26 insertions, 2 deletions
diff --git a/apps/oauth2/css/setting-admin.css b/apps/oauth2/css/setting-admin.css
new file mode 100644
index 00000000000..a57a56bb976
--- /dev/null
+++ b/apps/oauth2/css/setting-admin.css
@@ -0,0 +1,5 @@
+.show-oauth-credentials {
+ padding-left: 10px;
+ opacity: 0.3;
+ cursor: pointer;
+}
diff --git a/apps/oauth2/js/setting-admin.js b/apps/oauth2/js/setting-admin.js
new file mode 100644
index 00000000000..be774fd720a
--- /dev/null
+++ b/apps/oauth2/js/setting-admin.js
@@ -0,0 +1,16 @@
+
+$(document).ready(function () {
+
+ $('.show-oauth-credentials').click(function() {
+ var row = $(this).parent();
+ var code = $(row).find('code');
+ if(code.text() === '****') {
+ code.text(row.data('value'));
+ $(this).css('opacity', 0.9);
+ } else {
+ code.text('****');
+ $(this).css('opacity', 0.3);
+ }
+ })
+
+});
diff --git a/apps/oauth2/templates/admin.php b/apps/oauth2/templates/admin.php
index f5b8532e6b1..9c09499add3 100644
--- a/apps/oauth2/templates/admin.php
+++ b/apps/oauth2/templates/admin.php
@@ -22,6 +22,9 @@
$urlGenerator = \OC::$server->getURLGenerator();
$themingDefaults = \OC::$server->getThemingDefaults();
+script('oauth2', 'setting-admin');
+style('oauth2', 'setting-admin');
+
/** @var array $_ */
/** @var \OCA\OAuth2\Db\Client[] $clients */
$clients = $_['clients'];
@@ -47,7 +50,7 @@ $clients = $_['clients'];
<td><?php p($client->getName()); ?></td>
<td><?php p($client->getRedirectUri()); ?></td>
<td><code><?php p($client->getClientIdentifier()); ?></code></td>
- <td><code><?php p($client->getSecret()); ?></code></td>
+ <td data-value="<?php p($client->getSecret()); ?>"><code>****</code><img class='show-oauth-credentials' src="<?php p($urlGenerator->imagePath('core', 'actions/toggle.svg'));?>"/></td>
<td>
<form id="form-inline" class="delete" action="<?php p($urlGenerator->linkToRoute('oauth2.Settings.deleteClient', ['id' => $client->getId()])); ?>" method="POST">
<input type="hidden" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
@@ -67,4 +70,4 @@ $clients = $_['clients'];
<input type="hidden" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
<input type="submit" class="button" value="<?php p($l->t('Add')); ?>">
</form>
-</div> \ No newline at end of file
+</div>